diff mbox

[bugfix,1/2] crypto: arm64/sha1-ce - prevent asm code finalization in final() path

Message ID 1430920472-20416-1-git-send-email-ard.biesheuvel@linaro.org (mailing list archive)
State Accepted
Delegated to: Herbert Xu
Headers show

Commit Message

Ard Biesheuvel May 6, 2015, 1:54 p.m. UTC
Ensure that the asm code finalization path is not triggered when
invoked via final(), since it already takes care of that itself.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 arch/arm64/crypto/sha1-ce-glue.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Herbert Xu May 7, 2015, 3:19 a.m. UTC | #1
On Wed, May 06, 2015 at 03:54:31PM +0200, Ard Biesheuvel wrote:
> Ensure that the asm code finalization path is not triggered when
> invoked via final(), since it already takes care of that itself.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Both applied to crypto.
diff mbox

Patch

diff --git a/arch/arm64/crypto/sha1-ce-glue.c b/arch/arm64/crypto/sha1-ce-glue.c
index 114e7cc5de8c..aefda9868627 100644
--- a/arch/arm64/crypto/sha1-ce-glue.c
+++ b/arch/arm64/crypto/sha1-ce-glue.c
@@ -74,6 +74,9 @@  static int sha1_ce_finup(struct shash_desc *desc, const u8 *data,
 
 static int sha1_ce_final(struct shash_desc *desc, u8 *out)
 {
+	struct sha1_ce_state *sctx = shash_desc_ctx(desc);
+
+	sctx->finalize = 0;
 	kernel_neon_begin_partial(16);
 	sha1_base_do_finalize(desc, (sha1_block_fn *)sha1_ce_transform);
 	kernel_neon_end();