diff mbox

crypto: move Kconfig 842 to end of list, default to N

Message ID 1432339708-4340-1-git-send-email-ddstreet@ieee.org (mailing list archive)
State Changes Requested
Delegated to: Herbert Xu
Headers show

Commit Message

Dan Streetman May 23, 2015, 12:08 a.m. UTC
Move the 842 compression alg choice to last in the list, so it's
not in the middle of LZO/LZ4/LZ4HC.  Change its default to N, as it
is a very slow alg, which generally should only be used with
compression hardware that's capable of doing it much faster.

Signed-off-by: Dan Streetman <ddstreet@ieee.org>
---
 crypto/Kconfig | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

Comments

Herbert Xu May 23, 2015, 12:34 a.m. UTC | #1
On Fri, May 22, 2015 at 08:08:28PM -0400, Dan Streetman wrote:
> Move the 842 compression alg choice to last in the list, so it's
> not in the middle of LZO/LZ4/LZ4HC.  Change its default to N, as it
> is a very slow alg, which generally should only be used with
> compression hardware that's capable of doing it much faster.
> 
> Signed-off-by: Dan Streetman <ddstreet@ieee.org>

The default default is "n" so this is redundant.

Cheers,
Dan Streetman May 23, 2015, 12:35 a.m. UTC | #2
On Fri, May 22, 2015 at 8:34 PM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Fri, May 22, 2015 at 08:08:28PM -0400, Dan Streetman wrote:
>> Move the 842 compression alg choice to last in the list, so it's
>> not in the middle of LZO/LZ4/LZ4HC.  Change its default to N, as it
>> is a very slow alg, which generally should only be used with
>> compression hardware that's capable of doing it much faster.
>>
>> Signed-off-by: Dan Streetman <ddstreet@ieee.org>
>
> The default default is "n" so this is redundant.

ah ok. never mind then! :-)

>
> Cheers,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/crypto/Kconfig b/crypto/Kconfig
index 24df47b..62ced6f 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -1419,14 +1419,6 @@  config CRYPTO_LZO
 	help
 	  This is the LZO algorithm.
 
-config CRYPTO_842
-	tristate "842 compression algorithm"
-	select CRYPTO_ALGAPI
-	select 842_COMPRESS
-	select 842_DECOMPRESS
-	help
-	  This is the 842 algorithm.
-
 config CRYPTO_LZ4
 	tristate "LZ4 compression algorithm"
 	select CRYPTO_ALGAPI
@@ -1443,6 +1435,15 @@  config CRYPTO_LZ4HC
 	help
 	  This is the LZ4 high compression mode algorithm.
 
+config CRYPTO_842
+	tristate "842 compression algorithm"
+	default n
+	select CRYPTO_ALGAPI
+	select 842_COMPRESS
+	select 842_DECOMPRESS
+	help
+	  This is the 842 algorithm.
+
 comment "Random Number Generation"
 
 config CRYPTO_ANSI_CPRNG