| Message ID | 1434412379-11623-7-git-send-email-vicki.milhoan@freescale.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Herbert Xu |
| Headers | show |
On Mon, Jun 15, 2015 at 04:52:54PM -0700, Victoria Milhoan wrote: > From: Steve Cornelius <steve.cornelius@freescale.com> > > Allow CAAM to be selected in the kernel for Freescale i.MX6 devices if > ARCH_MXC is enabled. > > Signed-off-by: Steve Cornelius <steve.cornelius@freescale.com> > Signed-off-by: Victoria Milhoan <vicki.milhoan@freescale.com> > --- > drivers/crypto/caam/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/caam/Kconfig b/drivers/crypto/caam/Kconfig > index e7555ff..bc9aa07 100644 > --- a/drivers/crypto/caam/Kconfig > +++ b/drivers/crypto/caam/Kconfig > @@ -1,6 +1,6 @@ > config CRYPTO_DEV_FSL_CAAM > tristate "Freescale CAAM-Multicore driver backend" > - depends on FSL_SOC > + depends on FSL_SOC || ARCH_MXC Is this right? Are there other i.MX that have the CAAM IP core? Sounds like it should be SOC_IMX6 instead. Regards, Steffen
On 6/17/2015 10:27 AM, Steffen Trumtrar wrote: > On Mon, Jun 15, 2015 at 04:52:54PM -0700, Victoria Milhoan wrote: >> From: Steve Cornelius <steve.cornelius@freescale.com> >> >> Allow CAAM to be selected in the kernel for Freescale i.MX6 devices if >> ARCH_MXC is enabled. >> >> Signed-off-by: Steve Cornelius <steve.cornelius@freescale.com> >> Signed-off-by: Victoria Milhoan <vicki.milhoan@freescale.com> >> --- >> drivers/crypto/caam/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/crypto/caam/Kconfig b/drivers/crypto/caam/Kconfig >> index e7555ff..bc9aa07 100644 >> --- a/drivers/crypto/caam/Kconfig >> +++ b/drivers/crypto/caam/Kconfig >> @@ -1,6 +1,6 @@ >> config CRYPTO_DEV_FSL_CAAM >> tristate "Freescale CAAM-Multicore driver backend" >> - depends on FSL_SOC >> + depends on FSL_SOC || ARCH_MXC > > Is this right? Are there other i.MX that have the CAAM IP core? > Sounds like it should be SOC_IMX6 instead. Even more, not all SOC_IMX6 variants have a CAAM block. Not sure what's better: -try to exactly indicate the HW that has the IP -only name the arch / SoC (provided compilation passes), and then depend on defconfig and/or device tree (and possibly boot loader dynamically fixing the DT) For e.g. Sahara crypto driver also depends on ARCH_MXC and it's not available on all i.MX SoCs. Thanks, Horia -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jul 24, 2015 at 08:14:31PM +0300, Horia Geant? wrote: > > Even more, not all SOC_IMX6 variants have a CAAM block. > > Not sure what's better: > -try to exactly indicate the HW that has the IP > -only name the arch / SoC (provided compilation passes), and then depend > on defconfig and/or device tree (and possibly boot loader dynamically > fixing the DT) > > For e.g. Sahara crypto driver also depends on ARCH_MXC and it's not > available on all i.MX SoCs. Kconfig entry dependencies do not have to guarantee the existence of the device. It only has to guarantee the ability to compile the code. Cheers,
diff --git a/drivers/crypto/caam/Kconfig b/drivers/crypto/caam/Kconfig index e7555ff..bc9aa07 100644 --- a/drivers/crypto/caam/Kconfig +++ b/drivers/crypto/caam/Kconfig @@ -1,6 +1,6 @@ config CRYPTO_DEV_FSL_CAAM tristate "Freescale CAAM-Multicore driver backend" - depends on FSL_SOC + depends on FSL_SOC || ARCH_MXC help Enables the driver module for Freescale's Cryptographic Accelerator and Assurance Module (CAAM), also known as the SEC version 4 (SEC4).