From patchwork Wed Jul 29 23:42:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Streetman X-Patchwork-Id: 6896721 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Original-To: patchwork-linux-crypto@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A633A9F38B for ; Wed, 29 Jul 2015 23:43:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B9ABC20481 for ; Wed, 29 Jul 2015 23:43:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DAEA20437 for ; Wed, 29 Jul 2015 23:43:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753800AbbG2XnH (ORCPT ); Wed, 29 Jul 2015 19:43:07 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:34752 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753819AbbG2XnG (ORCPT ); Wed, 29 Jul 2015 19:43:06 -0400 Received: by pacan13 with SMTP id an13so13313001pac.1; Wed, 29 Jul 2015 16:43:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=NpIc5029jj3tjyG1i08/Nxbs7pGDZLlLUe2c8nkgxHo=; b=0yIONBV+2VAkVDLNY/BbWSCrx69rZuVpslopUzGpm0MGsrYDQP5N3NlImvo5GKjeLh bkCQ2LWiKYfOE0qeD/9Ufg43+FsPnYZatRBSwNNVCPr1Xsy2chXosAUpqAOOwTZh+TWn dUfpEgI5U11oo6kRpEA0EnmKeWdFQ5Pby2PcUVtWxV04GO5sXijFUNhGLoANmJ9Hhd/4 c6EluXr0uOFtHZjvESyxUdo4OrdxJxum1Agv+dZxK6cqP8nA26quBrNvRxwBFuARUfrK 3+VY20J7ekxUpIEo8BaszesohozOUnt8G9PePgbfa7/6uieXgOAVsGqyPH158S2x6iwo 9Kqw== X-Received: by 10.66.157.167 with SMTP id wn7mr99352344pab.119.1438213385436; Wed, 29 Jul 2015 16:43:05 -0700 (PDT) Received: from toughbook.com (user-0c8ho8q.cable.mindspring.com. [24.136.225.26]) by smtp.gmail.com with ESMTPSA id of5sm42717144pdb.52.2015.07.29.16.43.02 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jul 2015 16:43:04 -0700 (PDT) From: Dan Streetman To: Herbert Xu Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Streetman Subject: [PATCH] crypto: nx - don't err if compressed output > input Date: Wed, 29 Jul 2015 19:42:09 -0400 Message-Id: <1438213329-6884-1-git-send-email-ddstreet@ieee.org> X-Mailer: git-send-email 2.1.0 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Return success instead of error if compression succeeds but the output is larger than the input. It's unlikely that the caller will use the compressed data since it's larger than the original uncompressed data, but there was no error and returning an error code is incorrect. Further, for testing small input buffers, the output is likely to be larger than the input and success needs to be returned to verify the test. Signed-off-by: Dan Streetman --- drivers/crypto/nx/nx-842-pseries.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/nx/nx-842-pseries.c b/drivers/crypto/nx/nx-842-pseries.c index b6a26907..f4cbde0 100644 --- a/drivers/crypto/nx/nx-842-pseries.c +++ b/drivers/crypto/nx/nx-842-pseries.c @@ -226,9 +226,12 @@ static int nx842_validate_result(struct device *dev, switch (csb->completion_code) { case 0: /* Completed without error */ break; - case 64: /* Target bytes > Source bytes during compression */ + case 64: /* Compression ok, but output larger than input */ + dev_dbg(dev, "%s: output size larger than input size\n", + __func__); + break; case 13: /* Output buffer too small */ - dev_dbg(dev, "%s: Compression output larger than input\n", + dev_dbg(dev, "%s: Out of space in output buffer\n", __func__); return -ENOSPC; case 66: /* Input data contains an illegal template field */