From patchwork Thu Sep 17 13:45:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 7207651 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Original-To: patchwork-linux-crypto@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 645BB9F380 for ; Thu, 17 Sep 2015 13:47:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8637720739 for ; Thu, 17 Sep 2015 13:47:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D6CA203E3 for ; Thu, 17 Sep 2015 13:47:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752284AbbIQNrc (ORCPT ); Thu, 17 Sep 2015 09:47:32 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:35321 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751827AbbIQNqJ (ORCPT ); Thu, 17 Sep 2015 09:46:09 -0400 Received: by wicge5 with SMTP id ge5so119615406wic.0 for ; Thu, 17 Sep 2015 06:46:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/OgDrwgVyTObfCjRos7Rs5R7rQtw/hpYEKwWU30Xqoc=; b=RY4xSIB0iU8QseXaZiWgZ9yjCnd3uQXtn61E26QLfcjFXW1VIg6AF6nkDg8W6GnSx9 +HvH16Cjvdc7JNfMIuxo1OFotqwvBtkE6xWCZLJrgSAYRjdwfcY2kGhkIPlZhFy3OQbb ks9Ve8GvEAtAAHSZoZ4PgLfYdUAUIiOntZ99VFPPX/Xg7Qxq2A/1rdHf8AAf8G4iK1Vg Tpny3kLCJIQyNj7qdFvj+MImvu2nn5mTtbreS5+N8xd7RRsXlnaGQ+yrD5tjU/md7Ide Qno/tfhe4i6P7p9wJOhYLcRPxnu31x7XKIBk7DoFuXcjp2vQzJyOPEjLEJZ3fcLTgU9F RAYA== X-Gm-Message-State: ALoCoQmZe83OLfH6uanww0nf0+1h/qCnXe3a4Hid/obO/BxsjoNyPvRQT3Gj6NvdbNVyTCsIReaB X-Received: by 10.180.182.107 with SMTP id ed11mr8009325wic.52.1442497568398; Thu, 17 Sep 2015 06:46:08 -0700 (PDT) Received: from x1.o2wifi.co.uk ([46.233.116.143]) by smtp.gmail.com with ESMTPSA id hk5sm3547895wjb.6.2015.09.17.06.46.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 Sep 2015 06:46:07 -0700 (PDT) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, peter@korsgaard.com, festevam@gmail.com, kieranbingham@gmail.com Cc: kernel@stlinux.com, Lee Jones Subject: [PATCH v2 3/7] hwrng: core: Simplify RNG switching from sysfs Date: Thu, 17 Sep 2015 14:45:53 +0100 Message-Id: <1442497557-9271-4-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1442497557-9271-1-git-send-email-lee.jones@linaro.org> References: <1442497557-9271-1-git-send-email-lee.jones@linaro.org> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If we attempt to use sysfs to change the current RNG in the usual way i.e. issuing something like: `echo 8a8a000.rng > /sys/devices/virtual/misc/hw_random/rng_current` ... it will fail because the code doesn't currently take the '\n' into consideration. Well, now it does. Signed-off-by: Lee Jones Acked-by: Peter Korsgaard --- drivers/char/hw_random/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c index da8faf7..2d4a969 100644 --- a/drivers/char/hw_random/core.c +++ b/drivers/char/hw_random/core.c @@ -323,7 +323,7 @@ static ssize_t hwrng_attr_current_store(struct device *dev, return -ERESTARTSYS; err = -ENODEV; list_for_each_entry(rng, &rng_list, list) { - if (strcmp(rng->name, buf) == 0) { + if (sysfs_streq(rng->name, buf)) { err = 0; if (rng != current_rng) err = set_current_rng(rng);