From patchwork Mon Jan 25 16:50:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 8112421 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Original-To: patchwork-linux-crypto@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A2503BEEE5 for ; Mon, 25 Jan 2016 16:52:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DCB6D202E6 for ; Mon, 25 Jan 2016 16:51:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF5452025A for ; Mon, 25 Jan 2016 16:51:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932488AbcAYQv5 (ORCPT ); Mon, 25 Jan 2016 11:51:57 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:64048 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752280AbcAYQv4 (ORCPT ); Mon, 25 Jan 2016 11:51:56 -0500 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue004) with ESMTPA (Nemesis) id 0LckOB-1ZeYAD042R-00kAmr; Mon, 25 Jan 2016 17:51:02 +0100 From: Arnd Bergmann To: Herbert Xu Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , linux-crypto@vger.kernel.org, "David S. Miller" , linux-kernel@vger.kernel.org Subject: [PATCH 1/2] crypto: jitterentropy - always select CRYPTO_RNG Date: Mon, 25 Jan 2016 17:50:34 +0100 Message-Id: <1453740644-1980309-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:79s9jT1ayHkQw3siMtBp6d19LE5CquNuaJUbwAPmKmQQjfCu74c or6f2eLEzmLyT7/c8mEgotvRD1u8QpUe/EvvAYJOFSFLSNHXaieOReUfL0orzNzKxMXlJrK YA6AUrRS7lljzSnORZq/tBIHdzFAw4MCFxg/fWLTibvjGApfAkfvcKWEb0pJliKxhbnzP5J HpPR9UOiB7MEJled0K8bA== X-UI-Out-Filterresults: notjunk:1; V01:K0:M2lIdNegNUU=:EqOPDK/xcnv0ZILJwOv4Uo 08iaaxET4ms1VEX7yPSDKplNnsk8URwvEgqFUfyWL+jg1P6tJvxOp43AjRPzK/p6bkdH855kl adnm709hovEZVdQSXaMdxGGFM58q/4r7UVyBz5GEc5utIxFeKqp64Ae9np4yKkKo0cSU8IZqQ 5s/3xWtHQaTqy4GGDLafgmVe99153itb5e18QDkTQK6+i1P2huyZyXnEd0M4xfQ2pqbPv495h 52N90KN8aiD44VUifIMwYX3woVGLViikbQxGDcCoXnK3V5UdFrYccfcrU7fszxjBw8XJWSP8Z 5cLGkaWAg8/tYkSSWbvCbjxAG/rnji5JaJlHPYYrgkpt25IZsc/7aaUvqugWO8gM93C+SqWbC gmWXcOG5+HRhWQWjiLLBtoHiRt6xw+RP37LBLn757MeDkGGQYrTNdyr/S3jfzVoBseTBKE0uR lqmEZkcDx0bv6KLpnL5Yc9f851l37xLyA1vSlvIFcqGgDwAbao5zXKIcnumyrwLjB3yQddlhB hOpD7WuWOe+WnxC/mhKEcBK22QOsiKuMeXTrp+oliZoyJqIBuLSEhu2nwjTwbvqDJCAa+fvLy hfc2HD5nRtbZHcpzQB6JEJ9shtNoJNjISnCKI6+4paF9tw73feeQjUkrXE5dSVQO3FARhEcIm FO5s/ozS3FKsP5Imnfn5GyqBOuhfIJgy3h0hIfGSSB9xiJjtW0Bhn0yes3wdJzm0exhk= Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When building the jitterentropy driver by itself, we get a link error when CRYPTO_RNG is not enabled as well: crypto/built-in.o: In function `jent_mod_init': jitterentropy-kcapi.c:(.init.text+0x98): undefined reference to `crypto_register_rng' crypto/built-in.o: In function `jent_mod_exit': jitterentropy-kcapi.c:(.exit.text+0x60): undefined reference to `crypto_unregister_rng' This moves the 'select CRYPTO_RNG' from CRYPTO_DRBG to CRYPTO_JITTERENTROPY to ensure the API is always there when it's used, not just when DRBG is also enabled. Signed-off-by: Arnd Bergmann --- crypto/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/Kconfig b/crypto/Kconfig index 7240821137fd..99109b93604a 100644 --- a/crypto/Kconfig +++ b/crypto/Kconfig @@ -1586,13 +1586,13 @@ config CRYPTO_DRBG_CTR config CRYPTO_DRBG tristate default CRYPTO_DRBG_MENU - select CRYPTO_RNG select CRYPTO_JITTERENTROPY endif # if CRYPTO_DRBG_MENU config CRYPTO_JITTERENTROPY tristate "Jitterentropy Non-Deterministic Random Number Generator" + select CRYPTO_RNG help The Jitterentropy RNG is a noise that is intended to provide seed to another RNG. The RNG does not