| Message ID | 1454073009-13665-1-git-send-email-jmarchan@redhat.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Herbert Xu |
| Headers | show |
On Fri, Jan 29, 2016 at 02:10:09PM +0100, Jerome Marchand wrote: > __test_aead() reads MAX_IVLEN bytes from template[i].iv, but the > actual length of the initialisation vector can be shorter. > The length of the IV is already calculated earlier in the > function. Let's just reuses that. > This fix an out-of-bound error detected by KASan. > > Signed-off-by: Jerome Marchand <jmarchan@redhat.com> This patch creates a new warning that iv_len may be uninitialised. Please fix this and resubmit. Thanks,
On 02/01/2016 03:26 PM, Herbert Xu wrote: > On Fri, Jan 29, 2016 at 02:10:09PM +0100, Jerome Marchand wrote: >> __test_aead() reads MAX_IVLEN bytes from template[i].iv, but the >> actual length of the initialisation vector can be shorter. >> The length of the IV is already calculated earlier in the >> function. Let's just reuses that. >> This fix an out-of-bound error detected by KASan. >> >> Signed-off-by: Jerome Marchand <jmarchan@redhat.com> > > This patch creates a new warning that iv_len may be uninitialised. I see. iv_len is set for each templates. I don't see why we would like to call crypto_aead_ivsize() more than once. Moving the initialization of iv_len out of the loop should solve the warning. > > Please fix this and resubmit. Will do. Jerome > > Thanks, >
diff --git a/crypto/testmgr.c b/crypto/testmgr.c index ae8c57fd..d3587d5 100644 --- a/crypto/testmgr.c +++ b/crypto/testmgr.c @@ -617,7 +617,7 @@ static int __test_aead(struct crypto_aead *tfm, int enc, j++; if (template[i].iv) - memcpy(iv, template[i].iv, MAX_IVLEN); + memcpy(iv, template[i].iv, iv_len); else memset(iv, 0, MAX_IVLEN);
__test_aead() reads MAX_IVLEN bytes from template[i].iv, but the actual length of the initialisation vector can be shorter. The length of the IV is already calculated earlier in the function. Let's just reuses that. This fix an out-of-bound error detected by KASan. Signed-off-by: Jerome Marchand <jmarchan@redhat.com> --- crypto/testmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)