| Message ID | 1454348370-3816-3-git-send-email-andre.przywara@arm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
On Mon, Feb 01, 2016 at 05:39:21PM +0000, Andre Przywara wrote: > The driver for the sunxi-ss crypto engine is not entirely 64-bit safe, > compilation on arm64 spits some warnings. > The proper fix was deemed to involved [1], so since 64-bit SoCs won't > have this IP block we just disable this driver for 64-bit. > > [1]: http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/399988.html > (and the reply) > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> I still use COMPILE_TEST to test compile these drivers. So while I don't have a problem with this patch per se, please continue to ensure that it doesn't generate warnings on 64-bit platforms. Cheers,
On Mon, Feb 01, 2016 at 05:39:21PM +0000, Andre Przywara wrote: > The driver for the sunxi-ss crypto engine is not entirely 64-bit safe, > compilation on arm64 spits some warnings. > The proper fix was deemed to involved [1], so since 64-bit SoCs won't > have this IP block we just disable this driver for 64-bit. > > [1]: http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/399988.html > (and the reply) > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> Acked-by: Corentin LABBE <clabbe.montjoie@gmail.com> > --- > drivers/crypto/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig > index 07d4942..737200f 100644 > --- a/drivers/crypto/Kconfig > +++ b/drivers/crypto/Kconfig > @@ -487,7 +487,7 @@ config CRYPTO_DEV_IMGTEC_HASH > > config CRYPTO_DEV_SUN4I_SS > tristate "Support for Allwinner Security System cryptographic accelerator" > - depends on ARCH_SUNXI > + depends on ARCH_SUNXI && !64BIT > select CRYPTO_MD5 > select CRYPTO_SHA1 > select CRYPTO_AES > -- > 2.6.4 > > -- -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Feb 01, 2016 at 05:39:21PM +0000, Andre Przywara wrote: > The driver for the sunxi-ss crypto engine is not entirely 64-bit safe, > compilation on arm64 spits some warnings. > The proper fix was deemed to involved [1], so since 64-bit SoCs won't > have this IP block we just disable this driver for 64-bit. > > [1]: http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/399988.html > (and the reply) > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> Applied.
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index 07d4942..737200f 100644 --- a/drivers/crypto/Kconfig +++ b/drivers/crypto/Kconfig @@ -487,7 +487,7 @@ config CRYPTO_DEV_IMGTEC_HASH config CRYPTO_DEV_SUN4I_SS tristate "Support for Allwinner Security System cryptographic accelerator" - depends on ARCH_SUNXI + depends on ARCH_SUNXI && !64BIT select CRYPTO_MD5 select CRYPTO_SHA1 select CRYPTO_AES
The driver for the sunxi-ss crypto engine is not entirely 64-bit safe, compilation on arm64 spits some warnings. The proper fix was deemed to involved [1], so since 64-bit SoCs won't have this IP block we just disable this driver for 64-bit. [1]: http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/399988.html (and the reply) Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- drivers/crypto/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)