From patchwork Sun Aug 28 08:49:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: PrasannaKumar Muralidharan X-Patchwork-Id: 9302609 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 78BEF6077C for ; Sun, 28 Aug 2016 08:50:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5A9FD288EE for ; Sun, 28 Aug 2016 08:50:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3B072288F1; Sun, 28 Aug 2016 08:50:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D093E288EE for ; Sun, 28 Aug 2016 08:50:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755225AbcH1It6 (ORCPT ); Sun, 28 Aug 2016 04:49:58 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:35110 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbcH1It5 (ORCPT ); Sun, 28 Aug 2016 04:49:57 -0400 Received: by mail-pa0-f66.google.com with SMTP id cf3so7136573pad.2 for ; Sun, 28 Aug 2016 01:49:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=/KsRtDkwm/hr8FCdi/paYf/UJ8auYi5Pq5DkxaavBJM=; b=HFEd8DBNS+SdNEd+xjU8mcXm8S0zSKHtebZnmnPLYOOGO+G6nJbKWkap6Ly81fg4jB Ce7Zghv9/9dx6f2Jw9poMiirxdShFuzg+Enc+k6HwraOK7QlmJN1wZnDwfEDPrLosEwE 2nltmnwYrEs6nJkYwLhC8jdN7mySW30yY+GxWEbd02h5l2YbajYoHEtxIMd1BWpo58Ap OjS1Imq5kfiDcnG1ZBVI4LcANixn7/cd6YU9hCUgL3kwTpVRCn9+oNHG1nSzrwroLAMy j6xFoILJWY8zIQofET50p7M5q5JEsneIXXr49nmJr+K7lMICEYdMFd+JtYraqF2HQZkP Mr0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=/KsRtDkwm/hr8FCdi/paYf/UJ8auYi5Pq5DkxaavBJM=; b=lTTny5QYGb95akzwzWfDOpyVsWxEfWWfkBLtQowBSVsKHSq+W5zMteI0H5YIx6hokA BjCr+RjL8IRmNi4QDJsazzAopf/kgGVFe3OcSeMo3cPt7ah8pwjN88sr91WsT/yZmMm9 CTr0uMjwm0vaiBbuSzdzXlYag1/HpXYtD2k2hi9FNSoXStYyhitEPYeFvTpIkQT213SE EeBz0FBWMOyhSsrM+mI3KntvczMwgi7NlaTJp2gWK6G7PoABJzkjjcHReEYhGfCoKaFh UYYzAxFmtoPhw/0SGbVzUxua+vx6zEvYE6bHOSKoZVSeBJySwtia2sSL/z1VU/OlnC6P ISMw== X-Gm-Message-State: AE9vXwPZX6A3w6Dox67Gkzc5qX3/oWW2joeRjF9EOe+pBPeEe7RUogHx+afy70fpK1O1Ug== X-Received: by 10.66.251.65 with SMTP id zi1mr21448546pac.93.1472374196607; Sun, 28 Aug 2016 01:49:56 -0700 (PDT) Received: from localhost.localdomain ([1.23.8.117]) by smtp.gmail.com with ESMTPSA id g10sm40631215pfc.57.2016.08.28.01.49.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 28 Aug 2016 01:49:56 -0700 (PDT) From: PrasannaKumar Muralidharan To: mpm@selenic.com, herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org Cc: PrasannaKumar Muralidharan Subject: [PATCH] Use devm_hwrng_register instead of hwrng_register Date: Sun, 28 Aug 2016 14:19:12 +0530 Message-Id: <1472374152-19319-1-git-send-email-prasannatsmkumar@gmail.com> X-Mailer: git-send-email 2.5.0 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP By using devm_hwrng_register instead of hwrng_register the .remove callback in platform_driver can be removed. This reduces a few lines in code. Signed-off-by: PrasannaKumar Muralidharan --- drivers/char/hw_random/tx4939-rng.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/char/hw_random/tx4939-rng.c b/drivers/char/hw_random/tx4939-rng.c index a7b6949..1093583 100644 --- a/drivers/char/hw_random/tx4939-rng.c +++ b/drivers/char/hw_random/tx4939-rng.c @@ -144,22 +144,13 @@ static int __init tx4939_rng_probe(struct platform_device *dev) } platform_set_drvdata(dev, rngdev); - return hwrng_register(&rngdev->rng); -} - -static int __exit tx4939_rng_remove(struct platform_device *dev) -{ - struct tx4939_rng *rngdev = platform_get_drvdata(dev); - - hwrng_unregister(&rngdev->rng); - return 0; + return devm_hwrng_register(&dev->dev, &rngdev->rng); } static struct platform_driver tx4939_rng_driver = { .driver = { .name = "tx4939-rng", }, - .remove = tx4939_rng_remove, }; module_platform_driver_probe(tx4939_rng_driver, tx4939_rng_probe);