From patchwork Thu Sep 15 03:27:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 9332797 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2BE95607FD for ; Thu, 15 Sep 2016 03:27:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1DEA3290B4 for ; Thu, 15 Sep 2016 03:27:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 12461290BF; Thu, 15 Sep 2016 03:27:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AE189290B4 for ; Thu, 15 Sep 2016 03:27:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756504AbcIOD1j (ORCPT ); Wed, 14 Sep 2016 23:27:39 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:34650 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759550AbcIOD1i (ORCPT ); Wed, 14 Sep 2016 23:27:38 -0400 Received: by mail-pa0-f68.google.com with SMTP id vz6so1542062pab.1 for ; Wed, 14 Sep 2016 20:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FFUWTG/uAxwkRmT1759DOATMUVHN6BXu+gjdHMZWpV8=; b=atFG8XmcZWZO58rA9d1+Lh1nwEB5KgMFtvszqEC+pF0AIXnyRdI03O6WLg+Vu/wFw6 luLmHza5PZ6iAA2u/Z5w34UlgaRMYAjDb6/UiSA7pnyZEwrz6vdXCAmfBNcZUitdG1E0 qK1AjIcADY5w/sOxrCsp9P6gkxHQer4iFCOhbp+xkCGevrfDWVMdPRTfKuL2X3rfXsc0 C+YIvlMwXuX7v9CmGkdCt6hd3qClqpo7gdsXzd7WuR/PdWdYJ5WOL2q78xW9glGpcUrU jBe0sR3SN+NXmDdsoqbqbjb8dVKDOC472kvHPPVNrUTkZIwr2YPtLJa48VGhxfcHZpZ1 1dgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FFUWTG/uAxwkRmT1759DOATMUVHN6BXu+gjdHMZWpV8=; b=QxGM8yHaTGOMawaiSPQoK7Z5As/tIME9P31KckHn7GcLo0kSfuoS4aAVikGa0ozvq9 0ThmgVnUa/zg64oVUNWKXaOsAG2lnHazdHIgB/IKfImpNHSOAUAjYS3VPmCAH+u6zj2a ZDqaRTGyvaVb/IzEQpTgnlEi30MyC6d5zQTY3KdgrkH8wO5FE5+m9iSJyk9I1C+megHE ShyGs4ZpbpgbTVOYk+IfTKPuHJEgWb7/6mKGlqB+h1ewhwddw7PLbsIe/ugoucOnogcY il8g7Li9Rlp0NeQTBx+nLH9qIsD5SdphszUv71xm5qUfo0Y45zum3h+Bz2x0EPWc9FMV y9dw== X-Gm-Message-State: AE9vXwPIaezbwy0xqG9+4cEANLpoR4X/BOH1Sry02TmYk10Rk7sf2EsedKYfj4e/rlpewg== X-Received: by 10.66.172.228 with SMTP id bf4mr10576445pac.137.1473910057720; Wed, 14 Sep 2016 20:27:37 -0700 (PDT) Received: from localhost.localdomain.localdomain (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id vy9sm941942pab.22.2016.09.14.20.27.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Sep 2016 20:27:37 -0700 (PDT) From: Wei Yongjun To: Herbert Xu , Baolin Wang Cc: Wei Yongjun , linux-crypto@vger.kernel.org Subject: [PATCH -next] crypto: omap-aes - fix error return code in omap_aes_probe() Date: Thu, 15 Sep 2016 03:27:32 +0000 Message-Id: <1473910052-31515-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun Fix to return error code -ENOMEM from the crypto_engine_alloc_init() error handling case instead of 0, as done elsewhere in this function. Fixes: 0529900a01cb ("crypto: omap-aes - Support crypto engine framework") Signed-off-by: Wei Yongjun --- drivers/crypto/omap-aes.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index 2033769..fe32dd9 100644 --- a/drivers/crypto/omap-aes.c +++ b/drivers/crypto/omap-aes.c @@ -1215,8 +1215,10 @@ static int omap_aes_probe(struct platform_device *pdev) /* Initialize crypto engine */ dd->engine = crypto_engine_alloc_init(dev, 1); - if (!dd->engine) + if (!dd->engine) { + err = -ENOMEM; goto err_engine; + } dd->engine->prepare_cipher_request = omap_aes_prepare_req; dd->engine->cipher_one_request = omap_aes_crypt_req;