| Message ID | 1474548357.12981.19.camel@inria.fr (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Herbert Xu |
| Headers | show |
Hi Levent, there is a typo in the subject line: erroR. Also it would be better to start the summary phrase of the subject line with a verb: crypto: atmel-aes: fix compiler error when VERBODE_DEBUG is defined Le 22/09/2016 à 14:45, levent demir a écrit : > Fix debug function call in atmel_aes_write > > Signed-off-by: Levent DEMIR <levent.demir@inria.fr> > --- > drivers/crypto/atmel-aes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c > index e3d40a8..2b0f926 100644 > --- a/drivers/crypto/atmel-aes.c > +++ b/drivers/crypto/atmel-aes.c > @@ -317,7 +317,7 @@ static inline void atmel_aes_write(struct > atmel_aes_dev *dd, > char tmp[16]; > > dev_vdbg(dd->dev, "write 0x%08x into %s\n", value, > - atmel_aes_reg_name(offset, tmp)); > + atmel_aes_reg_name(offset, tmp, sizeof(tmp))); It looks like a space has been removed. > } > #endif /* VERBOSE_DEBUG */ > > Best regards, Cyrille -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Sep 27, 2016 at 06:45:18PM +0200, Cyrille Pitchen wrote: > Hi Levent, > > there is a typo in the subject line: erroR. > Also it would be better to start the summary phrase of the subject line with a > verb: > > crypto: atmel-aes: fix compiler error when VERBODE_DEBUG is defined > > Le 22/09/2016 à 14:45, levent demir a écrit : > > Fix debug function call in atmel_aes_write > > > > Signed-off-by: Levent DEMIR <levent.demir@inria.fr> > > --- > > drivers/crypto/atmel-aes.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c > > index e3d40a8..2b0f926 100644 > > --- a/drivers/crypto/atmel-aes.c > > +++ b/drivers/crypto/atmel-aes.c > > @@ -317,7 +317,7 @@ static inline void atmel_aes_write(struct > > atmel_aes_dev *dd, > > char tmp[16]; > > > > dev_vdbg(dd->dev, "write 0x%08x into %s\n", value, > > - atmel_aes_reg_name(offset, tmp)); > > + atmel_aes_reg_name(offset, tmp, sizeof(tmp))); > It looks like a space has been removed. It's been completely mangled by the mailer and cannot be applied.
Hi all, Le 02/10/2016 à 16:38, Herbert Xu a écrit : > On Tue, Sep 27, 2016 at 06:45:18PM +0200, Cyrille Pitchen wrote: >> Hi Levent, >> >> there is a typo in the subject line: erroR. >> Also it would be better to start the summary phrase of the subject line with a >> verb: >> >> crypto: atmel-aes: fix compiler error when VERBODE_DEBUG is defined >> >> Le 22/09/2016 à 14:45, levent demir a écrit : >>> Fix debug function call in atmel_aes_write >>> >>> Signed-off-by: Levent DEMIR <levent.demir@inria.fr> >>> --- >>> drivers/crypto/atmel-aes.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c >>> index e3d40a8..2b0f926 100644 >>> --- a/drivers/crypto/atmel-aes.c >>> +++ b/drivers/crypto/atmel-aes.c >>> @@ -317,7 +317,7 @@ static inline void atmel_aes_write(struct >>> atmel_aes_dev *dd, >>> char tmp[16]; >>> >>> dev_vdbg(dd->dev, "write 0x%08x into %s\n", value, >>> - atmel_aes_reg_name(offset, tmp)); >>> + atmel_aes_reg_name(offset, tmp, sizeof(tmp))); >> It looks like a space has been removed. > > It's been completely mangled by the mailer and cannot be applied. > I've sent a new version in this thread: https://lkml.org/lkml/2016/9/29/463 I added a Reported-by tag for Levent but if you want to use a Signed-off-by tag instead, it's fine with me! Best regards, Cyrille -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c index e3d40a8..2b0f926 100644 --- a/drivers/crypto/atmel-aes.c +++ b/drivers/crypto/atmel-aes.c @@ -317,7 +317,7 @@ static inline void atmel_aes_write(struct atmel_aes_dev *dd, char tmp[16]; dev_vdbg(dd->dev, "write 0x%08x into %s\n", value, - atmel_aes_reg_name(offset, tmp)); + atmel_aes_reg_name(offset, tmp, sizeof(tmp))); } #endif /* VERBOSE_DEBUG */
Fix debug function call in atmel_aes_write Signed-off-by: Levent DEMIR <levent.demir@inria.fr> --- drivers/crypto/atmel-aes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)