From patchwork Mon Nov 7 17:51:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sven Ebenfeld X-Patchwork-Id: 9415625 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C325C6048F for ; Mon, 7 Nov 2016 17:52:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BF6B42621D for ; Mon, 7 Nov 2016 17:52:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B31722845A; Mon, 7 Nov 2016 17:52:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 658612621D for ; Mon, 7 Nov 2016 17:52:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932464AbcKGRwE (ORCPT ); Mon, 7 Nov 2016 12:52:04 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34781 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932347AbcKGRwD (ORCPT ); Mon, 7 Nov 2016 12:52:03 -0500 Received: by mail-wm0-f66.google.com with SMTP id p190so17768931wmp.1; Mon, 07 Nov 2016 09:52:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=99/BAWgNQlX1buWZHy0/SG3BD6JNNMyMG3cMk5B7Qjg=; b=V4VKNcuso3diARC/kxAcqhcwYhhQU01HFxNWG2l69qxQPzqPfuM2NpTd94wT42/Ji3 XDCUiewOzIPn+mEZil6/IdDZj3Kf+elSAp6lir0UZeRNnnGCkwuz7KLe6Y2RhDei8vI1 A8n0dfZ50QEvcQEm/z/+jLokizJSA9W6L9IbyUvOJortFRuFZTxZ0Aict2ak9vzZQpsn q3vwwd0HWeNOrFqbDvPZ8eG9iq4aKNVRAgBTVQ4rm2g+DcSvwUUkfExjvQkbF+e+L4hY /hV9WwMWLxdKxdIZhPgLaAeNvx/Z/ZKK6LV+yvZK/6sRFezJB96LUcN3kCGNxgGNR09G Itog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=99/BAWgNQlX1buWZHy0/SG3BD6JNNMyMG3cMk5B7Qjg=; b=mBnBGLY9hNsudkcjLSaUi7VyahHyKpSN8B0RL7YFd0xETMn85wdMIF7WPvCsl2tNMU UMocGp/+aDu562E4+GfWfuiUpP4ePcPgezzODpIRykLFVYxrPfngczVLFbp6jEFYx+41 aVS0UaAX/t4YJlSUOr9EbL/k+7hbccKM3pCHdQabgxObASsP/Hgyt9VXHuMisA0Wrm7r ZwjCvxUl0ea8xxboih03CyrNogGBLUvOYPFHdQHK4x3eEoMFtsnaa/m08JJBx+lIfXpL qPTuaXtyMajwOWsYdI70EW4WTEwg/dxoFd6Jp7j0zyCwhquykZEYIPKPztXUMoV5WP8W bM9w== X-Gm-Message-State: ABUngveBV1QNZU+Ujti1NeaS8WwXymobyYrAf9JRaHleLCPDSXLlHRfHlFikhH9KmG/XFA== X-Received: by 10.28.92.21 with SMTP id q21mr7687708wmb.71.1478541121589; Mon, 07 Nov 2016 09:52:01 -0800 (PST) Received: from ubuntu.fritz.box ([2001:470:1f0b:1030:7994:4633:ca92:408d]) by smtp.gmail.com with ESMTPSA id p13sm14818429wmd.20.2016.11.07.09.52.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 07 Nov 2016 09:52:01 -0800 (PST) From: Sven Ebenfeld To: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, horia.geanta@nxp.com Cc: herbert@gondor.apana.org.au, davem@davemloft.net, cata.vasile@nxp.com, Sven Ebenfeld Subject: [PATCH v2] crypto: caam: do not register AES-XTS mode on LP units Date: Mon, 7 Nov 2016 18:51:34 +0100 Message-Id: <1478541094-73173-1-git-send-email-sven.ebenfeld@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When using AES-XTS on a Wandboard, we receive a Mode error: caam_jr 2102000.jr1: 20001311: CCB: desc idx 19: AES: Mode error. According to the Security Reference Manual, the Low Power AES units of the i.MX6 do not support the XTS mode. Therefore we must not register XTS implementations in the Crypto API. Signed-off-by: Sven Ebenfeld Reviewed-by: Horia Geantă Cc: # 4.4+ Fixes: c6415a6016bf "crypto: caam - add support for acipher xts(aes)" --- drivers/crypto/caam/caamalg.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto/caam/caamalg.c index 156aad1..f5a63ba 100644 --- a/drivers/crypto/caam/caamalg.c +++ b/drivers/crypto/caam/caamalg.c @@ -4583,6 +4583,15 @@ static int __init caam_algapi_init(void) if (!aes_inst && (alg_sel == OP_ALG_ALGSEL_AES)) continue; + /* + * Check support for AES modes not available + * on LP devices. + */ + if ((cha_vid & CHA_ID_LS_AES_MASK) == CHA_ID_LS_AES_LP) + if ((alg->class1_alg_type & OP_ALG_AAI_MASK) == + OP_ALG_AAI_XTS) + continue; + t_alg = caam_alg_alloc(alg); if (IS_ERR(t_alg)) { err = PTR_ERR(t_alg);