From patchwork Wed Nov 9 08:46:19 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Horia Geanta X-Patchwork-Id: 9418685 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A9381601C0 for ; Wed, 9 Nov 2016 10:19:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9C2BC29239 for ; Wed, 9 Nov 2016 10:19:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 907502923B; Wed, 9 Nov 2016 10:19:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 733AA29239 for ; Wed, 9 Nov 2016 10:19:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752763AbcKIKTq (ORCPT ); Wed, 9 Nov 2016 05:19:46 -0500 Received: from mail-by2nam03on0063.outbound.protection.outlook.com ([104.47.42.63]:7488 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752300AbcKIKTo (ORCPT ); Wed, 9 Nov 2016 05:19:44 -0500 Received: from BN3PR0301CA0042.namprd03.prod.outlook.com (10.160.180.180) by DM5PR03MB2889.namprd03.prod.outlook.com (10.175.106.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.707.6; Wed, 9 Nov 2016 08:47:53 +0000 Received: from BL2FFO11FD014.protection.gbl (2a01:111:f400:7c09::100) by BN3PR0301CA0042.outlook.office365.com (2a01:111:e400:4000::52) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.707.6 via Frontend Transport; Wed, 9 Nov 2016 08:47:52 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BL2FFO11FD014.mail.protection.outlook.com (10.173.160.222) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.707.3 via Frontend Transport; Wed, 9 Nov 2016 08:47:52 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:; UpperCasedChecksum:; SizeAsReceived:834; Count:13 Received: from enigma.ea.freescale.net (enigma.ea.freescale.net [10.171.77.120]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id uA98lTXU026193; Wed, 9 Nov 2016 01:47:50 -0700 From: =?UTF-8?q?Horia=20Geant=C4=83?= To: Herbert Xu CC: "David S. Miller" , Subject: [PATCH 09/14] crypto: caam - remove unreachable code in report_ccb_status() Date: Wed, 9 Nov 2016 10:46:19 +0200 Message-ID: <1478681184-9442-10-git-send-email-horia.geanta@nxp.com> X-Mailer: git-send-email 2.4.4 In-Reply-To: <1478681184-9442-1-git-send-email-horia.geanta@nxp.com> References: <1478681184-9442-1-git-send-email-horia.geanta@nxp.com> MIME-Version: 1.0 X-IncomingHeaderCount: 13 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131231548726833867; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(87936001)(356003)(23676002)(97736004)(50986999)(7846002)(47776003)(81156014)(2950100002)(6916009)(110136003)(4326007)(36756003)(81166006)(105606002)(8676002)(8936002)(77096005)(5660300001)(626004)(2906002)(86362001)(50226002)(189998001)(50466002)(575784001)(33646002)(104016004)(229853001)(69596002)(106466001)(305945005)(2870700001)(85426001)(586003)(68736007)(5820100001)(92566002)(6666003)(76176999); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR03MB2889; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD014; 1:0OyqAHpeXQZxUXR32efn2+A48tI1M7Z8vdci5hEDAYogMPNum8WvbDh1D3wLfIj9HFLwPb9DgbSqCGqriuxXfKVA56h91j6yoKx0ZeTAySjN4S7YnLRwpgLNAFvPO6c7/DVICuwMVeIGXG0LUXJivp6A7OGtFEwQOWYERNvKhJ1+hTJcwNq6GgoOe/rLUs+ji2qzvo29RtJ8nh9XXGTkOmbKDAS9njp3D/3cbd0AZ4EXVBCZcC9xsuX4doIsTDETs6FKYX5/7JencF1daI/Q5Cu1WlRYMq43HB+O9aFIxey9qMGtPJZAmfi8pHOg7CEh+ql6lA7eDTG0oXCiyprhESmIhnOmpIQnFYIQdU5XxHmEO5e9X6O9mBDf4PcSJZV2h7skZw1NQSepro6Bl1qY0REVHK9xeYtHuawJ8b8NHy96X7e+6V/DgdJcloy1qJYJ3nfNcTiFYzXewD6YMA5+VGpAesbml6nPyLAraRD6j/741sqQxDBAT8AuHvonDYOr32I5wb06EKDkqLld0p80HX9jZFUvMVBrQ4OeK1Z0ArTRetF2G7jZwjg8QnkXRMteramvgGYO9XGT1aYjaSmAvHkyu8mYe/TCzBB53r+fHCGAFmLGkutoVLEc6ODDU2/U X-MS-Office365-Filtering-Correlation-Id: c427b5d4-2586-4aed-f2cb-08d4087d17a6 X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2889; 2:lwbz9h80f74dOQs0fKq5f+g8wEQX2hPd8rzZxYNVlEN6tk6W1UQrnC4YUz52gCuphWKc7YSt5kgXVLxNi1SVVBzt7LHbJVldBeHMUa4fxJMqsYmtDDk99knWvmLrcCmcpG7/NL4otOmOiCfRjjNwKJZp4d57a2IzgzSq2Ba2kbft/8HqkvuJ6rvDR5r5K5LrxTALEm0e8pSXOMBFP/kNog==; 3:RlOJdm/gAw0948e6nILrHQIr5ik3inlltjDJLtdt2LCF1S8+xaqvbXydC+ZTvYOr9UqvMa7yQYiXhzToUCjY0FDk4TllpqBkZQJQWm0TeIb9kgWMRAwbZNwy2qgprnnVjSFJ8ymxPC/SWFwwakkxNf95rtdKZRQSeQbaO4WkQhlFuIixPQmUkx3lxQH9RWvUqnj2IGraI2KRi/h3JSPoMY4mP6nS1mbmK4fe1bpg88/4EZIJ+Ry6g3LRjkhNs6O+ X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR03MB2889; X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2889; 25:yg0onlMZ4Cfj8/XRSJ4l+Hj1s0EO9GEh1VJUCtS6DOwlGg4t4Dq5bOFz5R8WyBLZM3CBNwvTpOh8+DnDKsIQn3Y+ODrcn4xIroCk+fx4HoaiWyik3V3F5ahIRKLD6VuHSfPl6kIFwE381e7mXG6q8PUaMSSDUhYSRzaBimrc6nvkhH0jNQ/qygbdfjDqR9Ja29k+ut92Ymgsxsqr3IhqAGjO3glVpu8oj5gwW2q2NCnHkltaUNihkk2F+HtVXKJAvdajO0hh66GjL6XpXl1ipSbwCyCikB9+NIiEXj5r0UrS4FVo9HMeSflrqB/yKVCvpZibEJrHfdfLOq7cgQfQ9/iEaCXa+GORLNhj91mOLA+PxrB8LwiRV6fYoSFVWwk0fztA0DIUdZDjzgjkJa7JpJm+UNkPJ84iL1QUEG2n/UnZ6aU3ZCRPMbDDjIbziQ5uSMnNUX2mXl5r2ymPESyJ6VstqrcwuLooj8+K+Pg/0De4yHqwDeQfNXUnfyvjm4oMCfdJCiESxsqMIriqgC4BhmLg4lJiRvIKahQGob/EiIN5zFzDKuxDSSzqgk4ro+37NvjVYVNnvwpYb4HC/2rjM9ZVKIc7Md11W+dfZP9AFYv+zeLibE1709iwUikp6ApotMAJONeFQwR59vrxS5cL32p8hGzSrLfOxtCDRDz1TdAKg2qpmXhLOLOFZs3P09RmQS0EVYCCEQ4l3vsttCnM4Hk1A760DWqBy1Tg6jBVtwuG+Bg/L+3KnLiewk9QrCO+ X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2889; 31:eck4A8CxmXq2QY3EpNrU3ozncDywS1jm7aP53xKxkWJ+vXr99aiPtXvlZLoHY/jGMLVyogw9nXY2mxkU7umZm0fDXY5ZSE2XaW7a9s6nrKJfFC8j2fAXlrFZUb/OPsb+DYPyT+tqMgSfQXpZWEBpRJXwfcYPMVppJv6bnaki0JVuGxsTaWU8tI2dbOt3/H451Xa1D6Yu2Ql6XxJAEkHEoMl/k0rDYkvClPO9kJvKXv3B7fnyTKWxTtsQ4pZtuYHc4HU/+ETMaIFGbFtHNv2Sx8t6fiYrGouMRX1gm3Onyfg=; 4:044gb9ec84jVblI4u36TVzFv1dgURpTnIMebrQ2SfGrHr6lhQQh3/a9CMHVKk5Me0JAyQ/Xt7zmWhQj5UQRst8KUrQs1deU6GL1+l1SGxkV2kAph5VY9rdm+wLWlc2mPfurUzvON1lQ9POK3Cle1kGByUExFXX8v4jyOLyXCuoHxrbo2esLFf38X91dQ0TGIJUi8pDVvbVmOkW5nQib0dVh6oeDc8WNKCzzA/PEIPWJqOII5HKcjVYoV7325fB9Td426mEJ9qrIS6xOgK/0FFSSjyl6PTkiOc+M14Z8af2pecJ41RulV0KCNDnW59v7jhIVYQjO8yGNxqgDQ6KbfQURd5+OgCyxbwde1yfDugJAs581SidCV4r5bS814j6dOS6O8KdE007CLdoAyA6MmdNZ0VawJqw/gi4vEeakSltX3kw/zHDZWy/SqZ+X6GalqZEsVyy8PUgmwY5wYYkxzOVt4Z455IAb8l2D+hxDz7FC2iHvrZCZjHQNB7ODrnDx4zjzdMgQ5n3sxGceplTBEDHsx6/VmOBiI/FN+83FjZbLYJUc/iVk+V86rMvZb/MSd X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13024025)(13017025)(8121501046)(13018025)(13015025)(13023025)(5005006)(3002001)(10201501046)(6055026); SRVR:DM5PR03MB2889; BCL:0; PCL:0; RULEID:(400006); SRVR:DM5PR03MB2889; X-Forefront-PRVS: 0121F24F22 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjAzTUIyODg5OzIzOm84S2pnczBub2RKWXJBSzVoSERqNXBlTk9u?= =?utf-8?B?OVhQSTdldFlvdFovSGJFYW9MYWpCYzVYTzVyWjZxWVN1YTVsSUY0WXN4UFdr?= =?utf-8?B?QmJQYzZhTFMyQzh4WFZuZnlReUdCNE1QNWFnRkRxeXVIeUlrNnY3TTQrelRL?= =?utf-8?B?czhKUUdIYWltTWh2YkpzUTVKeVJTYXlVSk9ZRHd3ZzdtUDJmaUtLeFVQUVRR?= =?utf-8?B?eG4zMkRXNVFMNEY3WUZha3pnSW9iQnlMNG5TSWxleHVVVkhUMjN3SFVuWWRZ?= =?utf-8?B?S3FEWklpNVNVSUxBY1I1WWZZS3B2dmRLUFFzMmhTbzRoWmpDMU4xVFdsaXRh?= =?utf-8?B?aHJ6WEpaLzU2NWtheWNjTjMvbnJtKzJxQWFqZGdlOVZTTnNCRURodEF3R1Rp?= =?utf-8?B?cHQ4S0FkQnJvNGt2L0FRRDEyQms3Y3hWcWlReHdWMUppeEpudzJsOG04VjJr?= =?utf-8?B?TzBMZldaOUNCSFBsM2JSWTI2eFU0YXN1UnZEeEJoTVhtKzJRcnppMzVYTzRO?= =?utf-8?B?d29KTkRiajlGRW9qbGx6THpoL3VCQlZsdWpkQ2QwVXJsSDZOcGRDTCtFUVNn?= =?utf-8?B?Zm5ZSGIwbnNUMFR6TmwvaHhZVDdKTHRjVm1sNWlOZnFuLzdWZnAvSFMxZ1I2?= =?utf-8?B?YURBMWdDcDRTY0RrcDdHbUt5VFRRREhQSkdXZzk3MVYrbTg3QnIvVWZ0OFg3?= =?utf-8?B?eEtLSzhNK1dJc25hUVgvWUVoY0NsVXpSNWhua0dEVktPLzRjNVpCVlJETnB2?= =?utf-8?B?YVo0S0pGZXoxL2p1NTRRWGdzTWk5M3Z0ZmxxdzdRMklXdmhCb1N5bnFyQmRX?= =?utf-8?B?U3M5OFpZK3p1UDd3Q0lDeG5Sd3Z0QmJvNmt6bFl3K1J5aWd3OEJsc25KQ2s2?= =?utf-8?B?eUV3SGpqUm1xZitqSWhEOWdaMHNYRkV0M3Y4YkpVM2F4TXIrdHBYd3lPTFZQ?= =?utf-8?B?OHNHbEFrNDd3KzFlYTJVNm1lc2Erdzd0Y1N3MEVmZ0plbTJnNGRXOVNDY1RY?= =?utf-8?B?VVVsUDFTcE9rWGZ1SytIQlVvTld4S0pxd08yNDBqbzQ5Tm01Qm1HcVpzR3dS?= =?utf-8?B?SVIxSE1Qb0Uzd3F2dUQ1a2QxT3dYTE95RTF1UzFTcytkaGxEc1NMeWJGUnVM?= =?utf-8?B?eWRPb09MQTRiVTRuY3Q2ak5vYS9QRVF1MEh5QjNrS0hNZlF2M2laWDBCeElJ?= =?utf-8?B?ZXBwSFZyRitQZlNBT0VJdmY1NkNBKy8zdE9rUEtGdDdYa2tDSGJmYTZkYk4y?= =?utf-8?B?Qm5ROHhOQkJxb2FGWXRqSy9QWjA1MHprdTJTQTd4RmIybjRGZXZwdzEvaVhq?= =?utf-8?B?TTRTUWI0UXRGdlJkVnkrVHBLSWlOT3hPZ29Uc2M3ZmFsS09UQU1vSVFCS2xo?= =?utf-8?B?dUJtWTBNUTYyTWZlRGJZOVZKUC9VN2QvaW1GeXZKdmpPcU1iYm9ZU2lWbHk1?= =?utf-8?B?RVFVblBSUkFUMmgreXE4MkpROEZIV0thWmdTb0tLT1d6a3JvRXZ4Y3dLdEJV?= =?utf-8?Q?9OHubVxsMP2GMiW68m9DVGxAVWK/Udb+8CfRS54Gp3Qo62?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2889; 6:YsMla27rW0yE431rs6r6gx4laqOlTtWm2DDKf05wL3MnWAOAx26H6/7dIXk+64x0sOWGFdn+WHypLUjjWxm3W8KzVDBvEgpLHJz/od6mPuF4OwsOXevMFHMAP78YfhlVEwkHr3NYoBVdmPH8d//5A9Qsh4MKqPeOvP0xzzZ/Cmr6j8S10uMIyO90Sxml3vB5ds4hj2fyEMH5GybkQjww9GYhqxtX0VISb6ZlqLT5Ga7SKdPqvrNmfamX7kwBGSqtET7y1SYsPlrHXUwqh6RrvFRTrxuTyZm6rfMPhiFgLJl54WCLNqFkSziX2Q2GnUxS; 5:Ba2FT9uiG11OyjIwL+sS3IvjYxiAXz5GT/dSRubhYFpjndGCIqMcnz5ebGfKmxlOnHf4q3BXyYUd4I+T6MiM6JkS4GmzbBTXm/xGzWJOIFjfcSV+R83F10XBHTrUlcHAssk8S2//qkFIWGPtu6wkddoeAZ3MZL/iCTBIkisV+QNr0s25hWHL7VULpHGlzxTr; 24:lXat+kYjMWJBRCOqqTiujcLR8qgXuXQl1OpRCTVm593qPvzfyqZoy6Hb8WH/cE50uiEwGPbBkPAacBQjeG0fAPpiJiB0ner/lHh26ieQ6sA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2889; 7:x2lted747/bLjJGMHoqCdG74YPs6I2ahzcD5hF4+nVvJhsoVK1XUlL+0iWeuHrI958bfPDWePRKIbV1nChQFzuIbCB7XMYh6SdkIIlFv/twsCXGeOEsvmz60htJk19Xd8z9xay5OWBixlv5RGNgecXjK0tsDxREh7Isph2S7DDkIdffvYhUOJbflcqsxt9flv/tqp6bm3CX4cKodMV610Qo6f9M2hMmQpRQrtdl1qbUPuhHX+HhVsMpb/iGmVzDOc9AlVzhZB/nt2JbggVgWl878OP++VxN8BrWf+87P/qy2gfjsqbMnuH2l9QC9dRnRyZPDJx+301FeR1I0W2Ps7S7KXbzBZ430NpAXRU3ev3w= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2016 08:47:52.4493 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2889 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP ERRID is a 4-bit field. Since err_id values are in [0..15] and err_id_list array size is 16, the condition "err_id < ARRAY_SIZE(err_id_list)" is always true. Signed-off-by: Horia Geantă --- drivers/crypto/caam/error.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/caam/error.c b/drivers/crypto/caam/error.c index 33e41ea83fcc..79a0cc70717f 100644 --- a/drivers/crypto/caam/error.c +++ b/drivers/crypto/caam/error.c @@ -146,10 +146,9 @@ static void report_ccb_status(struct device *jrdev, const u32 status, strlen(rng_err_id_list[err_id])) { /* RNG-only error */ err_str = rng_err_id_list[err_id]; - } else if (err_id < ARRAY_SIZE(err_id_list)) + } else { err_str = err_id_list[err_id]; - else - snprintf(err_err_code, sizeof(err_err_code), "%02x", err_id); + } /* * CCB ICV check failures are part of normal operation life;