diff mbox

[1/2] crypto: asymmetric_keys: set error code on failure

Message ID 148162117870.19689.15511298103589902019.stgit@warthog.procyon.org.uk (mailing list archive)
State Accepted
Delegated to: Herbert Xu
Headers show

Commit Message

David Howells Dec. 13, 2016, 9:26 a.m. UTC 
From: Pan Bian <bianpan2016@163.com>

In function public_key_verify_signature(), returns variable ret on
error paths. When the call to kmalloc() fails, the value of ret is 0,
and it is not set to an errno before returning. This patch fixes the
bug.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188891

Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: David Howells <dhowells@redhat.com>
---

 crypto/asymmetric_keys/public_key.c |    1 +
 1 file changed, 1 insertion(+)


--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Herbert Xu Dec. 14, 2016, 10:38 a.m. UTC | #1 
On Tue, Dec 13, 2016 at 09:26:18AM +0000, David Howells wrote:
> From: Pan Bian <bianpan2016@163.com>
> 
> In function public_key_verify_signature(), returns variable ret on
> error paths. When the call to kmalloc() fails, the value of ret is 0,
> and it is not set to an errno before returning. This patch fixes the
> bug.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188891
> 
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> Signed-off-by: David Howells <dhowells@redhat.com>

Both patches applied.  Thanks.
diff mbox

Patch

diff --git a/crypto/asymmetric_keys/public_key.c b/crypto/asymmetric_keys/public_key.c
index fd76b5fc3b3a..d3a989e718f5 100644
--- a/crypto/asymmetric_keys/public_key.c
+++ b/crypto/asymmetric_keys/public_key.c
@@ -121,6 +121,7 @@  int public_key_verify_signature(const struct public_key *pkey,
 	if (ret)
 		goto error_free_req;
 
+	ret = -ENOMEM;
 	outlen = crypto_akcipher_maxsize(tfm);
 	output = kmalloc(outlen, GFP_KERNEL);
 	if (!output)