From patchwork Wed May 10 13:04:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 9719805 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2A74A60236 for ; Wed, 10 May 2017 13:04:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1EF6028498 for ; Wed, 10 May 2017 13:04:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 138E32857F; Wed, 10 May 2017 13:04:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B68B528498 for ; Wed, 10 May 2017 13:04:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752632AbdEJNEm (ORCPT ); Wed, 10 May 2017 09:04:42 -0400 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:27550 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432AbdEJNEl (ORCPT ); Wed, 10 May 2017 09:04:41 -0400 X-IronPort-AV: E=Sophos;i="5.38,319,1491289200"; d="scan'208";a="303013" Received: from exsmtp02.microchip.com (HELO email.microchip.com) ([198.175.253.38]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA; 10 May 2017 06:04:42 -0700 Received: from rob-ult-M18064.microchip.com (10.10.76.4) by chn-sv-exch02.mchp-main.com (10.10.76.38) with Microsoft SMTP Server id 14.3.181.6; Wed, 10 May 2017 06:04:40 -0700 From: Tudor Ambarus To: CC: , Tudor Ambarus Subject: [PATCH 2/2] crypto: ecdh - fix ecdh_max_size Date: Wed, 10 May 2017 16:04:29 +0300 Message-ID: <1494421469-17125-2-git-send-email-tudor.ambarus@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1494421469-17125-1-git-send-email-tudor.ambarus@microchip.com> References: <1494421469-17125-1-git-send-email-tudor.ambarus@microchip.com> MIME-Version: 1.0 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The function should return minimum size for output buffer or error code if key hasn't been set. Signed-off-by: Tudor Ambarus --- crypto/ecdh.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crypto/ecdh.c b/crypto/ecdh.c index 63ca337..01bfd13 100644 --- a/crypto/ecdh.c +++ b/crypto/ecdh.c @@ -109,10 +109,10 @@ static int ecdh_compute_value(struct kpp_request *req) static int ecdh_max_size(struct crypto_kpp *tfm) { struct ecdh_ctx *ctx = ecdh_get_ctx(tfm); - int nbytes = ctx->ndigits << ECC_DIGITS_TO_BYTES_SHIFT; - /* Public key is made of two coordinates */ - return 2 * nbytes; + /* Public key is made of two coordinates, add one to the left shift */ + return ctx->ndigits ? ctx->ndigits << (ECC_DIGITS_TO_BYTES_SHIFT + 1) : + -EINVAL; } static void no_exit_tfm(struct crypto_kpp *tfm)