Message ID | 1495033238-26016-5-git-send-email-tudor.ambarus@microchip.com (mailing list archive) |
---|---|
State | Changes Requested |
Delegated to: | Herbert Xu |
Headers | show |
On Wed, May 17, 2017 at 06:00:31PM +0300, Tudor Ambarus wrote: > The function should return minimum size for output buffer > or error code if key hasn't been set. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> > --- > crypto/dh.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/crypto/dh.c b/crypto/dh.c > index 7cec0498..325a5dd 100644 > --- a/crypto/dh.c > +++ b/crypto/dh.c > @@ -148,7 +148,7 @@ static int dh_max_size(struct crypto_kpp *tfm) > { > struct dh_ctx *ctx = dh_get_ctx(tfm); > > - return mpi_get_size(ctx->p); > + return ctx->p ? mpi_get_size(ctx->p) : -EINVAL; How about ENOKEY? Cheers,
diff --git a/crypto/dh.c b/crypto/dh.c index 7cec0498..325a5dd 100644 --- a/crypto/dh.c +++ b/crypto/dh.c @@ -148,7 +148,7 @@ static int dh_max_size(struct crypto_kpp *tfm) { struct dh_ctx *ctx = dh_get_ctx(tfm); - return mpi_get_size(ctx->p); + return ctx->p ? mpi_get_size(ctx->p) : -EINVAL; } static void dh_exit_tfm(struct crypto_kpp *tfm)
The function should return minimum size for output buffer or error code if key hasn't been set. Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> --- crypto/dh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)