| Message ID | 1501424133-27810-1-git-send-email-rishabheudyptula@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Herbert Xu |
| Headers | show |
Hi Rishabh, Thanks you for spotting this. On Sun, Jul 30, 2017 at 5:15 PM, rishabh hardas <rishabheudyptula@gmail.com> wrote: > Sparse was giving out a warning 'warning: symbol 'cc_set_ree_fips_status' was not declared. Should it be static?' > which has been removed by making it static. > > Signed-off-by: rishabh hardas <rishabheudyptula@gmail.com> > --- > drivers/staging/ccree/ssi_fips.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/ccree/ssi_fips.h b/drivers/staging/ccree/ssi_fips.h > index 369ddf9..846bd55 100644 > --- a/drivers/staging/ccree/ssi_fips.h > +++ b/drivers/staging/ccree/ssi_fips.h > @@ -40,7 +40,7 @@ static inline int ssi_fips_init(struct ssi_drvdata *p_drvdata) > } > > static inline void ssi_fips_fini(struct ssi_drvdata *drvdata) {} > -void cc_set_ree_fips_status(struct ssi_drvdata *drvdata, bool ok) {} > +static void cc_set_ree_fips_status(struct ssi_drvdata *drvdata, bool ok) {} > void fips_handler(struct ssi_drvdata *drvdata) {} > > #endif /* CONFIG_CRYPTO_FIPS */ > -- > 2.7.4 > A better modifier here would be "static inline". While you're at it you can also apply it to the fips_handler() function below. Also, please use a descriptive title, maybe: "declare compiled out func static inline" Last, please CC ALL the appropriate mailing lists. Use the kernel get_maintainer script to find out which if you are unsure. Thanks again, Gilad
diff --git a/drivers/staging/ccree/ssi_fips.h b/drivers/staging/ccree/ssi_fips.h index 369ddf9..846bd55 100644 --- a/drivers/staging/ccree/ssi_fips.h +++ b/drivers/staging/ccree/ssi_fips.h @@ -40,7 +40,7 @@ static inline int ssi_fips_init(struct ssi_drvdata *p_drvdata) } static inline void ssi_fips_fini(struct ssi_drvdata *drvdata) {} -void cc_set_ree_fips_status(struct ssi_drvdata *drvdata, bool ok) {} +static void cc_set_ree_fips_status(struct ssi_drvdata *drvdata, bool ok) {} void fips_handler(struct ssi_drvdata *drvdata) {} #endif /* CONFIG_CRYPTO_FIPS */
Sparse was giving out a warning 'warning: symbol 'cc_set_ree_fips_status' was not declared. Should it be static?' which has been removed by making it static. Signed-off-by: rishabh hardas <rishabheudyptula@gmail.com> --- drivers/staging/ccree/ssi_fips.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4