diff mbox

staging/ccree: Declare compiled out fuctions static inline

Message ID 1501492643-7087-1-git-send-email-rishabheudyptula@gmail.com (mailing list archive)
State Not Applicable
Delegated to: Herbert Xu
Headers show

Commit Message

rishabh hardas July 31, 2017, 9:17 a.m. UTC 
From: RishabhHardas <rishabhhardas@gmail.com>

Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and 'fips_handler'
that they were not declared and need to be made static. This patch makes both the symbols
static inline, to remove the warnings.

Signed-off-by: RishabhHardas <rishabhhardas@gmail.com>
---
 drivers/staging/ccree/ssi_fips.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


 static inline void ssi_fips_fini(struct ssi_drvdata *drvdata) {}
-void cc_set_ree_fips_status(struct ssi_drvdata *drvdata, bool ok) {}
-void fips_handler(struct ssi_drvdata *drvdata) {}
+static inline void cc_set_ree_fips_status(struct ssi_drvdata *drvdata, bool ok) {}
+static inline void fips_handler(struct ssi_drvdata *drvdata) {}

 #endif /* CONFIG_CRYPTO_FIPS */

--
1.9.1

Comments

Gilad Ben-Yossef Aug. 1, 2017, 12:35 p.m. UTC | #1 
On Mon, Jul 31, 2017 at 12:17 PM, RishabhHardas
<rishabheudyptula@gmail.com> wrote:
> From: RishabhHardas <rishabhhardas@gmail.com>
>
> Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and 'fips_handler'
> that they were not declared and need to be made static. This patch makes both the symbols
> static inline, to remove the warnings.
>
> Signed-off-by: RishabhHardas <rishabhhardas@gmail.com>

Acked-by: Gilad Ben-Yossef <gilad@benyossef.com>

Thanks,
Gilad
Greg KH Aug. 16, 2017, 10:09 p.m. UTC | #2 
On Mon, Jul 31, 2017 at 02:47:23PM +0530, RishabhHardas wrote:
> From: RishabhHardas <rishabhhardas@gmail.com>
> 
> Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and 'fips_handler'
> that they were not declared and need to be made static. This patch makes both the symbols
> static inline, to remove the warnings.
> 
> Signed-off-by: RishabhHardas <rishabhhardas@gmail.com>

I doubt you sign your name on legal documents without a ' ' somewhere in
it :(

Please fix up and resend.

thanks,

greg k-h
diff mbox

Patch

diff --git a/drivers/staging/ccree/ssi_fips.h b/drivers/staging/ccree/ssi_fips.h
index 369ddf9..63bcca7 100644
--- a/drivers/staging/ccree/ssi_fips.h
+++ b/drivers/staging/ccree/ssi_fips.h
@@ -40,1 +40,1 @@  static inline int ssi_fips_init(struct ssi_drvdata *p_drvdata)
 }