| Message ID | 1510047606-5589-4-git-send-email-gilad@benyossef.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Herbert Xu |
| Headers | show |
On Tue, Nov 07, 2017 at 09:39:59AM +0000, Gilad Ben-Yossef wrote: > Make the code more readable by using a local variable > for commonly use expression in the AEAD part of the driver. > > Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> > --- > drivers/staging/ccree/ssi_aead.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c > index 0b5b230..f1a3976 100644 > --- a/drivers/staging/ccree/ssi_aead.c > +++ b/drivers/staging/ccree/ssi_aead.c > @@ -251,13 +251,11 @@ static void ssi_aead_complete(struct device *dev, void *ssi_req, void __iomem *c > } > } else { /*ENCRYPT*/ > if (unlikely(areq_ctx->is_icv_fragmented)) { > + u32 loc = areq->cryptlen + areq_ctx->dst_offset; "loc" isn't a very canonical name. At first I thought this was "pos" or maybe "end" but now I'm thinking this is "skip"? I don't know what this variable is. > + > cc_copy_sg_portion(dev, areq_ctx->mac_buf, > - areq_ctx->dst_sgl, > - (areq->cryptlen + > - areq_ctx->dst_offset), > - (areq->cryptlen + > - areq_ctx->dst_offset + > - ctx->authsize), > + areq_ctx->dst_sgl, loc, > + (loc + ctx->authsize), > SSI_SG_FROM_BUF); > } regards, dan carpenter
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c index 0b5b230..f1a3976 100644 --- a/drivers/staging/ccree/ssi_aead.c +++ b/drivers/staging/ccree/ssi_aead.c @@ -251,13 +251,11 @@ static void ssi_aead_complete(struct device *dev, void *ssi_req, void __iomem *c } } else { /*ENCRYPT*/ if (unlikely(areq_ctx->is_icv_fragmented)) { + u32 loc = areq->cryptlen + areq_ctx->dst_offset; + cc_copy_sg_portion(dev, areq_ctx->mac_buf, - areq_ctx->dst_sgl, - (areq->cryptlen + - areq_ctx->dst_offset), - (areq->cryptlen + - areq_ctx->dst_offset + - ctx->authsize), + areq_ctx->dst_sgl, loc, + (loc + ctx->authsize), SSI_SG_FROM_BUF); }
Make the code more readable by using a local variable for commonly use expression in the AEAD part of the driver. Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> --- drivers/staging/ccree/ssi_aead.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)