| Message ID | 1510047606-5589-7-git-send-email-gilad@benyossef.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Herbert Xu |
| Headers | show |
On Tue, Nov 07, 2017 at 09:40:02AM +0000, Gilad Ben-Yossef wrote: > --- a/drivers/staging/ccree/ssi_pm.c > +++ b/drivers/staging/ccree/ssi_pm.c > @@ -90,20 +90,24 @@ int cc_pm_resume(struct device *dev) > int cc_pm_get(struct device *dev) > { > int rc = 0; > + struct ssi_drvdata *drvdata = > + (struct ssi_drvdata *)dev_get_drvdata(dev); No need to cast: struct ssi_drvdata *drvdata = dev_get_drvdata(dev); regards, dan carpenter
On Tue, Nov 7, 2017 at 12:43 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > On Tue, Nov 07, 2017 at 09:40:02AM +0000, Gilad Ben-Yossef wrote: >> --- a/drivers/staging/ccree/ssi_pm.c >> +++ b/drivers/staging/ccree/ssi_pm.c >> @@ -90,20 +90,24 @@ int cc_pm_resume(struct device *dev) >> int cc_pm_get(struct device *dev) >> { >> int rc = 0; >> + struct ssi_drvdata *drvdata = >> + (struct ssi_drvdata *)dev_get_drvdata(dev); > > No need to cast: > > struct ssi_drvdata *drvdata = dev_get_drvdata(dev); > The same unneeded cast appears at other places in the file, so I opted to add a patch addressing all these location rather then change this one. I hope it's OK. Gilad
On Thu, Nov 09, 2017 at 08:27:28AM +0200, Gilad Ben-Yossef wrote: > On Tue, Nov 7, 2017 at 12:43 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > > On Tue, Nov 07, 2017 at 09:40:02AM +0000, Gilad Ben-Yossef wrote: > >> --- a/drivers/staging/ccree/ssi_pm.c > >> +++ b/drivers/staging/ccree/ssi_pm.c > >> @@ -90,20 +90,24 @@ int cc_pm_resume(struct device *dev) > >> int cc_pm_get(struct device *dev) > >> { > >> int rc = 0; > >> + struct ssi_drvdata *drvdata = > >> + (struct ssi_drvdata *)dev_get_drvdata(dev); > > > > No need to cast: > > > > struct ssi_drvdata *drvdata = dev_get_drvdata(dev); > > > > The same unneeded cast appears at other places in the file, so I opted > to add a patch addressing all these location rather then change this one. > > I hope it's OK. I don't care about this one patch, it's fine. But generally and for future reference, we don't try very hard to use a consistent style within a driver. The preference is almost always kernel style over driver style so new code should always be "kernel style" where we avoid casting from kmalloc() or other functions that return void pointers. regards, dan carpenter
diff --git a/drivers/staging/ccree/ssi_pm.c b/drivers/staging/ccree/ssi_pm.c index e1bc4c5..d60143c 100644 --- a/drivers/staging/ccree/ssi_pm.c +++ b/drivers/staging/ccree/ssi_pm.c @@ -90,20 +90,24 @@ int cc_pm_resume(struct device *dev) int cc_pm_get(struct device *dev) { int rc = 0; + struct ssi_drvdata *drvdata = + (struct ssi_drvdata *)dev_get_drvdata(dev); - if (cc_req_queue_suspended((struct ssi_drvdata *)dev_get_drvdata(dev))) { + if (cc_req_queue_suspended(drvdata)) rc = pm_runtime_get_sync(dev); - } else { + else pm_runtime_get_noresume(dev); - } + return rc; } int cc_pm_put_suspend(struct device *dev) { int rc = 0; + struct ssi_drvdata *drvdata = + (struct ssi_drvdata *)dev_get_drvdata(dev); - if (!cc_req_queue_suspended((struct ssi_drvdata *)dev_get_drvdata(dev))) { + if (!cc_req_queue_suspended(drvdata)) { pm_runtime_mark_last_busy(dev); rc = pm_runtime_put_autosuspend(dev); } else {
Make the code more readable by using a local variable. Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com> --- drivers/staging/ccree/ssi_pm.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)