From patchwork Thu Jan 25 09:57:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia-Ju Bai X-Patchwork-Id: 10183809 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8645860233 for ; Thu, 25 Jan 2018 09:53:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 74D4228A48 for ; Thu, 25 Jan 2018 09:53:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 672F828A6D; Thu, 25 Jan 2018 09:53:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3422328A48 for ; Thu, 25 Jan 2018 09:53:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751171AbeAYJx0 (ORCPT ); Thu, 25 Jan 2018 04:53:26 -0500 Received: from mail-it0-f65.google.com ([209.85.214.65]:37190 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751136AbeAYJxZ (ORCPT ); Thu, 25 Jan 2018 04:53:25 -0500 Received: by mail-it0-f65.google.com with SMTP id q8so8676273itb.2; Thu, 25 Jan 2018 01:53:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ra0mYq5JhWf27OZvzjvrcWdqfhqFUl7qrx08dPFa54E=; b=LCT+FX8NbyCsftlzLOUJCwN2J8RkRnOF/0EiJLpj6flQK+YKShxFi03AxBsVo3w/l7 zK5p2r6YRSgXlnBSZh8v6/k3+j04qj6rCtXoHH/0z5QlSl5SWT+2VNIHc8tS3FYgpvxG SHkmhTs8knRICoOx7ylK0fAWsHw8PB9g6v+CHnscAN/OMiorpdyPdQxADOmwU79tylSf NI9X4IYvVW4XcwupMxS6k1KZIppc7/iVQQIFVB0v0KzAVtbILX6OtINjNNI22oUCuiO/ 00sqvv7Q31KpcXiROoBRwkw1je6Y5ShIf5J/K7lEb5TUnvhTuSQihcanj35AVsizqRy2 RUUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ra0mYq5JhWf27OZvzjvrcWdqfhqFUl7qrx08dPFa54E=; b=XFZKuxOPaIpz9Fa1nvuePT6VQEVv4NlehuBnLUIc4KgQF/0zYn+kL+2CzQjImLWoCy fXl0FK5WyghlqYLrQqPCuAwR0q8a9bhM6+QlbQgLXFZkK1ccBVEw8xeFQhvKcCHaCivL ufAtq6qLhUClqE6xrXvU6ba8hN6VTSXhWsIDwFYaOgYcGnYPCLfsPXkutMUoNg/i4TeI oae0h3CYM7380GtYZbo0iO2Aqho7ZcVTAmYIFwtLPEe1M2GC33rdjG2yuUTxQTJ/i8qc 6ZjfSFcKtEml4CZCa46L/qHrkQtzmWSqbBUOaqcjOFjmJJFPjqbAedHfCoHvwTRh5RvF GPcw== X-Gm-Message-State: AKwxytfNaD1p4hGPqQimzX22wPM6vbHerawGgSCkepm6dBhwVapnrtAd sstV7gufzJebx+wam5/GOOM= X-Google-Smtp-Source: AH8x226/Q8H2QeA/VCEhHVkaTbP8MD4H73zGODYw14L3J1K0sll5eUt/uZlkUOUImFRtwHu1k5NS7A== X-Received: by 10.36.230.3 with SMTP id e3mr11818387ith.99.1516874004946; Thu, 25 Jan 2018 01:53:24 -0800 (PST) Received: from bai-oslab.tsinghua.edu.cn ([2402:f000:1:4413:9980:256a:8e6d:5903]) by smtp.gmail.com with ESMTPSA id e78sm713732itd.37.2018.01.25.01.53.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jan 2018 01:53:24 -0800 (PST) From: Jia-Ju Bai To: herbert@gondor.apana.org.au, davem@davemloft.net Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] crypto: rsa-pkcs1pad: Replace GFP_ATOMIC with GFP_KERNEL in pkcs1pad_encrypt_sign_complete Date: Thu, 25 Jan 2018 17:57:54 +0800 Message-Id: <1516874274-11851-1-git-send-email-baijiaju1990@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP After checking all possible call chains to kzalloc here, my tool finds that this kzalloc is never called in atomic context. Thus GFP_ATOMIC is not necessary, and it can be replaced with GFP_KERNEL. This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai --- crypto/rsa-pkcs1pad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/rsa-pkcs1pad.c b/crypto/rsa-pkcs1pad.c index 2908f93..9893dbf 100644 --- a/crypto/rsa-pkcs1pad.c +++ b/crypto/rsa-pkcs1pad.c @@ -192,7 +192,7 @@ static int pkcs1pad_encrypt_sign_complete(struct akcipher_request *req, int err) if (likely(!pad_len)) goto out; - out_buf = kzalloc(ctx->key_size, GFP_ATOMIC); + out_buf = kzalloc(ctx->key_size, GFP_KERNEL); err = -ENOMEM; if (!out_buf) goto out;