Message ID | 1584936180.9256.15326.camel@hbabu-laptop (mailing list archive) |
---|---|
State | Not Applicable |
Delegated to: | Herbert Xu |
Headers | show |
Series | crypto/nx: Enable GZIP engine and provide userpace API | expand |
On Sun, Mar 22, 2020 at 09:03:00PM -0700, Haren Myneni wrote: > > coproc entry is initialized during NX probe on power9, but not on P8. > nx842_delete_coprocs() is used for both and frees receive window if it > is allocated. Getting crash for rmmod on P8 since coproc->vas.rxwin > is not initialized. > > This patch replaces kmalloc with kzalloc in nx842_powernv_probe() > > Signed-off-by: Haren Myneni <haren@linux.ibm.com> > --- > drivers/crypto/nx/nx-842-powernv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/drivers/crypto/nx/nx-842-powernv.c b/drivers/crypto/nx/nx-842-powernv.c index c037a24..8e63326 100644 --- a/drivers/crypto/nx/nx-842-powernv.c +++ b/drivers/crypto/nx/nx-842-powernv.c @@ -922,7 +922,7 @@ static int __init nx842_powernv_probe(struct device_node *dn) return -EINVAL; } - coproc = kmalloc(sizeof(*coproc), GFP_KERNEL); + coproc = kzalloc(sizeof(*coproc), GFP_KERNEL); if (!coproc) return -ENOMEM;
coproc entry is initialized during NX probe on power9, but not on P8. nx842_delete_coprocs() is used for both and frees receive window if it is allocated. Getting crash for rmmod on P8 since coproc->vas.rxwin is not initialized. This patch replaces kmalloc with kzalloc in nx842_powernv_probe() Signed-off-by: Haren Myneni <haren@linux.ibm.com> --- drivers/crypto/nx/nx-842-powernv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)