| Message ID | 1587608556-113975-1-git-send-email-zou_wei@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | [-next] crypto: hisilicon/qm - Make qm_controller_reset() static | expand |
On 2020/4/23 10:22, Zou Wei wrote: > Fix the following sparse warning: > > drivers/crypto/hisilicon/qm.c:3079:5: warning: symbol 'qm_controller_reset' > was not declared. Should it be static? It should be static. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zou Wei <zou_wei@huawei.com> Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com> Thanks, Zhou > --- > drivers/crypto/hisilicon/qm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c > index 80c5525..69d02cb 100644 > --- a/drivers/crypto/hisilicon/qm.c > +++ b/drivers/crypto/hisilicon/qm.c > @@ -3076,7 +3076,7 @@ static int qm_controller_reset_done(struct hisi_qm *qm) > return 0; > } > > -int qm_controller_reset(struct hisi_qm *qm) > +static int qm_controller_reset(struct hisi_qm *qm) > { > struct pci_dev *pdev = qm->pdev; > int ret; >
On Thu, Apr 23, 2020 at 10:22:36AM +0800, Zou Wei wrote: > Fix the following sparse warning: > > drivers/crypto/hisilicon/qm.c:3079:5: warning: symbol 'qm_controller_reset' > was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zou Wei <zou_wei@huawei.com> > --- > drivers/crypto/hisilicon/qm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks.
diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c index 80c5525..69d02cb 100644 --- a/drivers/crypto/hisilicon/qm.c +++ b/drivers/crypto/hisilicon/qm.c @@ -3076,7 +3076,7 @@ static int qm_controller_reset_done(struct hisi_qm *qm) return 0; } -int qm_controller_reset(struct hisi_qm *qm) +static int qm_controller_reset(struct hisi_qm *qm) { struct pci_dev *pdev = qm->pdev; int ret;
Fix the following sparse warning: drivers/crypto/hisilicon/qm.c:3079:5: warning: symbol 'qm_controller_reset' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zou Wei <zou_wei@huawei.com> --- drivers/crypto/hisilicon/qm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)