| Message ID | 1612231575-15646-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | [v2] crypto: caam - Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE | expand |
On 2/2/2021 4:06 AM, Jiapeng Chong wrote: > Fix the following coccicheck warning: > > ./drivers/crypto/caam/debugfs.c:23:0-23: WARNING: caam_fops_u64_ro > should be defined with DEFINE_DEBUGFS_ATTRIBUTE. > > ./drivers/crypto/caam/debugfs.c:22:0-23: WARNING: caam_fops_u32_ro > should be defined with DEFINE_DEBUGFS_ATTRIBUTE. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Reviewed-by: Horia Geantă <horia.geanta@nxp.com> Thanks, Horia
On Tue, Feb 02, 2021 at 10:06:15AM +0800, Jiapeng Chong wrote: > Fix the following coccicheck warning: > > ./drivers/crypto/caam/debugfs.c:23:0-23: WARNING: caam_fops_u64_ro > should be defined with DEFINE_DEBUGFS_ATTRIBUTE. > > ./drivers/crypto/caam/debugfs.c:22:0-23: WARNING: caam_fops_u32_ro > should be defined with DEFINE_DEBUGFS_ATTRIBUTE. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > Changes in v2: > -Modified subject. > > drivers/crypto/caam/debugfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks.
diff --git a/drivers/crypto/caam/debugfs.c b/drivers/crypto/caam/debugfs.c index 8ebf183..806bb20 100644 --- a/drivers/crypto/caam/debugfs.c +++ b/drivers/crypto/caam/debugfs.c @@ -19,8 +19,8 @@ static int caam_debugfs_u32_get(void *data, u64 *val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(caam_fops_u32_ro, caam_debugfs_u32_get, NULL, "%llu\n"); -DEFINE_SIMPLE_ATTRIBUTE(caam_fops_u64_ro, caam_debugfs_u64_get, NULL, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(caam_fops_u32_ro, caam_debugfs_u32_get, NULL, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(caam_fops_u64_ro, caam_debugfs_u64_get, NULL, "%llu\n"); #ifdef CONFIG_CAAM_QI /*
Fix the following coccicheck warning: ./drivers/crypto/caam/debugfs.c:23:0-23: WARNING: caam_fops_u64_ro should be defined with DEFINE_DEBUGFS_ATTRIBUTE. ./drivers/crypto/caam/debugfs.c:22:0-23: WARNING: caam_fops_u32_ro should be defined with DEFINE_DEBUGFS_ATTRIBUTE. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- Changes in v2: -Modified subject. drivers/crypto/caam/debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)