| Message ID | 1617161697-121478-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: deflate - Remove useless call "zlib_inflateEnd" | expand |
On Wed, Mar 31, 2021 at 11:34:57AM +0800, Jiapeng Chong wrote: > Fix the following whitescan warning: > > Calling "zlib_inflateEnd(&ctx->decomp_stream)" is only useful for its > return value, which is ignored. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > crypto/deflate.c | 1 - > 1 file changed, 1 deletion(-) The function might not do anything today but the documentation clearly indicates that it could free any dynamically allocated data so it should stay. Cheers,
diff --git a/crypto/deflate.c b/crypto/deflate.c index b2a46f6..cac1672 100644 --- a/crypto/deflate.c +++ b/crypto/deflate.c @@ -101,7 +101,6 @@ static void deflate_comp_exit(struct deflate_ctx *ctx) static void deflate_decomp_exit(struct deflate_ctx *ctx) { - zlib_inflateEnd(&ctx->decomp_stream); vfree(ctx->decomp_stream.workspace); }
Fix the following whitescan warning: Calling "zlib_inflateEnd(&ctx->decomp_stream)" is only useful for its return value, which is ignored. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- crypto/deflate.c | 1 - 1 file changed, 1 deletion(-)