| Message ID | 1617362550-23630-1-git-send-email-yekai13@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | [v2] crypto: hisilicon/qm - delete redundant code | expand |
On Fri, Apr 02, 2021 at 07:22:30PM +0800, Kai Ye wrote: > The "qdma" is a structure variable instead of actual data. This > structure doesn't need to be zerod, The memset is useless and redundant. > So delete it. > > Signed-off-by: Kai Ye <yekai13@huawei.com> > --- > Changes v1 -> v2: > Re-edit the description. > > drivers/crypto/hisilicon/qm.c | 1 - > 1 file changed, 1 deletion(-) Patch applied. Thanks.
diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c index 13cb421..88a6c6f 100644 --- a/drivers/crypto/hisilicon/qm.c +++ b/drivers/crypto/hisilicon/qm.c @@ -2527,7 +2527,6 @@ void hisi_qm_uninit(struct hisi_qm *qm) hisi_qm_cache_wb(qm); dma_free_coherent(dev, qm->qdma.size, qm->qdma.va, qm->qdma.dma); - memset(&qm->qdma, 0, sizeof(qm->qdma)); } qm_irq_unregister(qm);
The "qdma" is a structure variable instead of actual data. This structure doesn't need to be zerod, The memset is useless and redundant. So delete it. Signed-off-by: Kai Ye <yekai13@huawei.com> --- Changes v1 -> v2: Re-edit the description. drivers/crypto/hisilicon/qm.c | 1 - 1 file changed, 1 deletion(-)