| Message ID | 1719085.BFjRV9CsT2@positron.chronox.de (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Herbert Xu |
| Headers | show |
Hi Stephan,
[auto build test ERROR on cryptodev/master]
[also build test ERROR on v4.8-rc1]
[cannot apply to next-20160811]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Stephan-Mueller/crypto-DRBG-externalize-DRBG-functions-for-LRNG/20160811-203346
base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: tile-allyesconfig (attached as .config)
compiler: tilegx-linux-gcc (GCC) 4.6.2
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=tile
All error/warnings (new ones prefixed by >>):
crypto/lrng_base.c: In function 'add_interrupt_randomness':
>> crypto/lrng_base.c:583:10: error: implicit declaration of function 'get_irq_regs'
>> crypto/lrng_base.c:583:26: warning: initialization makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors
vim +/get_irq_regs +583 crypto/lrng_base.c
22708393 Stephan Mueller 2016-08-11 567 }
22708393 Stephan Mueller 2016-08-11 568
22708393 Stephan Mueller 2016-08-11 569 /**
22708393 Stephan Mueller 2016-08-11 570 * Hot code path - Callback for interrupt handler
22708393 Stephan Mueller 2016-08-11 571 */
22708393 Stephan Mueller 2016-08-11 572 void add_interrupt_randomness(int irq, int irq_flags)
22708393 Stephan Mueller 2016-08-11 573 {
22708393 Stephan Mueller 2016-08-11 574 u32 now_time = random_get_entropy();
22708393 Stephan Mueller 2016-08-11 575 struct lrng_irq_info *irq_info = &lrng_pool.irq_info;
22708393 Stephan Mueller 2016-08-11 576 u32 irq_num = (u32)atomic_add_return(1, &irq_info->num_events);
22708393 Stephan Mueller 2016-08-11 577
22708393 Stephan Mueller 2016-08-11 578 if (lrng_pool.irq_info.irq_highres_timer) {
22708393 Stephan Mueller 2016-08-11 579 if (lrng_irq_stuck(irq_info, now_time))
22708393 Stephan Mueller 2016-08-11 580 return;
22708393 Stephan Mueller 2016-08-11 581 lrng_pool_mixin((u8 *)&now_time, sizeof(now_time), irq_num);
22708393 Stephan Mueller 2016-08-11 582 } else {
22708393 Stephan Mueller 2016-08-11 @583 struct pt_regs *regs = get_irq_regs();
22708393 Stephan Mueller 2016-08-11 584 static atomic_t reg_idx = ATOMIC_INIT(0);
22708393 Stephan Mueller 2016-08-11 585
22708393 Stephan Mueller 2016-08-11 586 struct {
22708393 Stephan Mueller 2016-08-11 587 long jiffies;
22708393 Stephan Mueller 2016-08-11 588 int irq;
22708393 Stephan Mueller 2016-08-11 589 int irq_flags;
22708393 Stephan Mueller 2016-08-11 590 u64 ip;
22708393 Stephan Mueller 2016-08-11 591 u32 curr_reg;
:::::: The code at line 583 was first introduced by commit
:::::: 227083931f3541c5430b40241419b56057555033 crypto: Linux Random Number Generator
:::::: TO: Stephan Mueller <smueller@chronox.de>
:::::: CC: 0day robot <fengguang.wu@intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Am Donnerstag, 11. August 2016, 21:50:15 CEST schrieb kbuild test robot: Hi, > Hi Stephan, > > [auto build test ERROR on cryptodev/master] > [also build test ERROR on v4.8-rc1] > [cannot apply to next-20160811] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] Thank you for the report. This is due to the missing include of asm/irq_regs.h which seem to be included my the tested arches through some other means. I will add it in an update. Ciao Stephan -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/crypto/Kconfig b/crypto/Kconfig index 84d7148..71df7fc 100644 --- a/crypto/Kconfig +++ b/crypto/Kconfig @@ -1665,6 +1665,17 @@ config CRYPTO_JITTERENTROPY random numbers. This Jitterentropy RNG registers with the kernel crypto API and can be used by any caller. +config CRYPTO_LRNG + bool "Linux Random Number Generator" + select CRYPTO_DRBG_MENU + select CRYPTO_CMAC if CRYPTO_DRBG_CTR + help + The Linux Random Number Generator (LRNG) is the replacement + of the legacy /dev/random provided with drivers/char/random.c. + It generates entropy from different noise sources and + delivers significant entropy during boot. The LRNG only + works with the presence of a high-resolution timer. + config CRYPTO_USER_API tristate diff --git a/crypto/Makefile b/crypto/Makefile index 99cc64a..12d4249 100644 --- a/crypto/Makefile +++ b/crypto/Makefile @@ -122,6 +122,8 @@ obj-$(CONFIG_CRYPTO_DRBG) += drbg.o obj-$(CONFIG_CRYPTO_JITTERENTROPY) += jitterentropy_rng.o CFLAGS_jitterentropy.o = -O0 jitterentropy_rng-y := jitterentropy.o jitterentropy-kcapi.o +obj-$(CONFIG_CRYPTO_LRNG) += lrng.o +lrng-y += lrng_base.o lrng_kcapi.o obj-$(CONFIG_CRYPTO_TEST) += tcrypt.o obj-$(CONFIG_CRYPTO_GHASH) += ghash-generic.o obj-$(CONFIG_CRYPTO_USER_API) += af_alg.o
Add LRNG compilation support. Signed-off-by: Stephan Mueller <smueller@chronox.de> --- crypto/Kconfig | 11 +++++++++++ crypto/Makefile | 2 ++ 2 files changed, 13 insertions(+)