From patchwork Mon Nov 17 14:14:20 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konstantin Khlebnikov X-Patchwork-Id: 5322361 Return-Path: X-Original-To: patchwork-linux-crypto@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8B6DEC11AC for ; Mon, 17 Nov 2014 15:14:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B679420114 for ; Mon, 17 Nov 2014 15:14:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 957862010F for ; Mon, 17 Nov 2014 15:14:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751984AbaKQPOY (ORCPT ); Mon, 17 Nov 2014 10:14:24 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:17544 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750812AbaKQPOX (ORCPT ); Mon, 17 Nov 2014 10:14:23 -0500 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NF600HOFVSK8620@mailout2.w1.samsung.com>; Mon, 17 Nov 2014 15:17:08 +0000 (GMT) X-AuditID: cbfec7f5-b7f956d000005ed7-7c-546a10cd79e1 Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 63.68.24279.DC01A645; Mon, 17 Nov 2014 15:14:21 +0000 (GMT) Received: from localhost ([106.109.129.38]) by eusync3.samsung.com (Oracle Communications Messaging Server 7u4-23.01 (7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0NF600FL0VNWS1A0@eusync3.samsung.com>; Mon, 17 Nov 2014 15:14:20 +0000 (GMT) Subject: [PATCH 1/2] scripts/coccinelle: catch freeing cryptographic structures via kfree From: Konstantin Khlebnikov To: kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Eric Biederman Cc: Michal Marek , Herbert Xu , Gilles Muller , Nicolas Palix , Julia Lawall , linux-crypto@vger.kernel.org, "David S. Miller" Date: Mon, 17 Nov 2014 18:14:20 +0400 Message-id: <20141117151420.10739.16342.stgit@buzz> User-Agent: StGit/0.17.1-dirty MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGLMWRmVeSWpSXmKPExsVy+t/xq7pnBbJCDBYsZ7aYc76FxeL/thZ2 i9k/LzFZdL+SsVj24DSjxY+dvawWu09/ZbK4f+8nk8XlXXPYLFr2XWCyOPZyOZMDt8eWlTeZ PLYdUPU4dqyV2WPvliyPzUvqPfq2rGL0OLPgCLvH501yHlMOtbMEcEZx2aSk5mSWpRbp2yVw ZUxbdYq14Bt3xeVrk1kaGJu4uhg5OCQETCTuX9LtYuQEMsUkLtxbz9bFyMUhJLCUUeL44p8s IAkhgUYmibO7wkHqhQWiJV5vjAAJswmYSWzbd5sRxBYRSJVYsOgIM0gvs0A3k8SqVy+YQBIs AqoSD27+ZQexeQWMJeZPfskMYosKyEmsvNzCChEXlPgx+R4LyHxmAXWJKVNyQcLMAvISm9e8 ZZ7AyDcLSdUshKpZSKoWMDKvYhRNLU0uKE5KzzXSK07MLS7NS9dLzs/dxAgJ+687GJceszrE KMDBqMTDe6AoM0SINbGsuDL3EKMEB7OSCG/MRaAQb0piZVVqUX58UWlOavEhRiYOTqkGxmsv Pl3vsGpo6fRl8my7abtd4VGRC8uMQ8J/BeexBz5mavvYu+NKjKGcyJ/JBQ8fWObm6BTO6vj1 xm8jnzLjhMLFR/TffzSseRXfk9jKw9t2sJFLatH11qpvX3umt5VfsYo/NHuH9J2NC8xcZZK7 J7Iknujvankkr+Xx5n5704cFNsfW1DnfVGIpzkg01GIuKk4EAAb289xZAgAA Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Structures allocated by crypto_alloc_* must be freed using crypto_free_*. Signed-off-by: Konstantin Khlebnikov --- scripts/coccinelle/free/crypto_free.cocci | 45 +++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100644 scripts/coccinelle/free/crypto_free.cocci -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/scripts/coccinelle/free/crypto_free.cocci b/scripts/coccinelle/free/crypto_free.cocci new file mode 100644 index 0000000..0799b70 --- /dev/null +++ b/scripts/coccinelle/free/crypto_free.cocci @@ -0,0 +1,45 @@ +/// +/// Structures allocated by crypto_alloc_* must be freed using crypto_free_*. +/// This finds freeing them by kfree. +/// +// Confidence: Moderate +// Copyright: (C) 2014 Konstantin Khlebnikov, GPLv2. +// Comments: There are false positives in crypto/ where they are actually freed. +// Keywords: crypto, kfree +// Options: --no-includes --include-headers + +virtual org +virtual report +virtual context + +@r depends on context || org || report@ +expression x; +identifier crypto_alloc =~ "^crypto_alloc_"; +@@ + +( + x = crypto_alloc(...) +) + +@pb@ +expression r.x; +position p; +@@ + +( +* kfree@p(x) +) + +@script:python depends on org@ +p << pb.p; +@@ + +msg="WARNING: invalid free of crypto_alloc_* allocated data" +coccilib.org.print_todo(p[0], msg) + +@script:python depends on report@ +p << pb.p; +@@ + +msg="WARNING: invalid free of crypto_alloc_* allocated data" +coccilib.report.print_report(p[0], msg)