From patchwork Mon Mar 9 20:35:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 5971121 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Original-To: patchwork-linux-crypto@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 82529BF440 for ; Mon, 9 Mar 2015 20:35:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9BEAC201FA for ; Mon, 9 Mar 2015 20:35:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C321C201EC for ; Mon, 9 Mar 2015 20:35:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753219AbbCIUfo (ORCPT ); Mon, 9 Mar 2015 16:35:44 -0400 Received: from mail-ie0-f179.google.com ([209.85.223.179]:38578 "EHLO mail-ie0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753107AbbCIUfn (ORCPT ); Mon, 9 Mar 2015 16:35:43 -0400 Received: by iecrl12 with SMTP id rl12so24120970iec.5; Mon, 09 Mar 2015 13:35:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=m/MjnC/0IZlb5wmnGNv69Pq/1xFhV1dZReztDYetrxw=; b=dKZbXINygOw5bqmgQeOnpQR40CPc0XvDTrjsrixwUTdTGfUuJwsXCTj/QSut8JDHG3 wq3XFQJXj7LNTJCd9SVycK5Z6epZv0IvVIfgDM88RrT4VmDy8q6dal/+7OBCzd2kWPcr 4L1Hs5o1xxS50tkidQvpHKSz2ANVfW7gjer4D2l31RC2rIbCR4M/igUvp1LTb2J4A7wc Lzbv2uGCNHx4rH2i4jN2PdPLP6roeBgLUvM1x6N+g2MJvVglMUb2/9kSEHqEcrzHDOt0 v517aIDwBZzfhayaH/bXoLl+VfhS/iKemQxxo5dsDh91kKJQB2TvGc8dquOuSfIFbuAP 5jNw== X-Received: by 10.107.135.75 with SMTP id j72mr12210732iod.0.1425933343106; Mon, 09 Mar 2015 13:35:43 -0700 (PDT) Received: from dtor-ws ([2620:0:1000:1301:85cb:b632:74e6:1b9c]) by mx.google.com with ESMTPSA id n15sm4310075ioe.6.2015.03.09.13.35.41 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 09 Mar 2015 13:35:41 -0700 (PDT) Date: Mon, 9 Mar 2015 13:35:39 -0700 From: Dmitry Torokhov To: Herbert Xu Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] crypto: amcc: remove incorrect __init/__exit markups Message-ID: <20150309203539.GA11240@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Even if bus is not hot-pluggable, the devices can be bound and unbound from the driver via sysfs, so we should not be using __init/__exit annotations on probe() and remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by: Dmitry Torokhov --- drivers/crypto/amcc/crypto4xx_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/amcc/crypto4xx_core.c b/drivers/crypto/amcc/crypto4xx_core.c index d02b771..3b28e8c 100644 --- a/drivers/crypto/amcc/crypto4xx_core.c +++ b/drivers/crypto/amcc/crypto4xx_core.c @@ -1155,7 +1155,7 @@ struct crypto4xx_alg_common crypto4xx_alg[] = { /** * Module Initialization Routine */ -static int __init crypto4xx_probe(struct platform_device *ofdev) +static int crypto4xx_probe(struct platform_device *ofdev) { int rc; struct resource res; @@ -1263,7 +1263,7 @@ err_alloc_dev: return rc; } -static int __exit crypto4xx_remove(struct platform_device *ofdev) +static int crypto4xx_remove(struct platform_device *ofdev) { struct device *dev = &ofdev->dev; struct crypto4xx_core_device *core_dev = dev_get_drvdata(dev); @@ -1291,7 +1291,7 @@ static struct platform_driver crypto4xx_driver = { .of_match_table = crypto4xx_match, }, .probe = crypto4xx_probe, - .remove = __exit_p(crypto4xx_remove), + .remove = crypto4xx_remove, }; module_platform_driver(crypto4xx_driver);