From patchwork Tue Mar 31 16:30:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Allan, Bruce W" X-Patchwork-Id: 6132001 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Original-To: patchwork-linux-crypto@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1BBA59F2EC for ; Tue, 31 Mar 2015 16:31:06 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5213D201CE for ; Tue, 31 Mar 2015 16:31:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73479201C8 for ; Tue, 31 Mar 2015 16:31:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753948AbbCaQax (ORCPT ); Tue, 31 Mar 2015 12:30:53 -0400 Received: from mga02.intel.com ([134.134.136.20]:28425 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754496AbbCaQav (ORCPT ); Tue, 31 Mar 2015 12:30:51 -0400 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 31 Mar 2015 09:30:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,502,1422950400"; d="scan'208";a="673247017" Received: from bwallan-smackover2.jf.intel.com ([134.134.3.52]) by orsmga001.jf.intel.com with ESMTP; 31 Mar 2015 09:30:51 -0700 Received: from bwallan-smackover2.jf.intel.com (localhost.localdomain [127.0.0.1]) by bwallan-smackover2.jf.intel.com (8.14.8/8.14.8) with ESMTP id t2VGUokX006470 for ; Tue, 31 Mar 2015 09:30:50 -0700 Subject: [PATCH] crypto: qat - fix checkpatch COMPARISON_TO_NULL issue From: Bruce Allan To: linux-crypto@vger.kernel.org Date: Tue, 31 Mar 2015 09:30:50 -0700 Message-ID: <20150331163050.6379.93257.stgit@bwallan-smackover2.jf.intel.com> User-Agent: StGit/0.17-dirty MIME-Version: 1.0 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!device_reset_wq" Signed-off-by: Bruce Allan --- drivers/crypto/qat/qat_common/adf_aer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/crypto/qat/qat_common/adf_aer.c b/drivers/crypto/qat/qat_common/adf_aer.c index 82e23b8..2dbc733 100644 --- a/drivers/crypto/qat/qat_common/adf_aer.c +++ b/drivers/crypto/qat/qat_common/adf_aer.c @@ -239,7 +239,7 @@ EXPORT_SYMBOL_GPL(adf_disable_aer); int adf_init_aer(void) { device_reset_wq = create_workqueue("qat_device_reset_wq"); - return (device_reset_wq == NULL) ? -EFAULT : 0; + return !device_reset_wq ? -EFAULT : 0; } void adf_exit_aer(void)