diff mbox

crypto: drbg - Initialise mutex in drbg_healthcheck_sanity

Message ID 20150420032648.GA17746@gondor.apana.org.au (mailing list archive)
State Accepted
Delegated to: Herbert Xu
Headers show

Commit Message

Herbert Xu April 20, 2015, 3:26 a.m. UTC 
As we moved the mutex init out of drbg_instantiate and into cra_init
we need to explicitly initialise the mutex in drbg_healthcheck_sanity.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Comments

Stephan Mueller April 20, 2015, 3:27 a.m. UTC | #1 
Am Montag, 20. April 2015, 11:26:48 schrieb Herbert Xu:

Hi Herbert,

> As we moved the mutex init out of drbg_instantiate and into cra_init
> we need to explicitly initialise the mutex in drbg_healthcheck_sanity.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Acked-by: Stephan Mueller <smueller@chronox.de>
> 
> diff --git a/crypto/drbg.c b/crypto/drbg.c
> index 30ec2a6..57fd479 100644
> --- a/crypto/drbg.c
> +++ b/crypto/drbg.c
> @@ -1741,6 +1741,8 @@ static inline int __init drbg_healthcheck_sanity(void)
> if (!drbg)
>  		return -ENOMEM;
> 
> +	mutex_init(&drbg->drbg_mutex);
> +
>  	/*
>  	 * if the following tests fail, it is likely that there is a buffer
>  	 * overflow as buf is much smaller than the requested or provided
diff mbox

Patch

diff --git a/crypto/drbg.c b/crypto/drbg.c
index 30ec2a6..57fd479 100644
--- a/crypto/drbg.c
+++ b/crypto/drbg.c
@@ -1741,6 +1741,8 @@  static inline int __init drbg_healthcheck_sanity(void)
 	if (!drbg)
 		return -ENOMEM;
 
+	mutex_init(&drbg->drbg_mutex);
+
 	/*
 	 * if the following tests fail, it is likely that there is a buffer
 	 * overflow as buf is much smaller than the requested or provided