From patchwork Thu Oct 15 02:05:49 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Senozhatsky X-Patchwork-Id: 7400041 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Original-To: patchwork-linux-crypto@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 56A15BEEA4 for ; Thu, 15 Oct 2015 02:05:45 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7EE8D2052C for ; Thu, 15 Oct 2015 02:05:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9EC8520832 for ; Thu, 15 Oct 2015 02:05:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754533AbbJOCFA (ORCPT ); Wed, 14 Oct 2015 22:05:00 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:33702 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754373AbbJOCE6 (ORCPT ); Wed, 14 Oct 2015 22:04:58 -0400 Received: by pabrc13 with SMTP id rc13so71203817pab.0; Wed, 14 Oct 2015 19:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=hJJMbMM8cpnlpMXp0DVp7IHN/xgOxe3YZyN2lsRf0bI=; b=w8Eemy4u8/Hi6pwKrLjeijEB/tZrB099l+HVxXv2dCM8pS7srRyaWbkOSfetcLsOIi Qpe0g9Plv7aQzGf3zFWmEuM1PJznLA3Rj34kKfxyof8jKQisOFBwuXvgByXhInaGi41p fydeIDIP4Y9caHqA0DI3Xnajmg4GQswl2iVsTe3LsppTAeAM3M5yBADrP7Fd1SjmXRKd LbSbb4Sc9o5jO0agDdmz69KJiqDziXu0HP0F2kJufFjq5ZFJjnd7cHKTjIGDA5xtM81j ai9OuSPKYw8Vz0vKj6Iz5CfJfhJn2ItpziL20EfPY4ky6Gw6dSp1FYLjjfrMy97b8z7Y Wf+g== X-Received: by 10.66.229.8 with SMTP id sm8mr7080981pac.135.1444874698322; Wed, 14 Oct 2015 19:04:58 -0700 (PDT) Received: from localhost ([110.70.59.174]) by smtp.gmail.com with ESMTPSA id bo5sm11974974pbb.76.2015.10.14.19.04.56 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Oct 2015 19:04:57 -0700 (PDT) Date: Thu, 15 Oct 2015 11:05:49 +0900 From: Sergey Senozhatsky To: Joonsoo Kim Cc: Andrew Morton , Minchan Kim , Nitin Gupta , Sergey Senozhatsky , Herbert Xu , "David S. Miller" , Stephan Mueller , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Joonsoo Kim Subject: Re: [PATCH v4 8/8] zram: enable contextless compression alg in zram Message-ID: <20151015020549.GE1735@swordfish> References: <1444808304-29320-1-git-send-email-iamjoonsoo.kim@lge.com> <1444808304-29320-9-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1444808304-29320-9-git-send-email-iamjoonsoo.kim@lge.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On (10/14/15 16:38), Joonsoo Kim wrote: [..] > @@ -352,6 +352,7 @@ static ssize_t comp_algorithm_show(struct device *dev, > size_t sz; > struct zram *zram = dev_to_zram(dev); > > + deprecated_attr_warn("comp_algorithm"); > down_read(&zram->init_lock); > sz = zcomp_available_show(zram->compressor, buf); > up_read(&zram->init_lock); oh, one more thing. deprecated_attr_warn() should come with `Documentation/ABI/obsolete/sysfs-block-zram' update. something like: --- And I guess Cc `Jonathan Corbet ' (doc maintainer) and 'linux-api@vger.kernel.org' will be the right thing to do here. -ss -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/Documentation/ABI/obsolete/sysfs-block-zram b/Documentation/ABI/obsolete/sysfs-block-zram index 720ea92..ad5b59d 100644 --- a/Documentation/ABI/obsolete/sysfs-block-zram +++ b/Documentation/ABI/obsolete/sysfs-block-zram @@ -117,3 +117,14 @@ Description: Downgraded to write-only node: so it's possible to set new value only; its current value is stored in zram/mm_stat node. + +What: /sys/block/zram/comp_algorithm +Date: XXX +Contact: XXX +Description: + The comp_algorithm file is read/write and provides information + on available, currently selected compression algorithm (read + operation) and lets one to change the compression algorithm + (write operation). + Downgraded to write-only node: use `/proc/crypto' to get the + list of supported compression algorithms.