diff mbox

[1/2] crypto: atmel-sha: Removed unused variable "err"

Message ID 20151214084411.GA8727@visteon.com (mailing list archive)
State Accepted
Delegated to: Herbert Xu
Headers show

Commit Message

Pathak, Rahul (R.) Dec. 14, 2015, 8:44 a.m. UTC 
From: Rahul Pathak <rpathak@visteon.com>

Removed unused variable "err" and directly return "0"

Reported by coccicheck -
./drivers/crypto/atmel-sha.c:758:5-8: Unneeded variable: "err". Return "0" on line 766

Signed-off-by: Rahul Pathak <rpathak@visteon.com>
---
 drivers/crypto/atmel-sha.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Herbert Xu Dec. 17, 2015, 8:46 a.m. UTC | #1 
On Mon, Dec 14, 2015 at 08:44:19AM +0000, Pathak, Rahul (R.) wrote:
> From: Rahul Pathak <rpathak@visteon.com>
> 
> Removed unused variable "err" and directly return "0"
> 
> Reported by coccicheck -
> ./drivers/crypto/atmel-sha.c:758:5-8: Unneeded variable: "err". Return "0" on line 766
> 
> Signed-off-by: Rahul Pathak <rpathak@visteon.com>

Both patches applied.  Thanks.
diff mbox

Patch

diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
index 660d8c0..20de861 100644
--- a/drivers/crypto/atmel-sha.c
+++ b/drivers/crypto/atmel-sha.c
@@ -755,7 +755,6 @@  static int atmel_sha_finish(struct ahash_request *req)
 {
 	struct atmel_sha_reqctx *ctx = ahash_request_ctx(req);
 	struct atmel_sha_dev *dd = ctx->dd;
-	int err = 0;
 
 	if (ctx->digcnt[0] || ctx->digcnt[1])
 		atmel_sha_copy_ready_hash(req);
@@ -763,7 +762,7 @@  static int atmel_sha_finish(struct ahash_request *req)
 	dev_dbg(dd->dev, "digcnt: 0x%llx 0x%llx, bufcnt: %d\n", ctx->digcnt[1],
 		ctx->digcnt[0], ctx->bufcnt);
 
-	return err;
+	return 0;
 }
 
 static void atmel_sha_finish_req(struct ahash_request *req, int err)