From patchwork Mon Jan 18 16:06:05 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean Delvare X-Patchwork-Id: 8055841 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Original-To: patchwork-linux-crypto@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3D3A4BEEE5 for ; Mon, 18 Jan 2016 16:06:16 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6A182203F1 for ; Mon, 18 Jan 2016 16:06:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C73D220390 for ; Mon, 18 Jan 2016 16:06:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755723AbcARQGK (ORCPT ); Mon, 18 Jan 2016 11:06:10 -0500 Received: from mx2.suse.de ([195.135.220.15]:40973 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755689AbcARQGJ (ORCPT ); Mon, 18 Jan 2016 11:06:09 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id B89BBAB9D; Mon, 18 Jan 2016 16:06:06 +0000 (UTC) Date: Mon, 18 Jan 2016 17:06:05 +0100 From: Jean Delvare To: linux-crypto@vger.kernel.org Cc: Tim Chen , Herbert Xu , "David S. Miller" , Michal Marek Subject: [PATCH] crypto: Fix crc32c soft dependency Message-ID: <20160118170605.4e4a022f@endymion.delvare> Organization: SUSE Linux X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-suse-linux-gnu) MIME-Version: 1.0 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I don't think it makes sense for a module to have a soft dependency on itself. This seems quite cyclic by nature and I can't see what purpose it could serve. OTOH libcrc32c calls crypto_alloc_shash("crc32c", 0, 0) so it pretty much assumes that some incarnation of the "crc32c" hash algorithm has been loaded. Therefore it makes sense to have the soft dependency there (as crc-t10dif does.) Signed-off-by: Jean Delvare Cc: Tim Chen Cc: Herbert Xu Cc: "David S. Miller" --- crypto/crc32c_generic.c | 1 - lib/libcrc32c.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) --- linux-4.5-rc0.orig/crypto/crc32c_generic.c 2016-01-11 00:01:32.000000000 +0100 +++ linux-4.5-rc0/crypto/crc32c_generic.c 2016-01-18 16:47:35.243398451 +0100 @@ -172,4 +172,3 @@ MODULE_DESCRIPTION("CRC32c (Castagnoli) MODULE_LICENSE("GPL"); MODULE_ALIAS_CRYPTO("crc32c"); MODULE_ALIAS_CRYPTO("crc32c-generic"); -MODULE_SOFTDEP("pre: crc32c"); --- linux-4.5-rc0.orig/lib/libcrc32c.c 2016-01-11 00:01:32.000000000 +0100 +++ linux-4.5-rc0/lib/libcrc32c.c 2016-01-18 16:47:47.978681236 +0100 @@ -74,3 +74,4 @@ module_exit(libcrc32c_mod_fini); MODULE_AUTHOR("Clay Haapala "); MODULE_DESCRIPTION("CRC32c (Castagnoli) calculations"); MODULE_LICENSE("GPL"); +MODULE_SOFTDEP("pre: crc32c");