diff mbox

[2/4] crypto: ccp - Set the start-of-command bit

Message ID 20170130142834.8459.15278.stgit@taos (mailing list archive)
State Superseded
Delegated to: Herbert Xu
Headers show

Commit Message

Gary R Hook Jan. 30, 2017, 2:28 p.m. UTC 
The start-of-command bit should be set for every sha
operation.

Signed-off-by: Gary R Hook <gary.hook@amd.com>
---
 drivers/crypto/ccp/ccp-ops.c |    1 +
 1 file changed, 1 insertion(+)


--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Gary R Hook Jan. 30, 2017, 5:59 p.m. UTC | #1 
It turns out that this change will negatively impact performance. Please 
ignore.
I will submit a V2 patch set.

On 01/30/2017 08:28 AM, Gary R Hook wrote:
> The start-of-command bit should be set for every sha
> operation.
>
> Signed-off-by: Gary R Hook <gary.hook@amd.com>
> ---
>  drivers/crypto/ccp/ccp-ops.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c
> index 50fae44..1a27af3 100644
> --- a/drivers/crypto/ccp/ccp-ops.c
> +++ b/drivers/crypto/ccp/ccp-ops.c
> @@ -1077,6 +1077,7 @@ static int ccp_run_sha_cmd(struct ccp_cmd_queue *cmd_q, struct ccp_cmd *cmd)
>  		case CCP_SHA_TYPE_1:
>  		case CCP_SHA_TYPE_224:
>  		case CCP_SHA_TYPE_256:
> +			op.soc = 1;
>  			memcpy(ctx.address + ioffset, init, ctx_size);
>  			break;
>  		default:
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
diff mbox

Patch

diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c
index 50fae44..1a27af3 100644
--- a/drivers/crypto/ccp/ccp-ops.c
+++ b/drivers/crypto/ccp/ccp-ops.c
@@ -1077,6 +1077,7 @@  static int ccp_run_sha_cmd(struct ccp_cmd_queue *cmd_q, struct ccp_cmd *cmd)
 		case CCP_SHA_TYPE_1:
 		case CCP_SHA_TYPE_224:
 		case CCP_SHA_TYPE_256:
+			op.soc = 1;
 			memcpy(ctx.address + ioffset, init, ctx_size);
 			break;
 		default: