From patchwork Thu Feb 9 15:57:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 9564999 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 012D16020C for ; Thu, 9 Feb 2017 15:57:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E3D102855B for ; Thu, 9 Feb 2017 15:57:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D874B2855D; Thu, 9 Feb 2017 15:57:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 599B12855B for ; Thu, 9 Feb 2017 15:57:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752245AbdBIP5a (ORCPT ); Thu, 9 Feb 2017 10:57:30 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:33539 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751818AbdBIP5a (ORCPT ); Thu, 9 Feb 2017 10:57:30 -0500 Received: by mail-pg0-f65.google.com with SMTP id 194so625136pgd.0; Thu, 09 Feb 2017 07:57:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kNFuRwsddzNseTCx9z2tn6IP7b7Nz+NuXCiamaAWYqs=; b=q7cxOISTApM4Hj9FCykssyBMsvWd/abgMiDiP9zveLAx9qHiieWg3TzLwmPSaetfBa Pxi+iYjsO6FXANclSfoGpOjfTMY78UhfB7jLFU3lUKSp6hy7JXAxXH3IaAI3f4ah3loG e5WW7rWRNaqJnoZrcD5tlyqcJrOdeXhRmoytpqvX6nwIa3iDqvU1RqqFU23EYIWtayNy 5FuLZ3CJu1X1PF5Irmv8SLOH9j24D2T4o96Lb3zGpxI+bXosu3HuOYbFRMijSkHA8QhJ xeq4vGDyT34ZkKCmMoNua9ZVOOG0J7V8YXGveX0NYUUflnDrVLDEXJ4UFAXTlpVk93s/ DLMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kNFuRwsddzNseTCx9z2tn6IP7b7Nz+NuXCiamaAWYqs=; b=bgRUuAtwVnOXIgudDQmA//07xI3zb8TNc2e2o8RIpgdxNjpfwrMBhoSTclXaVFHV4Z a4AxlVdnT24PGGVD6FLDoUSJurYpE5ohMbKGmRqBUu52D9UW8oHkb8vTiU6TNLeAeM8Y ofBunJ8oKJUOwGt9cMIuDxKji62aRPFqYNTgtepLBUL7JgH3ad32R71ytzdZKj4ipS6m u4XKFzl83pn5H9nWehybwtMvgnSZorH6INHfwRwpfJAlv9ndetmMmbYjvJ0QChQ9gwZT qL3OKkkmziR6hwUwliagR3SXFlM6c6COLDbnc+zW+CzfsgB0v0X+hs07tPfGFQyD9TOi TEEg== X-Gm-Message-State: AMke39msQYfiFdxvb6Gld2tlzgz24xvDwDt0/GTiq1cPy3+hNxJHLjhkx/4Ju/aZM2/yZQ== X-Received: by 10.84.172.1 with SMTP id m1mr5031740plb.5.1486655849548; Thu, 09 Feb 2017 07:57:29 -0800 (PST) Received: from 192.168.0.37 (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id s64sm30149036pfe.27.2017.02.09.07.57.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Feb 2017 07:57:29 -0800 (PST) From: Wei Yongjun To: David Howells , Herbert Xu Cc: Wei Yongjun , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org Subject: [PATCH -next] crypto: asymmetric_keys - Fix error return code on failure Date: Thu, 9 Feb 2017 15:57:24 +0000 Message-Id: <20170209155724.19737-1-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.9.3 MIME-Version: 1.0 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun Fix to return error code -ENOMEM from the akcipher_request_alloc() error handling case instead of 0. Signed-off-by: Wei Yongjun --- crypto/asymmetric_keys/public_key.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/crypto/asymmetric_keys/public_key.c b/crypto/asymmetric_keys/public_key.c index 3a23274..3131bba 100644 --- a/crypto/asymmetric_keys/public_key.c +++ b/crypto/asymmetric_keys/public_key.c @@ -184,8 +184,10 @@ static int software_key_eds_op(struct kernel_pkey_params *params, return PTR_ERR(tfm); req = akcipher_request_alloc(tfm, GFP_KERNEL); - if (!req) + if (!req) { + ret = -ENOMEM; goto error_free_tfm; + } if (pkey->key_is_private) ret = crypto_akcipher_set_priv_key(tfm, @@ -268,8 +270,10 @@ int public_key_verify_signature(const struct public_key *pkey, return PTR_ERR(tfm); req = akcipher_request_alloc(tfm, GFP_KERNEL); - if (!req) + if (!req) { + ret = -ENOMEM; goto error_free_tfm; + } if (pkey->key_is_private) ret = crypto_akcipher_set_priv_key(tfm,