From patchwork Thu Feb 9 21:49:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gary R Hook X-Patchwork-Id: 9565547 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D23D9601C3 for ; Thu, 9 Feb 2017 21:51:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C44102854A for ; Thu, 9 Feb 2017 21:51:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B932C28553; Thu, 9 Feb 2017 21:51:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1275F28552 for ; Thu, 9 Feb 2017 21:51:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753927AbdBIVv0 (ORCPT ); Thu, 9 Feb 2017 16:51:26 -0500 Received: from mail-cys01nam02on0069.outbound.protection.outlook.com ([104.47.37.69]:51472 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752301AbdBIVvK (ORCPT ); Thu, 9 Feb 2017 16:51:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3ru+bWMEP1L9IDUcEuTnSYvyQG/GcnmleoDVzQgKMKw=; b=npLurAGbhDWvnNyfx1O+ahwUlXHIarOK9v3705dvmKodEHPNzydy1Dk83TbNoKU+hk4wobFJm3uUQlMrguRDebD2a46kHVpLWcYL5IYq4C2l7J60EG8smbg2z/M/T8YaoPU6SG5Bq8WArArDtRotuKk9c+mUvSEbvtPG6OgO/Po= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gary.Hook@amd.com; Received: from [10.236.19.42] (165.204.77.1) by MWHPR12MB1407.namprd12.prod.outlook.com (10.169.206.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.888.16; Thu, 9 Feb 2017 21:50:04 +0000 Subject: [PATCH v2 2/3] crypto: ccp - Update the command queue on errors From: Gary R Hook To: CC: , , Date: Thu, 9 Feb 2017 15:49:57 -0600 Message-ID: <20170209214957.11781.30020.stgit@taos> In-Reply-To: <20170209214704.11781.28640.stgit@taos> References: <20170209214704.11781.28640.stgit@taos> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: DM5PR16CA0044.namprd16.prod.outlook.com (10.172.42.158) To MWHPR12MB1407.namprd12.prod.outlook.com (10.169.206.18) X-MS-Office365-Filtering-Correlation-Id: 9d639111-f537-4410-e016-08d451359b8a X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:MWHPR12MB1407; X-Microsoft-Exchange-Diagnostics: 1; MWHPR12MB1407; 3:Y9HbfbEEAXs/T3+hii14NIlDs/g6KnxltjBF8FHUez44+zOokHsiqxM+nCh+8i355m8/tDAijBYTyEKtbH+Q8i8DATvXH/o25Xtcr2cF2hoP/JkSALI5CZG2fapcRsxEGKZa8BLyfJ2rj/q2AJ3tOUSRgczsPSUKKGYA+q4TeagdWRxRy6I4mb8ReFWhUTh8+9qMIzAWaYqReLvFWpzB7MjVontJDB+MsMeA+GcUnIL8HngBvNvDoF3qGWIFxWwIsy7Kza0QaJnUjP3toxeBiquLVNlIm/Gw7xUmGL7wENA=; 25:nFR8TvtlCjAibW6sTPNyU3E+5JIfBCWs3qJ86tuqBUYdWqX6TxA6GdbS3jQTH5xuH/5T9JSVIqurScQ3gNztSgWKp3ZihnERcw2rAZpp3wKhobJQ2QLITLc+tT4psZOqAAGN+we/mvKO4HdeAVBOsPGOCqB9YPndUykbXyHBjU2p7eHVRG0Awtt2MixwgBSVJn00OU81DAaS8RZr6PDXz0A61wGAmMY55tExn2Xzrb/Zm02eL4xGXsalHHgWZaQUIxLQOslMbz1E6WLF52DK/uIGDSPzWu/GvNuzkRIJT8VHADGfo0X/hhjleW/vW31RelvX7fUrexZLItrAL4JjeNhrMlaqI+q4892D9CkbiHgp2ec9HXcDFn5zjc6CuMDwUlmhuDLwefInKExkbj2NUyb3dtUbPvMM6Fryf1B9xeZBcW8QKv4lDp6T0faBm4nPnP2zwZ443qbjVPhgjgUrUQ== X-Microsoft-Exchange-Diagnostics: 1; MWHPR12MB1407; 31:iKBaySlfqeboS2yBGy2eVbxXZlrDru7oD/hrG8wAORr07mBL3lyYWJirEDL1YvkmZVkf6NepIINkxfdaVxaCQYdpZdo1RCa3lC1Afy+s4Xn2xmQ0UwuiMHtVdP4zPtzblL9I2wflp8OARe0SGhQyJdTuOrAqIyzwc5WsGWGij8mpLUBWxD72o52EsGJ94PwOIght/sI5m/W+zfBidFsHdA935HNqowDB/VCnsZDHGwF4rdHLdJkhW/5BjoTJhm+F; 20:JugZV6+/kYCEhxNBH4DWN0OGwhS6IF3eq3cRpzyBW1q6qProG/W7aMJaC1l2cQ+NQ3x4DFTCgfZdPoWgKMz8uOFYmL5pgxLp1yyaFGyPnwYlndMlNcWb+peYPM7rCns/OdacWfku+wr4xJhjlG7V5RHwtS9i2KJL6IBUtt7Nn7t63hj57O/qteskYdMLWNpRDnSgu2d6nwT+cZqX0I+spfnUuH7MeVvpYBeOj+DJyC2tJOm7Msp7OaPUbZLCvJd4pDOY5bfBTMTWi/S2W0AKrFa2Hs2Nqphmt3aci8Zg+kQbMMlBJjQxffzOm4T33RVwaqspCOsmOa6D3k+i5oizO8uGjNbVHcCVd5OpyU6L6DOffD4rG9bnq4kWP0Z/t6+WWvKzNE1+RRrpihDejIk2w5IEN1A5VxRwCogr9JCFnV6iX7es8OhP8LyLYGuo+jbRtqvwSpEfpSyKXWWH4Wd+BrTIFUiBlyYEDiBR7hiOHi8ePPdDobeXniExKLd/nvE4 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123558025)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(6072148); SRVR:MWHPR12MB1407; BCL:0; PCL:0; RULEID:; SRVR:MWHPR12MB1407; X-Microsoft-Exchange-Diagnostics: 1; MWHPR12MB1407; 4:M4Less1D0w+zAn6K0uFckc7qYQIyjz0S8HR8LGIJDasH06lx+U5Mj2E2heD0QB+/qoqJwbUUdcTX7BprWF92Yw1/3EVUX6q4+Ro8zlMYLMy9kS3IVPjxgCMsH5B19oODgEiu0nb4wRTkHLOgHhWxc9AZRWiyZMWhx1i+TVO5w9rOBBGEnwE4irP0KtTBYIa9g67+EoRh2bbqR5sTvE82ZKuHwPfchGlf942PpQcmOsZwSPO7R1yHqTAalpX8RrxwWcjhHS+N9EvvI3bufSrrpKerLgGQCrrJTQMcgviGHrCb7ls3ofPC8uLW/v5S/hU9oc2y0d5OPRZjaXbagUXdcDXiozvztIDY4uI7ExB7w7KSWLmPaHk1NM4UVAZfdATd3uVxDNwNFFgHbjomnLkI6jxWK+W1iOKNR4ty2kN6uFRjesZYSSsK46ff7jENED//6nu4J660CknuBikdpHRx0Z/l5U++JMaNaktcpFEiwUyQTdVIJhVBFXCOnLh2a8QyzPjJOmdON5Hk9O3TAs8HSo4LKOvBMHuPCZMb29S5u3QyBQ6PxfEgtPsIe0WKK3R4S7xfxwbb2hQ2TFv0t+TNViBlJQCxJjB63SW9L4K5YJRCHnI8ziBqRv30nss2lQfIaAiVjAlpsObuy/Qe2kRuzl4q7Bf+iH3lIUf/44u8YWc= X-Forefront-PRVS: 02135EB356 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(39840400002)(39860400002)(39450400003)(39850400002)(39410400002)(189002)(199003)(9686003)(66066001)(2351001)(105586002)(47776003)(1076002)(3846002)(6116002)(103116003)(106356001)(110136004)(33716001)(54906002)(90366009)(23676002)(6486002)(77096006)(53936002)(38730400002)(25786008)(42186005)(50466002)(92566002)(7736002)(86362001)(2906002)(305945005)(5660300001)(97746001)(83506001)(68736007)(4001350100001)(4326007)(54356999)(81156014)(230700001)(6666003)(6916009)(101416001)(2950100002)(189998001)(8676002)(76176999)(33646002)(50986999)(97736004)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR12MB1407; H:[10.236.19.42]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjEyTUIxNDA3OzIzOmY5Y2ptWUF0dG5RTDI0Sm5KSHhxWHk0aCt0?= =?utf-8?B?QyttY2ZUeDdrSUhndXRGWGE1b3U1VE51VDFnQWdIM1dVNGFna3ljWlVxWVZE?= =?utf-8?B?Mk1nenQ1OHppamxtZXlyTkZwQ05Rc2J2VlNtK1dZTkxEWk4rUUpiUTRSZllm?= =?utf-8?B?YjRudDViSWtlNHhOY3hyakx2N1k1WnZKcW5pYS9sOUJYejJqejM2b2pkK0xZ?= =?utf-8?B?UkJIRUtieWRiV3k4WUZUUlNaekJYcEdTV3E1eXpFRE44UU5DQ3dtazhXUG05?= =?utf-8?B?c0ZnWjJrWW9GUDFYcmJhdFI2dTIybGZqYjhRRTBhRko4dCthanA2eHc2YjJS?= =?utf-8?B?SVJFMk5YeWpzVGlRV0lnYk5VdzdGMTNHYzI4YktkajhLcndMSGRzL1U1eEpG?= =?utf-8?B?MXNYR1VWMDhmeS9oMGJTeHBMelRCV1hxYjlENm45V3JPV25MZ2JKUFVtZWpj?= =?utf-8?B?Q3IrWDE0Y0tZai9TOTVmYTJRT05ZNHMvcTU2bW1kalcxT2NlUkFOZkVDL0li?= =?utf-8?B?dXhEM0dYN0hPK2RjMmZGNmVrMmwxdjN2MENKMWJxK0ZoVkFBNW0veUZqdTNU?= =?utf-8?B?anBESCtGTWxjOVJlYTdkU2NnQUp5VjdRRVlNMEU2SzZBSStxRjlyeHRjd1R3?= =?utf-8?B?RElGS2JrT3QxTmZTNk93MS9MYndXa0JjZGZiMmRaU1FjMDBta1daZ0R6cW96?= =?utf-8?B?MFViaFBOSTZwNXh3eVJnYkxvQzlmT1dZN252bVM1ajR1bVNoRVRiaE94TzRs?= =?utf-8?B?eVhyZDNJdWYzSHNGN2I5ekpMNi8ydmt1MllWNFVIc2RDT2NBNnJYMXI0bHI4?= =?utf-8?B?MjRHcVFzS0szcmFqUWQ5RWxIWjZHUDU3S0tNUDEvditURk12bUFpSnpkaUo3?= =?utf-8?B?eXA2VFhpcGR3UHZXNkRaQW5CbnZGY051bUM5ZzN3VFJjbExUV01vcEFqcFRE?= =?utf-8?B?NHJIT2wzNk85d0hNSjB0MkFmb0xLVkcyM0tCOXd5SmdTWnYxbmgxVXI2S1NE?= =?utf-8?B?UERwUnIxSzhoUEtyTTlBTkdRQUFXT1FlSVV2L0ZFcEN1NVorRzlZYzl6eWY2?= =?utf-8?B?aUN6ZDd0US9URkRPalJiUlhpU2ZvQTFnb09mVjJUcnRxNVpJajJrMjNlcjl3?= =?utf-8?B?WnVXSFFWWXhDRHkzbmhaMDBON0lab2N5Z2ppQkl2bW5udVh0Mm45REJlcGt6?= =?utf-8?B?MkQ3UVM0ZXRpTGV5azAwT1NRQ3pQUGoyeFV1T29UYWZzZ3lYWTNUSWNIUXFY?= =?utf-8?B?SnhveHM0Zld3VHpEZkNvOE9IQXNzY0NlMHozZ1dFQkwrTm1ZNHoxK1VPSDYr?= =?utf-8?B?NGFXdUxub05XQUprQnVzcTg3eU84TnFnUUJxMm16RSsvTVhXWGF2bDhpNVdY?= =?utf-8?B?WmMxSnBUOERyUkxZd09jZkhJU1BXdE5meEFuK1lpbGxVMlppd3NjZldBSEx3?= =?utf-8?B?K3VPS2tVUG1VM25sTitvZ21OcjZkODRyc1dTSFhKSThzQ0xQSGRvWndrYVMx?= =?utf-8?B?VDlvOVRmZ2hFQ0plNkY0a2MrQW1HeG5nMlU3N3IzdmxvN1lsS3c3bFkxUytU?= =?utf-8?B?K1VGWGZCVkV3b2R1MlhhQi9EbEtZWmUrcnk4RERWMTVBekJsWjhkVHRJN0wy?= =?utf-8?B?eE1qUjZqcFRPYndrbWdTWG1WaCtRQ0hHTFprTWZVb0hRTTRqb0NoamJjOHlu?= =?utf-8?B?VmthQkhObHJLUjc5S2pzY1FPejhHcXlGb3FjOFlMTmEyU08yeVhvSVo4emx4?= =?utf-8?B?RmpBWkV1SDZsRzZGa1E0blQzbGJNODUzMFZIOFFRVG9jbTdpbDFXUGIwUmUw?= =?utf-8?B?UkdlTHBDdUNZUSttSjFiTFJNSVdxTTdlWWg3cGNTNEFiVEY1YURkQlkwNGJP?= =?utf-8?Q?DX6/2Pj5KbrQETuYzbLl3ACDrthDH5pQ?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR12MB1407; 6:Dfl3L2rXXkZqbVduDoEbeQ2mZyTEOFkxLg4QAwsyc8ciETrbus66vGdkXJEWu3aaz/kavZhU+eyqTljo7GnsRNFMZXFtZqaS6slLeKZzC2EHXaDcybYDV/Oes+VGrTLq3HULYsBtACfw6Qcyld5dBUIXVsgNa6vEReGLhO+5Cdy7xziNMZBLlVc0YXzeilxZ3YzDlTkpH9p3RC760DF1pCQB87Y8s6dpHUeN3g5lX28c5GziCyeZJ8YBJKb6oe/CvOcOeiqAjZ959G86n0ZGGyjeAgPIlU+6kUzE6xAI13WeYQXLzstABXXHZoR1oXWVXbuGC+64cmYTJbr7odS1I6OZ0y9rc+/ctIFGw1AezutZ8ypSbBj7c5B19CZ9MvJBywPn2BfeP5iMuBCenOBJI8cNFXT/9igfbLfbY42eNqc=; 5:Fig3QgjHPH3ze1eYr7qkU/QFBj044+BMvXfGpZkOM/vOVvUnouqfH3nPftPN0oN6WF0QLtAG0tO3iyRqUqUkxaX5R9MStDfk/ZZPMxp6Mxp0lMQTOEV7MlChVIrppVS/u4sJX2bykZqwiZhuzYdBtw==; 24:EbC/l7uHy19QUKhyJTxDVPrYYckG6J6ZEJtr4kyl3YwtGYKbpDzckCAnytzj26v6+g3WMOLNB/Fwiwz5gmZDWs6ifpeJ/k/F8HKDftUShNc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; MWHPR12MB1407; 7:mzY9MhVoEAm4cqBmanCsrA5zt1KHnRMs0QllxFT+3FX+MrJ9iTZzqIk3j0hRkKoOlDHw6kPkxuMFzBX8jXmhLWBqm2OnchL3A/ib8Mv5rRCA0Jxrrkde5JqJzQ12gm5aakzHhGNP0egh1/OYrx4VtsZAeq4NPXCa5qKDcCjAmgEWmQPfKA8+cl8BP+fhJv5qxW0x4e7lrTa6cGl4KRKKUGMWWiHMODNqLXSCULVqP/YeZkXmVp/L3ELwY+knVrZQRCKW+b1ve25wwTmo5h7AVynuDjF5ekMdQvqiEq+YNf7kHSRJK3cBO1K2opFP5Za2Fc0+4aOeiynqm8h7DCFWEQ+5VnUz5Cyi08S3gmzfSdyqOPHlQyytMcENyvAmAtFW1iMPGls31sZNcXod22tmk55/NtTNyvwgE5x6urSDCmkOL/o9lzTClbUMa52M+3k10rhJv/SN9R7UzkDW9ne+4dkVzzcMlabMusGKKixHJZTvvH1oxJEM8VCJkWkrTnGvlcEvoHHMnjKFCmrppb359Q==; 20:7d506tnZU3WdEgdqe/ifymJ/+pzXWeCffqlD9zWMUyTJeQwbnhDtYnuvQX1d1GYC2VQz9KN/t5pBes0Vi0YE9d6wFb68k8AleSyyY0luiQprGlpcy+PL6plgQ6WdFw7L/DR16HD3C4AzJ/sfyzbwmzexwCUe6qYAgW7bcqeusZ4trOTdYIgJni402rJ1fmPJY5vL+FYfnm0ZD9DiMZbAwQYCUM5/OfsN7c6ucX4Tv4s7/8afL6QVe1lO/gubqDuD X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2017 21:50:04.7306 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1407 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Move the command queue tail pointer when an error is detected. Always return the error. Signed-off-by: Gary R Hook --- drivers/crypto/ccp/ccp-dev-v5.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ccp/ccp-dev-v5.c b/drivers/crypto/ccp/ccp-dev-v5.c index 5fb6c8c..d9e1876 100644 --- a/drivers/crypto/ccp/ccp-dev-v5.c +++ b/drivers/crypto/ccp/ccp-dev-v5.c @@ -250,17 +250,20 @@ static int ccp5_do_cmd(struct ccp5_desc *desc, ret = wait_event_interruptible(cmd_q->int_queue, cmd_q->int_rcvd); if (ret || cmd_q->cmd_error) { + /* Log the error and flush the queue by + * moving the head pointer + */ if (cmd_q->cmd_error) ccp_log_error(cmd_q->ccp, cmd_q->cmd_error); - /* A version 5 device doesn't use Job IDs... */ + iowrite32(tail, cmd_q->reg_head_lo); if (!ret) ret = -EIO; } cmd_q->int_rcvd = 0; } - return 0; + return ret; } static int ccp5_perform_aes(struct ccp_op *op)