From patchwork Mon Apr 3 15:30:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Horia Geanta X-Patchwork-Id: 9659777 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AEDE360352 for ; Mon, 3 Apr 2017 15:31:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9F47E281B7 for ; Mon, 3 Apr 2017 15:31:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 92E472846A; Mon, 3 Apr 2017 15:31:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 25B2F281B7 for ; Mon, 3 Apr 2017 15:31:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752579AbdDCPbA (ORCPT ); Mon, 3 Apr 2017 11:31:00 -0400 Received: from mail-bl2nam02on0049.outbound.protection.outlook.com ([104.47.38.49]:35424 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752367AbdDCPa7 (ORCPT ); Mon, 3 Apr 2017 11:30:59 -0400 Received: from BLUPR0301CA0014.namprd03.prod.outlook.com (10.162.113.152) by DM2PR03MB397.namprd03.prod.outlook.com (10.141.84.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10; Mon, 3 Apr 2017 15:30:49 +0000 Received: from BL2FFO11FD042.protection.gbl (2a01:111:f400:7c09::148) by BLUPR0301CA0014.outlook.office365.com (2a01:111:e400:5259::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10 via Frontend Transport; Mon, 3 Apr 2017 15:30:49 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD042.mail.protection.outlook.com (10.173.161.138) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1005.5 via Frontend Transport; Mon, 3 Apr 2017 15:30:49 +0000 Received: from enigma.ea.freescale.net (enigma.ea.freescale.net [10.171.77.120]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v33FUkHM021136; Mon, 3 Apr 2017 08:30:47 -0700 From: =?UTF-8?q?Horia=20Geant=C4=83?= To: Herbert Xu CC: "David S. Miller" , , Dan Douglass Subject: [PATCH] crypto: caam - fix invalid dereference in caam_rsa_init_tfm() Date: Mon, 3 Apr 2017 18:30:07 +0300 Message-ID: <20170403153007.30455-1-horia.geanta@nxp.com> X-Mailer: git-send-email 2.12.0.264.gd6db3f216544 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131357070494569127; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39850400002)(39380400002)(39840400002)(39860400002)(39410400002)(39400400002)(39450400003)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(9170700003)(110136004)(38730400002)(50466002)(189998001)(36756003)(85426001)(6666003)(86362001)(47776003)(104016004)(33646002)(53936002)(4326008)(8936002)(8676002)(23676002)(50226002)(81166006)(5660300001)(2870700001)(2906002)(6916009)(305945005)(106466001)(105606002)(356003)(54906002)(50986999)(8656002)(77096006)(5820100001)(1076002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR03MB397; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; A:1; MX:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD042; 1:/hBJtnK9S6nEMXxiztgacP0Gxl0XHXNl7ac6R29PQC3Cs2vKIW5BUrMoqGCpI3DdEDja+ahQa+hDnJ+0Z86BcgJZBKgCmq+MYI2PasSloSdVTIR/HrNXsRYnwJ4VZksxHGoxXUo1DtFj7jg0ZSHcU/J12ShsCp8ndYkIsOn2VbmFgiBemx9yPIKT4Y6w563oAYCIju+alwPoEke2aRW7gxy+bjRINCxhUtap1L98tSciIDevNUrvHZ8+TRWYkaWvr0rPJkhcBr18ZydmZWZJpChblrWYN1xD3F9I4pITx5UkvdjSQ4Z5tbhcpAp/YKSDlYTJ9B34OsOj/eZZXkfGr8idXcKMBs5i88realsU0H3uA4EA9GJWWF8TL1W5VPGyueiqgSl8xcPXgLwVrkrUFnWDWQJ2AVQpAtATzEYCDnnB7w8DecHNATtO6mvP+LbP7itgkVJmHaVSHNR98bZbAn95GGixxQFQYTd0iVPAVkyA2mxomN+scvk3FbQixERnFKRbLov1CxvLX19UGyu/ZL02PEsSMJZQ/PFEbeg01f740vdNnPmViAuOXCyaJDxN2u0H0kmBKAgoV6xoaC1ByoHddlF2ww9f3sIYj2VMMZiuKbW1B6ihztjaY5LeS1TjzZH3s9jp1D3H1CeD2McdRxtzCNlQIlOY1MVU9hfsv1isHyu4hAUVlyss/NSlKiX7uYhSk/Du5MMxLLJOqLe/SefF2TiX7hH11r+vdTmrJRg= X-MS-Office365-Filtering-Correlation-Id: f2d69136-2db4-4d97-92a7-08d47aa66807 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030255075)(201703131430075)(201703131517081); SRVR:DM2PR03MB397; X-Microsoft-Exchange-Diagnostics: 1; DM2PR03MB397; 3:RlkG3FLS6FdQT7nTtFpy9Ip0r4tq+mIBf/O8ZJSSMLjbfmTpdwvC7oKTM3yurOQSrZdI+1K0LVE1qU+CWxyeUDCAimdMlNRVzhjh7fPNz6kCqx3JX0LeadoPEW5Rij6zpDtdktCxhuJfqxGHhFyB9jaCIEiLOUSUysnJI859pSoqmPn7tOdIjGxC9tRuS8pwElbtnrJH0dgEgrMKJ7PA1ZPPVCGXS0K4MIG2zw4UXUYJ9jQaoUr04tAmJIyAVfpjwtaqiFAwBIcCwbAhK1ishfJO5Umcx3uim2rNl29jceuEo46rU2Kn7VwxwRddh+7y1gbPG3Gcqq5ZKmIeZz9Of3wAhGgxHjE+dh+FI+k3fCKpt1ruUVXGptetE12o0M2cqnw0PQggZa1osEzXSWDrdlZSBrWsItHO2b3QkFcBe2IWSq/CaRIDPXLK9vVeqE58ibU6FfxTvaJuTVaj9hqTIw==; 25:tvVuCc8IJwAxgTM5f55UVxdLyT0tIaFZxuKUJVQVdSCPFDxPpUagt1Gbv93I0rfQaZlllhpdTv8qPRgYj8zcGvNhTm62IrF/ot+Pcu8PSzpk5HWv38P1fHMAOa3fWY0pXxhy2kvDluHivm+jw+Wllwns8ewb7Gzs0iAvJQdDO72tfOLE7z5DJxNW+Ipu0AkALU2GZy3vFcujHQiCIX3bxX5zy1rZC1v16OrQsVk2RofZZ200LJct3mNoIDL9l8/RYskEJYXEjO9p1LpAtGWTsw4Xz1NejKQ4qNWhmc8CnktNJ1xOq27FdhTrlBtDbJ+LoUFDklube1tMYxHOL1FjK+JOMjpJ44PlQJhV6dE/QRZ9EQEF2WIqiGw9skg+yKQLs8E6nOy+itBSX2bjakMdUD/+00RhByCeUEHpJjqMRCziTQaZx2qukaRb/LeOnYrbFcYI+qgS00SRyw8 qhEBVJw== X-Microsoft-Exchange-Diagnostics: 1; DM2PR03MB397; 31:oBu/eAL149TtFJ+s1sBjEOqDb6QHxaEA00/EwnN5f4Z6cxUVZ4nY2Fx652X93LiYmgegvi3NQRIPO0DcEt71tCUmK5ojoSjlFZb3/IEYREK9S/4hfRQhKHw21LkL84Cz94L4sBUP1PTHmT3zQlY25yyQq24YJ6e6GTYjKaRD8H/dcoD1ujA7tbScHzoyPZsLWVXmAVTAD7hHMexV3RUg7GgObkpHCWyONK9UH+sbzHOu2Oakd8e7GrsdiE3J3jDPrTIFmzN+XpS4GgkB/SQYDg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(601004)(2401047)(5005006)(8121501046)(13017025)(13015025)(13018025)(13024025)(13023025)(93006095)(93001095)(10201501046)(3002001)(6055026)(6096035)(201703131430075)(201703131448075)(201703131433075)(201703161259075)(20161123563025)(20161123556025)(20161123561025)(20161123565025); SRVR:DM2PR03MB397; BCL:0; PCL:0; RULEID:(400006); SRVR:DM2PR03MB397; X-Microsoft-Exchange-Diagnostics: 1; DM2PR03MB397; 4:+sDp3sAa2WuTh81rNQ1lmnt0ODuXd6lTnQ7u3QWYKhm1mJDkxCPPH7gYeibjqYZdpXzi6FCB+GW3EKl4QRUykehhsrTAk8Gyr9V5u1QoU5r6XoQqf/4mOzhP3Xw3+Yn8o68ouZPt2Wd8dysYFPKZ2HDEUm/ed20SwDqahQnB6n6qMv1anUHb+uXTdjqjlwjW5p94SWSLVbeWUY/Y3qMCA+QHXRfQ5dXKSdrayW/6GDuNJULyIo4PiquZ4NaLUx+7tVriOPGIphedTy7KvqLCdrRxjy0gHfdO8mJoVekxvyVSx+6nduHHjZCnknPOI5+tDX8Wmmk23vPCoDC7RDQbbNPxKJCaBplHPtmLn63AjwwMG6n/BIPJgPQ5ZwHu3kw9ArCCuu3Y74a0wmVWU1fl6aLplx006jLGpS6leNbd+13Tay4UctaciZVmSaYrqWIPYv3GAUr1DaIi/HVbYNimSZeQuEc+adN8ratJqw1P9FN9GNtVsaEfFhk1jUTC3VxTjiZmZGV9NpA6PIMMVagUivU0muqrTethquaIOssK5i0d7Xc1fQzEeG0g3Dg2vIsijYNl8QopussEiQhrK7YMzn0GTkzftTlYJL1F1C6dnvFlOfFzLI8zk1lyYeWdl0652YRA/agFdgCC+y/jmTFuRszQxKicUdXw4Ysa5mrv2m8IMgNQQ0lMltUs3DF4lCdWdqKcJLAI5OLoDO6qEpW2e7XSRLMYoi2knpGxR85gtPTC290U4ShdS/CGfLW1tb/24St6K/SlMuUVXYhPhx2NrgaJ7iwdd71jj/qTgDk+rxB3U+HmHoX/oiBTTBNt4qcSHTzSClJGIpDdRXzNmgTFr5/gY6PuHmnLStoVcSJuvWL34nHjZs5Q0YenankoX13HTmtmXnJQcLpPL5APNDVYeMxcPF0RSj1CZYlh8viMsto = X-Forefront-PRVS: 0266491E90 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjAzTUIzOTc7MjM6NjJSNnpRRlVXazNicmd5OU9XQm8wYjFYbTc2?= =?utf-8?B?VTFYaHdtaVJ2aXJqQWViZnpaNFR4ekdXcFdyV1RyVVdoTlFrSUM5bjlaeVJ6?= =?utf-8?B?ZjBVVWp1ekN4MkZVRVRyMHAyWTExSENHdkhWd1JUbm5GcEQ2Yk1zMlloTzRO?= =?utf-8?B?ZldqV1grSUxKMlBuRmJ4dmJBTWRCRXBCNnd2YUFoMVZtbk5wVjZ4VjVOb0Nn?= =?utf-8?B?WFpMTUx4OWhJRTVzR1MyL3JkZ3lJZk1uOERabHNUZ21vZlVEZHJkYWlzM1ow?= =?utf-8?B?VFU0ZW9tNGdHNkg4VzVJY3hNT1QrVUlJczA4d0NDbi84VGVUTUk1aGw5elI4?= =?utf-8?B?VHlRc2dSNXpJS0FHTTlpcWFHcjhJMlpDeDdEMENtNFZOcG16SW5yREp5KzM5?= =?utf-8?B?ekdrQllqbnZyNG55a0d4S0FBdXZIZDBpd3VKQk1OZHBCblVGNkRmUDJWOUZS?= =?utf-8?B?TDZHWHlmRU5zeHV0US9GVFgybEZvSmZ1d3FCVklDeU15OFZrcHdDSDV2bW5J?= =?utf-8?B?Z2hic2ZYeWRNbXcwWXYwMmoyaC9GbUFWS0FmNVcwZ2lsQXF4YXR0TEs3M0Yv?= =?utf-8?B?Z2hrSWVNUkxYRWZ3YStmdzZsdHo1N25iWFhIVTJRbWNFWnA3Qk5xaGdIVXFY?= =?utf-8?B?K2I1WWpXVVJDWTFIb3JpUTY1akNHRjdoSUtXcHkrRENwR1AzMmVoZ0k3dE1J?= =?utf-8?B?alZjMHVpcHpuaUZXNlhTUTMxSXdjaUFtb04zL21zQ2ZNZU9vZ3R1Ty9VMVg4?= =?utf-8?B?Z2lobmlFUkpTZ2ppa1hjalIyNjRTaVZKMEovSWUzODNwcUJPZlpmZ29ES0NY?= =?utf-8?B?Ly9ZcnlCZFpsNHZ0b0pLMXo4QnNnWnFUM0ZBS0JHUktRS0thRXdtVWJHWjI0?= =?utf-8?B?Y1VhSmt2ZkFCODA5ODI3MVFEWiszeGE5bFBhbGtBdS9BVEtrZElvelpJa3Vl?= =?utf-8?B?WDBGUFE3VFVTOFNjdjE5cXBtWWR4Tk4yeHowU3lXbFVuZkxyVFEvWDhtVUU5?= =?utf-8?B?RWJvOGNMUS9SNUJuWVFtWUM1OHdxNElBVlF3N3F0MlkrN3JJOTFDaHRVaTlN?= =?utf-8?B?T1F4OS9VT2E5ZFdyMnp1WGFUZ3BubEo3OTVmYzZWbTlTQmREbUZnRXc0NTNr?= =?utf-8?B?SWdObjJXdUNMaVYxbDdLUENPT2w1elZTMm5FVnpJUnJ1RnhWY0Qza3pMbHpU?= =?utf-8?B?cm5vajhkZXBWbi9EM3J4YWN3ekgzMXZiMS9vbTRIVmhoRlBkT241OHJ2TWdL?= =?utf-8?B?a1ZITDZuNjFBQmlIK05jV2lQWERqcU1QUGtyditXVWRuQWp4UXRsNVlqb2d4?= =?utf-8?B?dlFDQlJvUmhIaklEdlA3citrVm85cU8zd3dWbmpNS0hxdkZSWDQ1ckdKbXhB?= =?utf-8?B?ZkZBVnIzNENNS1BqVUJtZEdhaktTRE8yamY0SWRjT0xPTUJ1cnIyQXVNL1Ur?= =?utf-8?B?NjZDREhMS1RXR2htUVhVMGNpUDB0SDNyL0QrUHZvWG43SktKN2JRMWtVZDlw?= =?utf-8?B?dXZsdWFZSGxRaGNEM2R4WU1XS2NFaXE4L1ZPVDBPSDJrakFLSUQ5NUN4R0xE?= =?utf-8?Q?Cp10Dwy9Atgb6RYreZgqz6Zl7cfRnBHqaPRjXXARDrY=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR03MB397; 6:CAEsAlxtoQchQ3ejIsihC4SXSDqrtVNZ+bHghWF+cpXg64CXACQFw87WCaxPOpkrh9M3yTmZQXmcypQGwhKoGn4cMo0+SFI9W6/wNOBbWjtipNWbsIczg/5kwyF4c8O7zyS7tt9T3XKueTuE8qeTzCIo04cAelr2tisfxFmEa8r6jYoB6SQQnair87isoDPeE9C9BjpQMr1888A/qed5pshhwUlMmAnGrOj0Km58zUow2h4qFks7+dL9vIRsVAU0j/ZQHLhqZvSww0kXBS5IIJX37m8Pn0Wz9y/KmCZzShyMjVF6Elt505b384FPhI1iEg3nWxp1npG/iljUK5hrbxyBrsCA1Bo7Czwsgv7Za2parUOQJX2oeoB9Vzkw3oKVC4TvMeAE6BT30BN2yparnA==; 5:mILjQIgYXKF/an/jkS7m+5IeCb74iqLgr0+0R52V6qO5c+c4XdcsTsMjQypRUxhYb0OmzrpHwazy+I1IDphMU631M6gIg4wb800j8n/DwsPZEOhqP8de3TMYGju9OplBWiCnyz27Iwief8XK+5iCWzPK/eA/egqGKbo62ntnlytCzzGSZSzPEjLCWa75ydy6; 24:O0WxaEV819ZL4AvN02FHxF0jju5kARMsq4FAWQXvjdgpqZcqov8Nue40bMBmmfXzuizhutJprMB/l6wRGcdA4H55fllMGG5NcV8UJZxoz18= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM2PR03MB397; 7:qn8V3oHIICRdo49GKLYmFcflhR92j7roQPLMLQwa0P32mu+wsOs5DUT9DBLy74VaJm7i+chGEVq44lPg7vd18ap2N9ImQqSQny5cwVc57B4ktBQjJ/ohWEWUysoJUnGt59F1d1lowYbRRWjonfPOVPjdvFHv6pUv5UWUR5qTTc23tx4Er6nJe2JnOZpu52BUBzHR6MKS667IMzdtBl4bk7UttEThZzagYXVvbkyrgPZWbr/QgVf9pg4xEE6tFrb6D8/UwAbn1P8ACGlbKpMWcvVJ1Lm9zKICjC54yfNsWPQ/Gh70icEuB+1YVPrRS8WI6I62GhOjqVlVOTaxdszkuw== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2017 15:30:49.2853 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR03MB397 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In case caam_jr_alloc() fails, ctx->dev carries the error code, thus accessing it with dev_err() is incorrect. Cc: # 4.8+ Fixes: 8c419778ab57e ("crypto: caam - add support for RSA algorithm") Signed-off-by: Horia Geantă --- drivers/crypto/caam/caampkc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/caam/caampkc.c b/drivers/crypto/caam/caampkc.c index 32100c4851dd..49cbdcba7883 100644 --- a/drivers/crypto/caam/caampkc.c +++ b/drivers/crypto/caam/caampkc.c @@ -506,7 +506,7 @@ static int caam_rsa_init_tfm(struct crypto_akcipher *tfm) ctx->dev = caam_jr_alloc(); if (IS_ERR(ctx->dev)) { - dev_err(ctx->dev, "Job Ring Device allocation for transform failed\n"); + pr_err("Job Ring Device allocation for transform failed\n"); return PTR_ERR(ctx->dev); }