From patchwork Wed Apr 5 08:41:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Horia Geanta X-Patchwork-Id: 9663259 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5FC62602B8 for ; Wed, 5 Apr 2017 08:42:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5747F283BA for ; Wed, 5 Apr 2017 08:42:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4BF942858C; Wed, 5 Apr 2017 08:42:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 99D04283BA for ; Wed, 5 Apr 2017 08:42:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932200AbdDEIlr (ORCPT ); Wed, 5 Apr 2017 04:41:47 -0400 Received: from mail-bl2nam02on0062.outbound.protection.outlook.com ([104.47.38.62]:57103 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753993AbdDEIl2 (ORCPT ); Wed, 5 Apr 2017 04:41:28 -0400 Received: from BN6PR03CA0080.namprd03.prod.outlook.com (10.164.122.146) by BL2PR03MB273.namprd03.prod.outlook.com (10.255.231.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.17; Wed, 5 Apr 2017 08:41:27 +0000 Received: from BL2FFO11FD049.protection.gbl (2a01:111:f400:7c09::150) by BN6PR03CA0080.outlook.office365.com (2603:10b6:405:6f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.17 via Frontend Transport; Wed, 5 Apr 2017 08:41:26 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD049.mail.protection.outlook.com (10.173.161.211) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1005.5 via Frontend Transport; Wed, 5 Apr 2017 08:41:26 +0000 Received: from enigma.ea.freescale.net (enigma.ea.freescale.net [10.171.77.120]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v358fNJ2015550; Wed, 5 Apr 2017 01:41:24 -0700 From: =?UTF-8?q?Horia=20Geant=C4=83?= To: Herbert Xu CC: "David S. Miller" , , Dan Douglass , Alexandru Porosanu Subject: [PATCH] crypto: caam - fix RNG deinstantiation error checking Date: Wed, 5 Apr 2017 11:41:03 +0300 Message-ID: <20170405084103.19053-1-horia.geanta@nxp.com> X-Mailer: git-send-email 2.12.0.264.gd6db3f216544 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131358552868412941; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39850400002)(39400400002)(39450400003)(39840400002)(39410400002)(39860400002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(9170700003)(85426001)(105606002)(50986999)(5660300001)(86362001)(106466001)(33646002)(189998001)(5820100001)(81166006)(50466002)(47776003)(8676002)(1076002)(110136004)(38730400002)(305945005)(36756003)(8936002)(23676002)(50226002)(53936002)(54906002)(6666003)(6916009)(104016004)(4326008)(2906002)(8656002)(77096006)(2870700001)(356003); DIR:OUT; SFP:1101; SCL:1; SRVR:BL2PR03MB273; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; MX:1; A:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD049; 1:85M2fZmQo3hU4SJUUZJEkAH/Hq2NQIkcl0U/pG9gy22ayZP4icW2Ri2o39N2/NIYOtubf7ESq2R3YqmScHTR6Vzge6zYnYX8sTM3HZK2Vccqz5TrJEm/C8WO4ZQ5BjGq4TAXOOcRB9duGTRmLdT9JTuOsZctoshNr0Cl80quW6VNDCkXRd5C9EAt1MO6jIy/f6aNcYhITLrYUyGOXxrdMMaXaGtyIxbawsE32/yknc4oSHOFNozOQJ+aQTQsgaQPkZZ/A04IRENXxbU8arx5cLjavBeaExgRAKOwWtkOEuPdBILV62ZIC0cOg6yR1OEb5tJwmJk17P6WmioLaXIshWhCxNzSKCTxz6sY4kSyXaQAEviPlNGJI/Pi7tVfbQk112Dzwh4xffb1THnX0DzkwNw9cBfp5TO5Jn/k72/Kn0InZOs4WmMY840opGnU9os+2p5S/od2l2xs8ja/TFkVq9WoR5lUCMcdm7Izdo2OH/G5FoLM4uNEPLfGll1d0KXJsy4IXGt/LrqOplaQoz+V3sBQ4/YIWhCO2E4E2SS7pycg6WoD7n9rMRtiOwKoLFSHkl34+grv4CSr70ZtIparj6oyxAJF/NAK6v+InCIqPyrBJ5pWvGRTMmh0PKO/VnQvF+lu2WWiAB39nFL9MbnQNmD2IKUGeZCOg60NiXtE6P4Vj39jqJO+mWUucM5Z4jG/hcDQT7VNs+8/WrXlOK+/9S7sja/N/nXbJ+3PvVCW7b0= X-MS-Office365-Filtering-Correlation-Id: 1b078321-fc32-483c-fcae-08d47bff8c62 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131430075)(201703131517081); SRVR:BL2PR03MB273; X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB273; 3:DQVVbN/1u6d4RNqPqzwsDdvlyvMUN6PSZ5ZexaOVb5ngLLAL9J9GTaWQ4HI3dRQ4A/u959H4B61/I5MKiP1RQxuqqYrDgvt+B/pflbWMmNOfTGYzpbIGpciayk8Tp7z+fnMmHVw8XUNuHCkKsvnJwQ9eNGIIgeXTg/Txk3yTcfCdAk0HGtsf5E6NPwJK/Y3p0FSVSjUHGJc1OFQjGj96tYqSJgZ1AG7QOX4fOCddeyIAmm1OnPS1dQx0EPl80/7ZQBP03cu/+kzO9sIfzEGZZDjWxQ0QG6lV2kHQalZ7s7ecBloQ7keursNkYE4p8jModMGyxI0hreUdXX0tpN0/mD1AGUG5b23dXtUmDmTzR3mDXNq3A63CcAN+BYuDESh2sUCVsK4pWZrlOJnbPfJFjp72jrmLUYpZsw7wwqkwBsF8Ajw7sq+x2oyp+ggt/2B8; 25:qctoVgdbTpoVFZ8Mc1+WdXKaNFIhCx03C1rLvcTiRcM5ACK0QpE4p+kEo2/3TgNFDHUncpZd1uU9QE0EcpHfpQ6ZCjUesmQMYzJUD+TKwDTBDZOFwIVNb3vXwRl8d+7IHxeQ+JKL610btk9UP56FrOKJMJxcs76/7oMvdiUMY9LabCvqi9xMOQyrLdKIEfmMvVKjlaT7I2h7XqTVvryCclgAj3q2trysC5GWH/7zsLNxxsQRfxi6qR2SNzWvQsmFmqVjxU4B2ME84jqPZUX0mIlpDPe2QKMNNymvj8PDJqCEyh1jOFaN30z2Q/YCcyjo/IN+LpRAHKQhywSYQBljYFfSIdJO0UFEB452Y0lVIHJWTqy1tFqrwqSmATgVZZ/mHM5V1WfAuGY1ZUjzPbm9OB0zeQ1PpCNFwJtPW0EODfXFqbSRk5DgBggQGwgExGmqHSKVWM4w/xaZTlvwXNXNtA== X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB273; 31:RwsXQMQCbno8/qUKbfOGeUA+kRU4EpPOx4mIc/B+XBgkOA48RtPQYNW+VWVaJn88AKi75cNnrIUdrimRjUdNNfwPl3C7sGH63s56pDB4VkVKLF0Ro56sgEUYhuAwjKvnAV3TVzDNeYSjvDbTkTI14tayvIYIq+xCsCiq53uO3UhXo8T28WAD7ZfTXhcztjyEzq2qlVMoA+s27l54TO0rtxTTQCir3VCc2sUY/eSrWnGhKK06FGgzjP2PHOwc/xlQtKVWndlRL2WcLhSTSkXlKQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(601004)(2401047)(8121501046)(5005006)(13024025)(13017025)(13015025)(13023025)(13018025)(93006095)(93001095)(10201501046)(3002001)(6055026)(6096035)(20161123565025)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259075)(20161123561025)(20161123563025)(20161123556025); SRVR:BL2PR03MB273; BCL:0; PCL:0; RULEID:(400006); SRVR:BL2PR03MB273; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTDJQUjAzTUIyNzM7NDpqNDF0Z1dYTzRnZGxRbUp5ZFRuN1VBQkEvKzBy?= =?utf-8?B?UUFqT0grWGQvU3c4bHRGQXl1QnZ6V2s5M2lPWVdnV1lVdk9uOGtmS2RMUFU5?= =?utf-8?B?N2dKS00yT2ZqcmsxbjRnRmgrM1lzaVgybTlTWkhGcU90c3BTZXBVNmlCeUU2?= =?utf-8?B?eGdERCtFMjVMV2FhV3JYamhOeEU4OURxeWZpYjdFbEZnbG93NzJ5bmtONU92?= =?utf-8?B?ZGdHekFVZEw0dFBabHBOWHlRQkIzYnRVZ2pHNUtOMms4bTY2eVZVK0IxeHNO?= =?utf-8?B?V3BHblg4dHBsNHZBM3FFVERUbkp1WHljRnBZdFNMVkpmNG9RQWJLbTRxVFVC?= =?utf-8?B?TVFWbXBZalpyUDY4NlJYRnBCbFlJWC9yOGxSK2VIRW9DT1ByRmNYVmw3Q3ND?= =?utf-8?B?VUxrRHRRaEFUbXo2dVlHa280Qld2RC9GYlVjR2NOK0kxaGdQL05EaUYxZlV3?= =?utf-8?B?WTdJNS9HVlNtZVg1MUpzQ0pIZDFyeW5kL1R4TVArNk0zWmxBRjY3Yk8vd2xZ?= =?utf-8?B?eEFaMmJZbUlHM2tFSlI4R0pPZ2xvUkZ0UHpqZFRsTXFZT1NFYll6VElMMm4w?= =?utf-8?B?YzdGb3lRdFpPVTAxb1hrOERKOURQL1dIOGlyN2dJTGlTSVF3cE1Kd0FOYWRr?= =?utf-8?B?K3F4UG9XUXR4akRKVnZrS1JYbzZPRmdsUjU2eGoyS1U2WitIY3AxUVY1OGpl?= =?utf-8?B?S25nT1hLYlJOUmJVMW9tSFdEU3NDMmxMRm9zMmpmbU5lNjVzdGVmcHFFVzF6?= =?utf-8?B?UlRDdjFxVFBneGpxQjRkZC80UnhqcEdBakxCNTdUQ2xVbFlQb1ViT3lNSXlz?= =?utf-8?B?UVpIL293YkMyOHlYMzRZNk5uVFJOSHY0QkxHbENYakRhVHBXM2ErYkQ0Y3kv?= =?utf-8?B?aXlicWE1NnNreHluMlV6WDhxc0hDTXlOUmN4dlNMcjN5bUdScmlwdDFhSlFm?= =?utf-8?B?MExWbHhBMHVLTkN2VXFycGlaV2VlSmprU05BMTR0RllWWUpjenNqUUI2Y0Nu?= =?utf-8?B?alhYd2h6SlhmdU1qS3FvbURhZnpna2x3Ukk1aS9mZE9CdGtpU1dwNVdEcFZH?= =?utf-8?B?L1IvbzBVeGdrYkpYVmoyaW55RFpzT2V0Ui8wMTNjVXRFcmc2NkF6eFRtbHBT?= =?utf-8?B?d3VrYU1qZVVPVjVYeHVHZ1Fhc0FxNUYvUzlJVWE0MStaOHJ0OG9rckNjempZ?= =?utf-8?B?MjJ6SjUrQTVjMXZ6TkM2THIwT1VtajJCTEQ5YXE1SHZwaFdIaURuOXBEUWpr?= =?utf-8?B?bFFzdHNXQmhHZU8wSkZEZVBWc2c2NldsT2l4WjdSQzdlQUh2ZW5mKzNjMVYz?= =?utf-8?B?WGJuT3NqclRnPT0=?= X-Forefront-PRVS: 0268246AE7 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTDJQUjAzTUIyNzM7MjM6MmJ4cGhJUm55V3I4cHdaZ3VjTmltSDhEWVBJ?= =?utf-8?B?TkFVNU0zcUdVbmZKTC9EU1Uva3JnbXZCTXhHWlRaa3l3MU5kRVlaVlJQQzVq?= =?utf-8?B?d3lySTk3K0Rndzg2MklEQUpoc0puRFJxTlFmaWwxU29pc3JTeVl2ZzhsWFF3?= =?utf-8?B?T1NueEI4UjVZU2RZbDFaVmpZd3dXZXVWTzlMMjIzbzg3K0Q1bWM4SWNKT3dz?= =?utf-8?B?ZjFwZWxydmFrclgveWRQU1JHcGswUTU3UzB3ckovYmtQbTlldkRHTmpTTlVX?= =?utf-8?B?QTQ0TUFYalhLZ0VBSUZ0OVlpYkpJblJ4dlR6T2xEY041UHgvMGVSaDJDSjlZ?= =?utf-8?B?K0kvVXZoUUlTc2ZNODZKY1dNK2F0czZOQWkxdTVaaTVDYTJjLzI4SVlwVE9F?= =?utf-8?B?NUltWXgyc3U1c2NSSUlVak1OWnBJZXVoTEsvQm1rbE92VkIrcWFhWERsMVF5?= =?utf-8?B?TGt4a0JrM3ZyZ2lpa1hLRDV2UTZ1TzJVU1lWUXlFM0QzeW0zbmUwSlZHTE14?= =?utf-8?B?NE9EUEdJdVFVQzI4ckZJV1dzb2ZJOHRWbWw3V2NxZXVHUlprVWFsQ0xGcy9I?= =?utf-8?B?SytPVFBtZFhGOTU1MytVVFd4VWVNWnh4TyttclFTeEpnSm43cFB4RC94a0ZZ?= =?utf-8?B?a2R5bGFsTjU4SzQwbnZ2NUMvZiswMEpqUlJuc2ZXNFkvaFUxVGNDTnNKbnky?= =?utf-8?B?eVdWS3B1MlFHTWVUakI5RWI3UURHNUh3SWF3V01oVVNvQ2RrSE5oaG9QbFBZ?= =?utf-8?B?eXdUVFA2MmN4SkdPREljKzh5UmdTcUlneHZrT1FvQkNBU1VKZkQydWV6TUQ0?= =?utf-8?B?ZFlKSDk1SEJ3eWw1Z3BORXJHQzlIUjZPaUltZ2puRHJ2em9RMkpWbEYxY2Rw?= =?utf-8?B?U0svNTNNMzNDbnR0blltd0lESThnTFZ3ZnBiSTBtL2lzMXlOVHkyMmg0aVox?= =?utf-8?B?VEV4WjloeWdHdWlyMUZVL0NkQ3RmMHgydjlCcVB2WVFucFgrdW5kZFQ4blRW?= =?utf-8?B?WmV6bUxiVDFDSG4zeEtVTVpoTFVrNWx2YXhuTG5yYkUzUGk0VHJuVFFYUnNY?= =?utf-8?B?OWR3L1lUa1llbHAzTDJMN0Y5K2V3c0kzRXRYS2VJR0phbE1VV0thWWFQYXlt?= =?utf-8?B?WktmM2NHd2QyQWlHc0Q1cXY0ZHIwMUROeGY5V2NMaS9JYjFzYkNkK2g0Sm5v?= =?utf-8?B?dW9kbEtYZXRVV2ZyVkZtSmcyWlVDVUs1QU1aMlp6RDlaK1pKRThpN1ZpK1Bj?= =?utf-8?B?OEc3TnhDVUpDOG5YNmxQSzRmdVdaNk81clN3RG1GYzNvenVYenRlcGtwMFVt?= =?utf-8?B?amI5SW5HZVhKOGZPbXZPaW8vY3VvWWhQeDhUMGU0aEQrZVZVMm5xSHNXOE1a?= =?utf-8?B?alpORG43QlhIOWFoTjZJZWYyQjRpZGJ6VVk3MzlhZTJXMnpCd3NteXRGYVFq?= =?utf-8?B?NkwrS0F1OGxQa3dYaXRRSlN3c0ZFVWtjUnRjRTNWTDRTVjJtcFN2amVTRWlU?= =?utf-8?B?TTBSR1NDWnJua1MyV29OTnNvRFc0Z01hbVA2SVUySUFsSVdYNUU4REx1WWMw?= =?utf-8?Q?o8nRTZx7MTt18LaMurY58CghXZLzwYupIF+jwSD3HoM=3D?= X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB273; 6:lxsLdSnmq3bY58XDqU4JmoXEpxmn+R6BMNLMVxQ6fJ3lp1byO+dJ28YBo9HbPryZVTsF3bc8Ht4Z1b/U8tBGu2xVjnA+dDi+JuMBp7LIRN6cMc95Iw52E3b0fxoSW7+4yUsboZMyYq6QdsaS/TNREHJMfmnppnzLHBncJN/H+QpK6hNa4WCr8AdBKclDNXsj7nmQ7GbQs7lwQGMQRRfwsnjHvZtYseEQVmJ9wUNPgkYVFgQxxppF6Unekb+qrKdpAs4qpSQU0kUVbghytkz3jhzlzK5wcGCYTIV1hFIQ8P/bymmDPASd39XKZ9jhlz6JCO3LeH1VEJRnveube5pdwwHLTbcVmwuc2Ufnkg6o4mAtPdOIWTe6/Xrgq4FITiFfwaG90SUzcjnbaagBOx6lnA==; 5:tZwrTPBW6gdWfbsLmLhg5UWropZhLMShPbjSbTv99ZWYRm20oCShL1teM0jzadZFiGgerO1L1UoRAaYGQP96lq6YxuAuZ/9m3jnyc9horry1mgYcoiJCoKmsZbuOncHhbG2LeBVVDWSZhv7B/hihw8bWPzdUFp/3PgY8eBfOTrDVvnMFIfr/F1ox9SzzKJON; 24:TnjFkiAgtZNqehBabaKxQdMw33S03Yx7AS4daSupJuLWW8mzDQiV15NI+iq+6fH3Sk/Y54YV+0+be/1XxjmL2Y6MreHJh48Exf2bIE501N8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB273; 7:vt8KlwP0gfw3ebKbnBv5reDiViZSwuFQVSUzIV9IuiC4tMzzkdVfiU6pt6TBy4YN+L1QwHmA5C0gL/S8vgMKW7xeCb/VBFl3/A6OH0R+fXBaBmqQAfsO8LBtXoXRqi4bw/HTy9xJHb9AcSgx1uqVrHWNXUW8epRJbVKkj8WJg2ZvVtQkiobcICEbn2yfKlFOGu0gwVLHLiuKvaOK1ZmP0vpS5kjbnG8BCvTAtZJChsvxPQtavmnpu+G2NmZ9qaYHW0nyCDT5IvUAvJbQCOMjXahG5kVTFDoCr09+yQ/8PQ72IZ+bsD9ee9s1sx55JI5ip+6SkGcfEg4QaLVX5YIJNA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2017 08:41:26.5916 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB273 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP RNG instantiation was previously fixed by commit 62743a4145bb9 ("crypto: caam - fix RNG init descriptor ret. code checking") while deinstantiation was not addressed. Since the descriptors used are similar, in the sense that they both end with a JUMP HALT command, checking for errors should be similar too, i.e. status code 7000_0000h should be considered successful. Cc: # 3.13+ Fixes: 1005bccd7a4a6 ("crypto: caam - enable instantiation of all RNG4 state handles") Signed-off-by: Horia Geantă --- drivers/crypto/caam/ctrl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c index b3a94d5eff26..b7a36af5008d 100644 --- a/drivers/crypto/caam/ctrl.c +++ b/drivers/crypto/caam/ctrl.c @@ -285,7 +285,8 @@ static int deinstantiate_rng(struct device *ctrldev, int state_handle_mask) /* Try to run it through DECO0 */ ret = run_descriptor_deco0(ctrldev, desc, &status); - if (ret || status) { + if (ret || + (status && status != JRSTA_SSRC_JUMP_HALT_CC)) { dev_err(ctrldev, "Failed to deinstantiate RNG4 SH%d\n", sh_idx);