From patchwork Tue Jun 6 00:51:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jason A. Donenfeld" X-Patchwork-Id: 9767741 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 21C526034B for ; Tue, 6 Jun 2017 00:52:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 17FA227F8F for ; Tue, 6 Jun 2017 00:52:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0CC0A28446; Tue, 6 Jun 2017 00:52:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 716CF27F8F for ; Tue, 6 Jun 2017 00:52:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751486AbdFFAwK (ORCPT ); Mon, 5 Jun 2017 20:52:10 -0400 Received: from frisell.zx2c4.com ([192.95.5.64]:52481 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751448AbdFFAwH (ORCPT ); Mon, 5 Jun 2017 20:52:07 -0400 Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 9773302c; Tue, 6 Jun 2017 00:51:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=from:to:cc :subject:date:message-id:in-reply-to:references; s=mail; bh=1yJL ns3WB1X559vpcGA+HBeZM+0=; b=B+A9kHNRx6f17QG+Np+6kAq+OlBBhmEA8dV9 Lxk7WzXwDzB7bZ3xba4sMQCC9XG8I6AOPH5Lu6oj5lCuIqRsZGjU4dTaWEcaTz0J o4wZSWipvNmysCRuCDzYOiATOtqIUvESu2ojo25aZo+496sSBhIrAh2GnR+koypa +5uMk0VkF2wADIGT8NpX5HH0dCyyCOn2Z/Ch1FnfUzmrXhWnhazmzgn16U7Tw1oN 404cTyf4LlRd7yaQ1FwKemtk1zbdqwhyB5JUjSeBllv8lU6VwFFVm9sznz+VmQd8 seSgggl+mJQdF8xi516H4IUUpayEUo8C1DLpG+pbcHloW1+NJA== Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id cc8216c9 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Tue, 6 Jun 2017 00:51:48 +0000 (UTC) From: "Jason A. Donenfeld" To: Theodore Ts'o , Linux Crypto Mailing List , LKML , kernel-hardening@lists.openwall.com, Greg Kroah-Hartman , David Miller Cc: "Jason A. Donenfeld" Subject: [PATCH v3 11/13] net/route: use get_random_int for random counter Date: Tue, 6 Jun 2017 02:51:06 +0200 Message-Id: <20170606005108.5646-12-Jason@zx2c4.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170606005108.5646-1-Jason@zx2c4.com> References: <20170606005108.5646-1-Jason@zx2c4.com> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Using get_random_int here is faster, more fitting of the use case, and just as cryptographically secure. It also has the benefit of providing better randomness at early boot, which is when many of these structures are assigned. Also, semantically, it's not really proper to have been assigning an atomic_t in this way before, even if in practice it works fine. Signed-off-by: Jason A. Donenfeld Cc: David Miller --- net/ipv4/route.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 655d9eebe43e..11e001a42094 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -2936,8 +2936,7 @@ static __net_init int rt_genid_init(struct net *net) { atomic_set(&net->ipv4.rt_genid, 0); atomic_set(&net->fnhe_genid, 0); - get_random_bytes(&net->ipv4.dev_addr_genid, - sizeof(net->ipv4.dev_addr_genid)); + atomic_set(&net->ipv4.dev_addr_genid, get_random_int()); return 0; }