From patchwork Tue Jun 6 17:47:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jason A. Donenfeld" X-Patchwork-Id: 9769419 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7CFD46035D for ; Tue, 6 Jun 2017 17:50:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 792C627DCD for ; Tue, 6 Jun 2017 17:50:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6CB3D2842A; Tue, 6 Jun 2017 17:50:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F039E27DCD for ; Tue, 6 Jun 2017 17:50:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751787AbdFFRuB (ORCPT ); Tue, 6 Jun 2017 13:50:01 -0400 Received: from frisell.zx2c4.com ([192.95.5.64]:38383 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751596AbdFFRs3 (ORCPT ); Tue, 6 Jun 2017 13:48:29 -0400 Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 14b86d59; Tue, 6 Jun 2017 17:48:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=from:to:cc :subject:date:message-id:in-reply-to:references; s=mail; bh=DYVL sJwYLQejfUT5vVb6z1ChjFg=; b=gkrg+aTaRK+a/7cUetCHt3UekfcWSoa41aIK VByGEywAqm7Wu5OWJ5MHLYFT6vCCgqk1INi71voS0Yuv7xM/azjreBAgacqIbD/5 p8SLZlFrlrQ7jpUUeChGPtGTqkG6IfId8dFbBzPP6IUUYVHiX4pOvWP7cNCL1mIu MUWOpMLeE027qXKchy0cmJ2qXdpZcmSbN/15ySWHNqItR0O1q1mPGam9Ytrre+H+ /w+NZmHI6sNMZQdf4yX4vTg/SdydyGsgckiQzP+LiL4cUhquPmcn3zOqafLDBMSh yF+XYpi7SXD+mIAC3aNv93roFM86DEe9lBNmQ0XV74qSP6xKFw== Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 33beeb80 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Tue, 6 Jun 2017 17:48:04 +0000 (UTC) From: "Jason A. Donenfeld" To: Theodore Ts'o , Linux Crypto Mailing List , LKML , kernel-hardening@lists.openwall.com, Greg Kroah-Hartman , David Miller , Eric Biggers Cc: "Jason A. Donenfeld" , Steve French Subject: [PATCH v4 08/13] cifs: use get_random_u32 for 32-bit lock random Date: Tue, 6 Jun 2017 19:47:59 +0200 Message-Id: <20170606174804.31124-9-Jason@zx2c4.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170606174804.31124-1-Jason@zx2c4.com> References: <20170606174804.31124-1-Jason@zx2c4.com> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Using get_random_u32 here is faster, more fitting of the use case, and just as cryptographically secure. It also has the benefit of providing better randomness at early boot, which is sometimes when this is used. Signed-off-by: Jason A. Donenfeld Cc: Steve French --- fs/cifs/cifsfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c index 9a1667e0e8d6..fe0c8dcc7dc7 100644 --- a/fs/cifs/cifsfs.c +++ b/fs/cifs/cifsfs.c @@ -1359,7 +1359,7 @@ init_cifs(void) spin_lock_init(&cifs_tcp_ses_lock); spin_lock_init(&GlobalMid_Lock); - get_random_bytes(&cifs_lock_secret, sizeof(cifs_lock_secret)); + cifs_lock_secret = get_random_u32(); if (cifs_max_pending < 2) { cifs_max_pending = 2;