| Message ID | 20170613085254.20855-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
On Tue, 2017-06-13 at 09:52 +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Trivial fix to spelling mistake in seq_printf message Hey Colin. Fixing spelling typos is a good thing, but is it a good thing to change possibly API dependent output in seq_ calls? > diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c [] > @@ -399,7 +399,7 @@ static int nitrox_show(struct seq_file *s, void *v) > struct nitrox_device *ndev = s->private; > > seq_printf(s, "NITROX-5 [idx: %d]\n", ndev->idx); > - seq_printf(s, " Revsion ID: 0x%0x\n", ndev->hw.revision_id); > + seq_printf(s, " Revision ID: 0x%0x\n", ndev->hw.revision_id); > seq_printf(s, " Cores [AE: %u SE: %u]\n", > ndev->hw.ae_cores, ndev->hw.se_cores); > seq_printf(s, " Number of Queues: %u\n", ndev->nr_queues);
On 13/06/17 11:36, Joe Perches wrote: > On Tue, 2017-06-13 at 09:52 +0100, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> Trivial fix to spelling mistake in seq_printf message > > Hey Colin. > > Fixing spelling typos is a good thing, but is it a > good thing to change possibly API dependent output > in seq_ calls? Considering it's in -next and has not landed in upstream I supposed it was better to fix it now before it landed in Linus' repo. Colin > >> diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c > [] >> @@ -399,7 +399,7 @@ static int nitrox_show(struct seq_file *s, void *v) >> struct nitrox_device *ndev = s->private; >> >> seq_printf(s, "NITROX-5 [idx: %d]\n", ndev->idx); >> - seq_printf(s, " Revsion ID: 0x%0x\n", ndev->hw.revision_id); >> + seq_printf(s, " Revision ID: 0x%0x\n", ndev->hw.revision_id); >> seq_printf(s, " Cores [AE: %u SE: %u]\n", >> ndev->hw.ae_cores, ndev->hw.se_cores); >> seq_printf(s, " Number of Queues: %u\n", ndev->nr_queues); > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
On Tue, 2017-06-13 at 11:40 +0100, Colin Ian King wrote: > On 13/06/17 11:36, Joe Perches wrote: > > On Tue, 2017-06-13 at 09:52 +0100, Colin King wrote: > > > From: Colin Ian King <colin.king@canonical.com> > > > > > > Trivial fix to spelling mistake in seq_printf message > > Fixing spelling typos is a good thing, but is it a > > good thing to change possibly API dependent output > > in seq_ calls? > Considering it's in -next and has not landed in upstream I supposed it > was better to fix it now before it landed in Linus' repo. Good call, thanks. > > > diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c > > > > [] > > > @@ -399,7 +399,7 @@ static int nitrox_show(struct seq_file *s, void *v) > > > struct nitrox_device *ndev = s->private; > > > > > > seq_printf(s, "NITROX-5 [idx: %d]\n", ndev->idx); > > > - seq_printf(s, " Revsion ID: 0x%0x\n", ndev->hw.revision_id); > > > + seq_printf(s, " Revision ID: 0x%0x\n", ndev->hw.revision_id); > > > seq_printf(s, " Cores [AE: %u SE: %u]\n", > > > ndev->hw.ae_cores, ndev->hw.se_cores); > > > seq_printf(s, " Number of Queues: %u\n", ndev->nr_queues);
On Tue, Jun 13, 2017 at 09:52:54AM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Trivial fix to spelling mistake in seq_printf message > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Patch applied. Thanks.
diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c index eee6fb501580..ae44a464cd2d 100644 --- a/drivers/crypto/cavium/nitrox/nitrox_main.c +++ b/drivers/crypto/cavium/nitrox/nitrox_main.c @@ -399,7 +399,7 @@ static int nitrox_show(struct seq_file *s, void *v) struct nitrox_device *ndev = s->private; seq_printf(s, "NITROX-5 [idx: %d]\n", ndev->idx); - seq_printf(s, " Revsion ID: 0x%0x\n", ndev->hw.revision_id); + seq_printf(s, " Revision ID: 0x%0x\n", ndev->hw.revision_id); seq_printf(s, " Cores [AE: %u SE: %u]\n", ndev->hw.ae_cores, ndev->hw.se_cores); seq_printf(s, " Number of Queues: %u\n", ndev->nr_queues);