From patchwork Mon Jul 31 20:49:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9873125 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EF97B602F0 for ; Mon, 31 Jul 2017 20:50:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DC0A4285DA for ; Mon, 31 Jul 2017 20:50:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CE76A285ED; Mon, 31 Jul 2017 20:50:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5735B285DA for ; Mon, 31 Jul 2017 20:50:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751052AbdGaUt7 (ORCPT ); Mon, 31 Jul 2017 16:49:59 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:52625 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbdGaUt6 (ORCPT ); Mon, 31 Jul 2017 16:49:58 -0400 Received: from wuerfel.lan ([78.43.238.10]) by mrelayeu.kundenserver.de (mreue103 [212.227.15.145]) with ESMTPA (Nemesis) id 0Mgpo8-1dGKu60AXg-00M1Pc; Mon, 31 Jul 2017 22:49:42 +0200 From: Arnd Bergmann To: Tom Lendacky , Gary Hook , Herbert Xu , "David S. Miller" Cc: Arnd Bergmann , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] crypto: ccp - avoid uninitialized variable warning Date: Mon, 31 Jul 2017 22:49:21 +0200 Message-Id: <20170731204936.1511542-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:16J3E1+kV4HMxtzQV1ny80lm2I5Vm4rS5MnLH/cKavrH6a6XhUG MzPxP0kK7pZl+guyooNoqI+9APUemEMcUbFHE1Avs3PzBHDf371dAly/nG9c7hs+ufbj6fh inVsAptkHciboe5kjz+SgVI/sJHcyYtkGLQRVVUJJSff0ZaTMI5fASW+k8iRmQy9Nj+/emI 8tcAtsJYGMIRyfvR+CM0w== X-UI-Out-Filterresults: notjunk:1; V01:K0:fueGUMRI/Gc=:yZbwCUR7Bz/xgcf01PS7Qr eZNUMjAJdlgwprty+isYIlkSYqrF4NVNT323aLsQ1eoIBtPLfYLWVQmqv8UmSJN0lLUhZFvrm u0W2/2PJlxdq9CDcz1HHIUORBw76NvPmmiJasgHxHD/Zg5tfEVTQ7U01eUzKnmsFmrm+iyqQm 0LfIboXkXg+p6aGy6UWaTtV9I3lxcO68A8YXQ0ok2a5UtHyh9G5yrp5cKOiz6f0IA7lDA3cm7 GENK+hcC3ADfgpJN9S/cQtRvE+cjibQTRxR4qtB4fELZfdv0cGH1F5rch+TA4clwmhgcSxvvd 2KAbCYBOh18SwUYHQ8ibf602BLFLSiKSXU7EpSAMnS3JvJ/MwL8/Jn5iAAg/i3uk3R/6AiziN PF5eopFFeomdgXvwhGqYtCPESmDv9B1KIPQwfHCzBDN+KSC40Wru6NGe8qjHdSRZdcXcScsnD nmQxXLumJquMlT7Dk3C5tPe1AdXD4edmxhxYAxVOfq9LL2F6v+k8NSB3UiSDp327jn5eYOKyW XP2Yy924S43I1cTYu4TCFG5eeS1VnA8C4I6D+n8XZOOh1bbuGbubaBWS6BurKXUVS2Vjq++SW gVbckDMlTsU7YRXGuFX+WDADf6CZKTe63MFj87FJlj30QYDVLK3zIVd3nHBKmTKCd3nGwuLYp 0Q6hbMjUwJCVzajj9uHtPxPVXwD3qTBD9lXmNZKt5z+tbOf1xG2SC+zAqSGzvOdhEDbuL5yjB Tbl2Ad7EmlwOSUPAAcVmGrLKPL/r7KEJY4Cqyg== Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The added support for version 5 CCPs introduced a false-positive warning in the RSA implementation: drivers/crypto/ccp/ccp-ops.c: In function 'ccp_run_rsa_cmd': drivers/crypto/ccp/ccp-ops.c:1856:3: error: 'sb_count' may be used uninitialized in this function [-Werror=maybe-uninitialized] This changes the code in a way that should make it easier for the compiler to track the state of the sb_count variable, and avoid the warning. Fixes: 6ba46c7d4d7e ("crypto: ccp - Fix base RSA function for version 5 CCPs") Signed-off-by: Arnd Bergmann Reviewed-by: Gary R Hook --- drivers/crypto/ccp/ccp-ops.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c index 40c062ad8726..a8bc207b099a 100644 --- a/drivers/crypto/ccp/ccp-ops.c +++ b/drivers/crypto/ccp/ccp-ops.c @@ -1758,6 +1758,7 @@ static int ccp_run_rsa_cmd(struct ccp_cmd_queue *cmd_q, struct ccp_cmd *cmd) o_len = 32 * ((rsa->key_size + 255) / 256); i_len = o_len * 2; + sb_count = 0; if (cmd_q->ccp->vdata->version < CCP_VERSION(5, 0)) { /* sb_count is the number of storage block slots required * for the modulus. @@ -1852,7 +1853,7 @@ static int ccp_run_rsa_cmd(struct ccp_cmd_queue *cmd_q, struct ccp_cmd *cmd) ccp_dm_free(&exp); e_sb: - if (cmd_q->ccp->vdata->version < CCP_VERSION(5, 0)) + if (sb_count) cmd_q->ccp->vdata->perform->sbfree(cmd_q, op.sb_key, sb_count); return ret;