| Message ID | 20170731211104.2012741-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
On 07/31/2017 04:10 PM, Arnd Bergmann wrote: > Without the base RSA code, we run into a link error: > > ERROR: "rsa_parse_pub_key" [drivers/crypto/ccp/ccp-crypto.ko] undefined! > ERROR: "rsa_parse_priv_key" [drivers/crypto/ccp/ccp-crypto.ko] undefined! > > Like the other drivers implementing RSA in hardware, this > can be avoided by always enabling the base support when we build > CCP. > > Fixes: ceeec0afd684 ("crypto: ccp - Add support for RSA on the CCP") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/crypto/ccp/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig > index 15b63fd3d180..6d626606b9c5 100644 > --- a/drivers/crypto/ccp/Kconfig > +++ b/drivers/crypto/ccp/Kconfig > @@ -27,6 +27,7 @@ config CRYPTO_DEV_CCP_CRYPTO > select CRYPTO_HASH > select CRYPTO_BLKCIPHER > select CRYPTO_AUTHENC > + select CRYPTO_RSA > help > Support for using the cryptographic API with the AMD Cryptographic > Coprocessor. This module supports offload of SHA and AES algorithms. > Reviewed by: Gary R Hook <gary.hook@amd.com>
On Mon, Jul 31, 2017 at 11:10:57PM +0200, Arnd Bergmann wrote: > Without the base RSA code, we run into a link error: > > ERROR: "rsa_parse_pub_key" [drivers/crypto/ccp/ccp-crypto.ko] undefined! > ERROR: "rsa_parse_priv_key" [drivers/crypto/ccp/ccp-crypto.ko] undefined! > > Like the other drivers implementing RSA in hardware, this > can be avoided by always enabling the base support when we build > CCP. > > Fixes: ceeec0afd684 ("crypto: ccp - Add support for RSA on the CCP") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Patch applied. Thanks.
diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig index 15b63fd3d180..6d626606b9c5 100644 --- a/drivers/crypto/ccp/Kconfig +++ b/drivers/crypto/ccp/Kconfig @@ -27,6 +27,7 @@ config CRYPTO_DEV_CCP_CRYPTO select CRYPTO_HASH select CRYPTO_BLKCIPHER select CRYPTO_AUTHENC + select CRYPTO_RSA help Support for using the cryptographic API with the AMD Cryptographic Coprocessor. This module supports offload of SHA and AES algorithms.
Without the base RSA code, we run into a link error: ERROR: "rsa_parse_pub_key" [drivers/crypto/ccp/ccp-crypto.ko] undefined! ERROR: "rsa_parse_priv_key" [drivers/crypto/ccp/ccp-crypto.ko] undefined! Like the other drivers implementing RSA in hardware, this can be avoided by always enabling the base support when we build CCP. Fixes: ceeec0afd684 ("crypto: ccp - Add support for RSA on the CCP") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/crypto/ccp/Kconfig | 1 + 1 file changed, 1 insertion(+)