crypto: aesni: make arrays aesni_simd_skciphers and aesni_simd_skciphers2 static

Commit Message

Colin King Aug. 20, 2017, 9:34 p.m. UTC

From: Colin Ian King <[e-mail]>

Arrays aesni_simd_skciphers and aesni_simd_skciphers2 are local to the
source and do not need to be in global scope, so make them static.

Cleans up sparse warnings:
symbol 'aesni_simd_skciphers' was not declared. Should it be static?
symbol 'aesni_simd_skciphers2' was not declared. Should it be static?

Signed-off-by: Colin Ian King <[e-mail]>
---
 arch/x86/crypto/aesni-intel_glue.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Herbert Xu Sept. 22, 2017, 10:13 a.m. UTC | #1

On Sun, Aug 20, 2017 at 10:34:38PM +0100, Colin King wrote:
> From: Colin Ian King <[e-mail]>
> 
> Arrays aesni_simd_skciphers and aesni_simd_skciphers2 are local to the
> source and do not need to be in global scope, so make them static.
> 
> Cleans up sparse warnings:
> symbol 'aesni_simd_skciphers' was not declared. Should it be static?
> symbol 'aesni_simd_skciphers2' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <[e-mail]>

Patch applied.  Thanks.

Patch

diff --git a/arch/x86/crypto/aesni-intel_glue.c b/arch/x86/crypto/aesni-intel_glue.c
index 5c15d6b57329..c4c20286f27e 100644
--- a/arch/x86/crypto/aesni-intel_glue.c
+++ b/arch/x86/crypto/aesni-intel_glue.c
@@ -1067,9 +1067,10 @@  static struct skcipher_alg aesni_skciphers[] = {
 	}
 };
 
+static
 struct simd_skcipher_alg *aesni_simd_skciphers[ARRAY_SIZE(aesni_skciphers)];
 
-struct {
+static struct {
 	const char *algname;
 	const char *drvname;
 	const char *basename;