| Message ID | 20170824222016.731342-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
> 25 aug. 2017 kl. 01:20 skrev Arnd Bergmann <arnd@arndb.de>: > > Without CONFIG_DEBUG_FS, we get a harmless warning: > > drivers/crypto/axis/artpec6_crypto.c:352:23: error: 'dbgfs_root' defined but not used [-Werror=unused-variable] > > This moves it into the #ifdef that hides the only user. > > Fixes: a21eb94fc4d3 ("crypto: axis - add ARTPEC-6/7 crypto accelerator driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/crypto/axis/artpec6_crypto.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/axis/artpec6_crypto.c b/drivers/crypto/axis/artpec6_crypto.c > index d9fbbf01062b..0f9754e07719 100644 > --- a/drivers/crypto/axis/artpec6_crypto.c > +++ b/drivers/crypto/axis/artpec6_crypto.c > @@ -349,8 +349,6 @@ struct artpec6_crypto_aead_req_ctx { > /* The crypto framework makes it hard to avoid this global. */ > static struct device *artpec6_crypto_dev; > > -static struct dentry *dbgfs_root; > - > #ifdef CONFIG_FAULT_INJECTION > static DECLARE_FAULT_ATTR(artpec6_crypto_fail_status_read); > static DECLARE_FAULT_ATTR(artpec6_crypto_fail_dma_array_full); > @@ -2984,6 +2982,8 @@ struct dbgfs_u32 { > char *desc; > }; > > +static struct dentry *dbgfs_root; > + > static void artpec6_crypto_init_debugfs(void) > { > dbgfs_root = debugfs_create_dir("artpec6_crypto", NULL); > -- > 2.9.0 Acked-by: Lars Persson <larper@axis.com> Thanks, Lars
On Fri, Aug 25, 2017 at 12:19:54AM +0200, Arnd Bergmann wrote: > Without CONFIG_DEBUG_FS, we get a harmless warning: > > drivers/crypto/axis/artpec6_crypto.c:352:23: error: 'dbgfs_root' defined but not used [-Werror=unused-variable] > > This moves it into the #ifdef that hides the only user. > > Fixes: a21eb94fc4d3 ("crypto: axis - add ARTPEC-6/7 crypto accelerator driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Patch applied. Thanks.
diff --git a/drivers/crypto/axis/artpec6_crypto.c b/drivers/crypto/axis/artpec6_crypto.c index d9fbbf01062b..0f9754e07719 100644 --- a/drivers/crypto/axis/artpec6_crypto.c +++ b/drivers/crypto/axis/artpec6_crypto.c @@ -349,8 +349,6 @@ struct artpec6_crypto_aead_req_ctx { /* The crypto framework makes it hard to avoid this global. */ static struct device *artpec6_crypto_dev; -static struct dentry *dbgfs_root; - #ifdef CONFIG_FAULT_INJECTION static DECLARE_FAULT_ATTR(artpec6_crypto_fail_status_read); static DECLARE_FAULT_ATTR(artpec6_crypto_fail_dma_array_full); @@ -2984,6 +2982,8 @@ struct dbgfs_u32 { char *desc; }; +static struct dentry *dbgfs_root; + static void artpec6_crypto_init_debugfs(void) { dbgfs_root = debugfs_create_dir("artpec6_crypto", NULL);
Without CONFIG_DEBUG_FS, we get a harmless warning: drivers/crypto/axis/artpec6_crypto.c:352:23: error: 'dbgfs_root' defined but not used [-Werror=unused-variable] This moves it into the #ifdef that hides the only user. Fixes: a21eb94fc4d3 ("crypto: axis - add ARTPEC-6/7 crypto accelerator driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/crypto/axis/artpec6_crypto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)