| Message ID | 20170930083054.eeblfi65qpz2xop7@pd.tnic (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Herbert Xu |
| Headers | show |
On 9/30/17 3:30 AM, Borislav Petkov wrote: ... > From: Borislav Petkov <bp@suse.de> > > This is AMD-specific hardware so present it in Kconfig only when AMD > CPU support is enabled. > > Signed-off-by: Borislav Petkov <bp@suse.de> > Cc: Brijesh Singh <brijesh.singh@amd.com> > Cc: Tom Lendacky <thomas.lendacky@amd.com> > Cc: Gary Hook <gary.hook@amd.com> > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: linux-crypto@vger.kernel.org > --- > drivers/crypto/ccp/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig > index 627f3e61dcac..f58a6521270b 100644 > --- a/drivers/crypto/ccp/Kconfig > +++ b/drivers/crypto/ccp/Kconfig > @@ -1,5 +1,6 @@ > config CRYPTO_DEV_CCP_DD > tristate "Secure Processor device driver" > + depends on CPU_SUP_AMD Please note that ccp.ko is built on both x86 and aarch64 (AMD Seattle) architectures. I have not looked into details but I thought CPU_SUP_AMD is x64 specific config. I will look into it and verify that we don't break AMD Seattle platform builds. > default m > help > Provides AMD Secure Processor device driver.
On Sat, Sep 30, 2017 at 09:06:26AM -0500, Brijesh Singh wrote: > > diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig > > index 627f3e61dcac..f58a6521270b 100644 > > --- a/drivers/crypto/ccp/Kconfig > > +++ b/drivers/crypto/ccp/Kconfig > > @@ -1,5 +1,6 @@ > > config CRYPTO_DEV_CCP_DD > > tristate "Secure Processor device driver" > > + depends on CPU_SUP_AMD > > Please note that ccp.ko is built on both x86 and aarch64 (AMD Seattle) > architectures. I have not looked into details but I thought CPU_SUP_AMD > is x64 specific config. I will look into it and verify that we don't > break AMD Seattle platform builds. Ah, then I guess that line needs to be: depends on CPU_SUP_AMD || ARM64
diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig index 627f3e61dcac..f58a6521270b 100644 --- a/drivers/crypto/ccp/Kconfig +++ b/drivers/crypto/ccp/Kconfig @@ -1,5 +1,6 @@ config CRYPTO_DEV_CCP_DD tristate "Secure Processor device driver" + depends on CPU_SUP_AMD default m help Provides AMD Secure Processor device driver.