From patchwork Wed Oct 4 08:45:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chun-Yi Lee X-Patchwork-Id: 9983993 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1D506602B8 for ; Wed, 4 Oct 2017 08:45:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 10CA128620 for ; Wed, 4 Oct 2017 08:45:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 054F928A6C; Wed, 4 Oct 2017 08:45:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E7FE328620 for ; Wed, 4 Oct 2017 08:45:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751882AbdJDIpS (ORCPT ); Wed, 4 Oct 2017 04:45:18 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35090 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751736AbdJDIpQ (ORCPT ); Wed, 4 Oct 2017 04:45:16 -0400 Received: by mail-pf0-f194.google.com with SMTP id i23so11797101pfi.2; Wed, 04 Oct 2017 01:45:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=0fZKkcYKaH+XB/MgMlyiilolIZvgRWl6ORVsdFYNeDk=; b=YDTyBJli6BzMPCaQhRmFJmF6bnjcyh1U1hK6MH2Mhlz+P34AJ+cSeAJ8rqREXC8Dw4 C85PwGHX9GphOnSXktLSQy8TeALDAYF+j2rQkZwsyjdwe4c2BaWBuZ8YkdyKVC/vLx3P pDfp1uOj2feLwa4dxbZ3wsDI6b7a0TWAbHJF0lGvvqKCcNkXOtbnFl+A22J7VCx54UY5 SeusBpZm+zKoJT5PLwDf2WQlOc7cN441YGmFmLRiTkvbrWzaM53HwdJIlrV6c6IdQGcx 1OOYOcLLX/MqMnBGNYJdVR/Jo2o2aQdIkl0zf5A0W+lON7GnMK3C4Dp4+4hr9nRdiL1Y wYCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=0fZKkcYKaH+XB/MgMlyiilolIZvgRWl6ORVsdFYNeDk=; b=QuXiKcuVQ2tputnUsXukgtNirNUq0nsNsTgUQEYkYVNuzX67l6Gev54v2hJ2T6TKTD p68NCJQtlVUFXoSoSIHM2nyZInl+FCHcSzGh5lmK2AQM1Wezh4/QfNxqwq/fsEDWvypL 23HyXnpV4bqpW3Ky7E4Fh52SsvQAcjNUF41+PNiLPXfYJ4ThWfgNvcTTjR50VX5xwArX aOdaAj3vLlZ/dv1zawrlBIiNGZVHG2qh9wdyPspjWqkH1JHUa1BOtKcjHqLzGebpFXii qL6yn6XbOHszdeCKR6HzsyKdUr5r4mHhRLQJLNej05V8SG6Qnv7zSFs6zL0IePL+lCnb G5YQ== X-Gm-Message-State: AMCzsaUtOyXpYKBiEKf0GUOt2MaEHAJMgtW+xmEc8Lgd1nRTQMOSAWj7 tu+0UUo3EpBQwTS8ojxxw5s= X-Google-Smtp-Source: AOwi7QAim1GED9RPrF8l2Zvu3SSVCwgiQgMgQCbgjIxrOhQxYAWpAUjQKEkr1ThvrD/9zpa/e+WmCQ== X-Received: by 10.84.247.151 with SMTP id o23mr12102654pll.413.1507106716092; Wed, 04 Oct 2017 01:45:16 -0700 (PDT) Received: from linux-uc2j.site ([124.11.22.254]) by smtp.gmail.com with ESMTPSA id u74sm28102304pfk.125.2017.10.04.01.45.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 04 Oct 2017 01:45:15 -0700 (PDT) From: "Lee, Chun-Yi" X-Google-Original-From: "Lee, Chun-Yi" To: David Howells Cc: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, "Lee, Chun-Yi" , Herbert Xu , "David S. Miller" Subject: [PATCH] KEYS: checking the input id parameters before finding asymmetric key Date: Wed, 4 Oct 2017 16:45:09 +0800 Message-Id: <20171004084509.28481-1-jlee@suse.com> X-Mailer: git-send-email 2.10.2 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP For finding asymmetric key, the input id_0 and id_1 parameters can not be NULL at the same time. This patch adds the BUG_ON checking for id_0 and id_1. Cc: David Howells Cc: Herbert Xu Cc: "David S. Miller" Signed-off-by: "Lee, Chun-Yi" --- crypto/asymmetric_keys/asymmetric_type.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/crypto/asymmetric_keys/asymmetric_type.c b/crypto/asymmetric_keys/asymmetric_type.c index e4b0ed3..3a3b028 100644 --- a/crypto/asymmetric_keys/asymmetric_type.c +++ b/crypto/asymmetric_keys/asymmetric_type.c @@ -57,6 +57,8 @@ struct key *find_asymmetric_key(struct key *keyring, char *req, *p; int len; + BUG_ON(!id_0 && !id_1); + if (id_0) { lookup = id_0->data; len = id_0->len;