From patchwork Thu Oct 5 09:56:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Borislav Petkov X-Patchwork-Id: 9986695 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A2BC2602B8 for ; Thu, 5 Oct 2017 09:56:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 852B52832B for ; Thu, 5 Oct 2017 09:56:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 79AF128C03; Thu, 5 Oct 2017 09:56:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2B9582832B for ; Thu, 5 Oct 2017 09:56:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751434AbdJEJ4a (ORCPT ); Thu, 5 Oct 2017 05:56:30 -0400 Received: from mx2.suse.de ([195.135.220.15]:58366 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751298AbdJEJ43 (ORCPT ); Thu, 5 Oct 2017 05:56:29 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B12AFAB5F; Thu, 5 Oct 2017 09:56:26 +0000 (UTC) Date: Thu, 5 Oct 2017 11:56:05 +0200 From: Borislav Petkov To: Brijesh Singh Cc: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org Subject: Re: [Part2 PATCH v5 10/31] crypto: ccp: Add Platform Security Processor (PSP) device support Message-ID: <20171005095605.mhfudr5vwz2ptcxs@pd.tnic> References: <20171004131412.13038-1-brijesh.singh@amd.com> <20171004131412.13038-11-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20171004131412.13038-11-brijesh.singh@amd.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Oct 04, 2017 at 08:13:51AM -0500, Brijesh Singh wrote: > The Platform Security Processor (PSP) is part of AMD Secure Processor > (AMD-SP), PSP is a dedicated processor that provides the support for > key management commands in a Secure Encrypted Virtualization (SEV) mode, > along with software-based Trusted Execution Environment (TEE) to enable > the third-party trusted applications. > > Note that the key management functionality provided by the SEV firmware > can be used outside the kvm-amd driver hence we don't do depends on > CONFIG_KVM_AMD. Minor corrections: "The Platform Security Processor (PSP) is part of the AMD Secure Processor (AMD-SP) functionality. The PSP is a dedicated processor that provides support for key management commands in Secure Encrypted Virtualization (SEV) mode, along with software-based Trusted Execution Environment (TEE) to enable third-party trusted applications. Note that the key management functionality provided by the SEV firmware can be used outside of the kvm-amd driver hence it doesn't need to depend on CONFIG_KVM_AMD." ... > diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig > index 9c84f9838931..454c25d9f197 100644 > --- a/drivers/crypto/ccp/Kconfig > +++ b/drivers/crypto/ccp/Kconfig > @@ -33,3 +33,14 @@ config CRYPTO_DEV_CCP_CRYPTO > Support for using the cryptographic API with the AMD Cryptographic > Coprocessor. This module supports offload of SHA and AES algorithms. > If you choose 'M' here, this module will be called ccp_crypto. > + > +config CRYPTO_DEV_SP_PSP > + bool "Platform Security Processor (PSP) device" > + default y > + depends on CRYPTO_DEV_CCP_DD && X86_64 > + help > + Provide the support for the AMD Platform Security Processor (PSP). > + The PSP is a dedicated processor that provides support for key > + management commands in Secure Encrypted Virtualization (SEV) mode, > + along with software-based Trusted Execution Environment (TEE) to > + enable the third-party trusted applications. Minor corrections: --- with that taken care of: Reviewed-by: Borislav Petkov diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig index 454c25d9f197..b9dfae47aefd 100644 --- a/drivers/crypto/ccp/Kconfig +++ b/drivers/crypto/ccp/Kconfig @@ -39,8 +39,8 @@ config CRYPTO_DEV_SP_PSP default y depends on CRYPTO_DEV_CCP_DD && X86_64 help - Provide the support for the AMD Platform Security Processor (PSP). + Provide support for the AMD Platform Security Processor (PSP). The PSP is a dedicated processor that provides support for key management commands in Secure Encrypted Virtualization (SEV) mode, along with software-based Trusted Execution Environment (TEE) to - enable the third-party trusted applications. + enable third-party trusted applications.