| Message ID | 20171118134545.25784-1-christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
Hi Christophe, On 18 November 2017 at 19:15, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > 'dev' is leaking in the error handling path of 'hifn_probe()'. > > Add a 'kfree(dev)' to match the code in 'hifn_remove()' > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/crypto/hifn_795x.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c > index e09d4055b19e..a5a36fe7bf2c 100644 > --- a/drivers/crypto/hifn_795x.c > +++ b/drivers/crypto/hifn_795x.c > @@ -2579,6 +2579,7 @@ static int hifn_probe(struct pci_dev *pdev, const struct pci_device_id *id) > for (i = 0; i < 3; ++i) > if (dev->bar[i]) > iounmap(dev->bar[i]); > + kfree(dev); > > err_out_free_regions: > pci_release_regions(pdev); > -- > 2.14.1 > Nice catch. Reviewed-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> Regards, PrasannaKumar
On Sat, Nov 18, 2017 at 02:45:45PM +0100, Christophe JAILLET wrote: > 'dev' is leaking in the error handling path of 'hifn_probe()'. > > Add a 'kfree(dev)' to match the code in 'hifn_remove()' > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Patch applied. Thanks.
diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c index e09d4055b19e..a5a36fe7bf2c 100644 --- a/drivers/crypto/hifn_795x.c +++ b/drivers/crypto/hifn_795x.c @@ -2579,6 +2579,7 @@ static int hifn_probe(struct pci_dev *pdev, const struct pci_device_id *id) for (i = 0; i < 3; ++i) if (dev->bar[i]) iounmap(dev->bar[i]); + kfree(dev); err_out_free_regions: pci_release_regions(pdev);
'dev' is leaking in the error handling path of 'hifn_probe()'. Add a 'kfree(dev)' to match the code in 'hifn_remove()' Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/crypto/hifn_795x.c | 1 + 1 file changed, 1 insertion(+)